[Bug 1806219] New: Review Request: golang-github-jingweno-ccat - Colorizing `cat`

https://bugzilla.redhat.com/show_bug.cgi?id=1806219

Bug ID: 1806219
           Summary: Review Request: golang-github-jingweno-ccat -
                    Colorizing `cat`
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://raw.githubusercontent.com/skywalkerz0r/golang-github-jingweno-ccat/m...
SRPM URL:
https://download.copr.fedorainfracloud.org/results/brandfbb/golang-testing/f...
Description: Colorizing `cat`
Fedora Account System Username: brandfbb

[Bug 1806219] Review Request: golang-github-jingweno-ccat - Colorizing `cat`

https://bugzilla.redhat.com/show_bug.cgi?id=1806219

Nikola Forró  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review?

[Bug 1806219] Review Request: golang-github-jingweno-ccat - Colorizing `cat`

https://bugzilla.redhat.com/show_bug.cgi?id=1806219

Nikola Forró  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Nikola Forró  ---
For a start:

* SRPM URL is invalid. I used [1] instead, but please fix it.

* I believe Release tag should be set to "1%{?dist}", not "1%{dist}".

* /usr/bin/ccat is already provided by ccrypt in Fedora.

[1]
https://download.copr.fedorainfracloud.org/results/brandfbb/golang-testing/f...

[Bug 1806219] Review Request: golang-github-jingweno-ccat - Colorizing `cat`

https://bugzilla.redhat.com/show_bug.cgi?id=1806219

--- Comment #2 from Nikola Forró  ---
Imports in source files refer to "github.com/jingweno/ccat/Godeps/_workspace/".
That doesn't seem right and should be fixed, ideally upstream.

[Bug 1806219] Review Request: golang-github-jingweno-ccat - Colorizing `cat`

https://bugzilla.redhat.com/show_bug.cgi?id=1806219

--- Comment #3 from Breno  ---
This spec file was generated with go2rpm.
Please see here[1] for more information.

However, I found interesting the fact that we already have a ccat.
I need to see how to procedure in this case.

Please, check [1] and meanwhile I will see if I will have to give up having
this package on fedora.

1 https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/

[Bug 1806219] Review Request: golang-github-jingweno-ccat - Colorizing `cat`

https://bugzilla.redhat.com/show_bug.cgi?id=1806219

--- Comment #4 from Nikola Forró  ---
> This spec file was generated with go2rpm.

I'm aware, but that doesn't make any of my points invalid.
In fact, go2rpm on my end generates: "Release:        1%{?dist}"
> However, I found interesting the fact that we already have a ccat.
> I need to see how to procedure in this case.

You can rename the binary, or you can convince ccrypt to rename theirs (perhaps
they would be ok with it, since AFAICS ccat is just a convenience alias to
ccrypt --cat).
I don't think there is any other option, as ccat from ccrypt has a completely
different purpose, so you can't use alternatives or similar mechanism to deal
with the conflict.

needinfo canceled: [Bug 1806219] Review Request: golang-github-jingweno-ccat - Colorizing `cat`

Product: Fedora
Version: rawhide
Component: Package Review

Nikola Forró  has canceled Package Review
's request for Nikola Forró
's needinfo:
Bug 1806219: Review Request: golang-github-jingweno-ccat - Colorizing `cat`
https://bugzilla.redhat.com/show_bug.cgi?id=1806219

--- Comment #6 from Nikola Forró  ---
Breno, are you still interested in packaging this?

[Bug 1806219] Review Request: golang-github-jingweno-ccat - Colorizing `cat`

https://bugzilla.redhat.com/show_bug.cgi?id=1806219

Nikola Forró  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |needinfo?([e-mail]
                   |)                           |m)

--- Comment #6 from Nikola Forró  ---
Breno, are you still interested in packaging this?

[Bug 1806219] Review Request: golang-github-jingweno-ccat - Colorizing `cat`

https://bugzilla.redhat.com/show_bug.cgi?id=1806219

Breno  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |m)                          |

--- Comment #7 from Breno  ---
Hey, I really missed this one. I will review the spec file and send it to you
again Nikola.
Thanks for the reminder. Life's been busy.

[Bug 1806219] Review Request: golang-github-jingweno-ccat - Colorizing `cat`

https://bugzilla.redhat.com/show_bug.cgi?id=1806219

Breno  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|ASSIGNED                    |CLOSED
        Last Closed|                            |2021-11-19 03:42:11

--- Comment #8 from Breno  ---
I won't build this package anymore.