[Bug 2156962] New: Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962

Bug ID: 2156962
           Summary: Review Request: rust-tree_magic_mini - Determines the
                    MIME type of a file by traversing a filetype tree
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://salimma.fedorapeople.org/rust-tree_magic_mini.spec
SRPM URL:
https://salimma.fedorapeople.org/rust-tree_magic_mini-3.0.3-1.fc37.src.rpm

Description:
Determines the MIME type of a file by traversing a filetype tree.

Fedora Account System Username: salimma

[Bug 2156962] Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962

Michel Alexandre Salim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2156961
                   |                            |(ITP-rust-difftastic)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2156961
[Bug 2156961] ITP: rust-difftastic - Structural diff that understands syntax

[Bug 2156962] Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962

Davide Cavalca  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review+
                 CC|                            |[e-mail]
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]

--- Comment #1 from Davide Cavalca  ---
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

[Bug 2156962] Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962

--- Comment #2 from Michel Alexandre Salim  ---
Thanks!

src/fedora/pkgs-sig-rust 
⬢ [fedora-toolbox:37] ❯ set -gx C tree_magic_mini

src/fedora/pkgs-sig-rust 
⬢ [fedora-toolbox:37] ❯ set -gx B 2156962

src/fedora/pkgs-sig-rust 
⬢ [fedora-toolbox:37] ❯ fedpkg request-repo rust-$C $B
https://pagure.io/releng/fedora-scm-requests/issue/50074

src/fedora/pkgs-sig-rust took 4s 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/50075
https://pagure.io/releng/fedora-scm-requests/issue/50076

src/fedora/pkgs-sig-rust took 7s 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C epel9
https://pagure.io/releng/fedora-scm-requests/issue/50077

[Bug 2156962] Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962

--- Comment #3 from Kevin Fenzi  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-tree_magic_mini

[Bug 2156962] Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Fabio Valentini  ---
> package builds and installs without errors on rawhide

Have you actually checked this or did you only paste my review template?
One of the built packages fails to install with a missing dependency:

Error: 
 Problem 1: conflicting requests
  - nothing provides (crate(tree_magic_db/default) >= 3.0.0 with
crate(tree_magic_db/default) < 4.0.0~) needed by
rust-tree_magic_mini+tree_magic_db-devel-3.0.3-1.fc38.noarch
 Problem 2: package
rust-tree_magic_mini+with-gpl-data-devel-3.0.3-1.fc38.noarch requires
crate(tree_magic_mini/tree_magic_db) = 3.0.3, but none of the providers can be
installed
  - conflicting requests
  - nothing provides (crate(tree_magic_db/default) >= 3.0.0 with
crate(tree_magic_db/default) < 4.0.0~) needed by
rust-tree_magic_mini+tree_magic_db-devel-3.0.3-1.fc38.noarch
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use
not only best candidate packages)
WARNING: Failed install built packages

(i.e. the optional "with-gpl-data" feature depends on the tree_magic_db crate,
which is not packaged)

[Bug 2156962] Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962

Michel Alexandre Salim  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |2158272

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2158272
[Bug 2158272] Review Request: rust-tree_magic_db - Packages the FreeDesktop.org
shared MIME database for optional use with tree_magic_mini

[Bug 2156962] Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #5 from Fedora Update System  ---
FEDORA-EPEL-2023-7c5c162f7e has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e

[Bug 2156962] Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #6 from Fedora Update System  ---
FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 testing
repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-7c5c162f7e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2156962] Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |MODIFIED

--- Comment #7 from Fedora Update System  ---
FEDORA-2023-4eaf0ab067 has been submitted as an update to Fedora 37.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-4eaf0ab067

[Bug 2156962] Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962

--- Comment #8 from Fedora Update System  ---
FEDORA-2023-3514393fb3 has been submitted as an update to Fedora 36.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-3514393fb3

[Bug 2156962] Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2023-01-08 01:20:12

--- Comment #9 from Fedora Update System  ---
FEDORA-2023-4eaf0ab067 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2156962] Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962
Bug 2156962 depends on bug 2158272, which changed state.

Bug 2158272 Summary: Review Request: rust-tree_magic_db - Packages the FreeDesktop.org shared MIME database for optional use with tree_magic_mini
https://bugzilla.redhat.com/show_bug.cgi?id=2158272

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA

[Bug 2156962] Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962

--- Comment #10 from Fedora Update System  ---
FEDORA-2023-3514393fb3 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2156962] Review Request: rust-tree_magic_mini - Determines the MIME type of a file by traversing a filetype tree

https://bugzilla.redhat.com/show_bug.cgi?id=2156962

--- Comment #11 from Fedora Update System  ---
FEDORA-EPEL-2023-7c5c162f7e has been pushed to the Fedora EPEL 9 stable
repository.
If problem still persists, please make note of it in this bug report.