[Bug 1349380] New: Review Request: libzmf - a library for import of Zoner document formats

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349380

Bug ID: 1349380
           Summary: Review Request: libzmf - a library for import of Zoner
                    document formats
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://dtardon.fedorapeople.org/rpm/libzmf.spec
SRPM URL: https://dtardon.fedorapeople.org/rpm/libzmf-0.0.0-1.fc24.src.rpm
Description: libzmf is library providing ability to interpret and import Zoner
document formats into various applications. Currently it only supports Zoner
Callisto/Draw v 4-5.
Fedora Account System Username: dtardon

This will be a dependency of libreoffice 5.3.

[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349380

David Tardon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from David Tardon  ---
Copr builds:
https://copr.fedoraproject.org/coprs/dtardon/pending-review/build/361498/

[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349380

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349380

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|                            |libzmf

[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349380

--- Comment #2 from David Tardon  ---
Spec URL: https://dtardon.fedorapeople.org/rpm/libzmf.spec
SRPM URL: https://dtardon.fedorapeople.org/rpm/libzmf-0.0.1-1.fc24.src.rpm
Copr builds:
https://copr.fedorainfracloud.org/coprs/dtardon/pending-review/build/450316/

[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349380

Igor Gnatenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|                            |fedora-review+

--- Comment #3 from Igor Gnatenko  ---
Looks like I completely forgot about this, sorry.
> make %{?_smp_mflags}

%make_build
> make install DESTDIR=%{buildroot}

%make_install

* Missing BuildRequires: gcc-c++

[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349380

Ralf Corsepius  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Ralf Corsepius  ---
(In reply to Igor Gnatenko from comment #3)
> Looks like I completely forgot about this, sorry.
> > make %{?_smp_mflags}
>
> %make_build
> > make install DESTDIR=%{buildroot}
>
> %make_install

Igor, enforcing these macros is not helpful. They are not mandatory.

[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349380

--- Comment #5 from Igor Gnatenko  ---
#------------------------------------------------------------------------------
# Tested features of make
# Output syncronization for parallel make:
%_make_output_sync %(! %{__make} --version -O >/dev/null 2>&1 || echo -O)

#------------------------------------------------------------------------------
# The "make" analogue, hiding the _smp_mflags magic from specs
%make_build %{__make} %{_make_output_sync} %{?_smp_mflags}

Basically %make_build is not anymore same as make %{?_smp_mflags} and I will
work with FPC to enforce such macro.

[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349380

--- Comment #6 from Ralf Corsepius  ---
@Igor, all these macros do is to obscure what they actually do. This is
featuritis and serves no technical purpose.

Enforcing them is infantile bureaucracy.

[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349380

--- Comment #7 from Igor Gnatenko  ---
(In reply to Ralf Corsepius from comment #6)
> @Igor, all these macros do is to obscure what they actually do. This is
> featuritis and serves no technical purpose.
>
> Enforcing them is infantile bureaucracy.

will you force people to remember what is %{_make_output_sync} and all other
macro which could be added in future? Answering why we need macro for this -
EL6/EL7 GNU Make doesn't support "-O", but 4.0+ does.

[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349380

--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/libzmf

[Bug 1349380] Review Request: libzmf - a library for import of Zoner document formats

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349380

David Tardon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
           Assignee|[e-mail]        |[e-mail]
        Last Closed|                            |2016-09-08 09:58:29