[Bug 977130] New: Review Request: nodejs-iconv-lite - Convert character encodings in pure JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=977130
Bug ID: 977130 Summary: Review Request: nodejs-iconv-lite - Convert character encodings in pure JavaScript Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jamielinux@fedoraproject.org QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://jamielinux.fedorapeople.org/grunt/nodejs-iconv-lite.spec SRPM URL: http://jamielinux.fedorapeople.org/grunt/SRPMS/nodejs-iconv-lite-0.2.10-1.fc... Fedora Account System Username: jamielinux
Description: Convert character encodings in pure JavaScript.
https://bugzilla.redhat.com/show_bug.cgi?id=977130
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |977128
https://bugzilla.redhat.com/show_bug.cgi?id=977130
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews)
https://bugzilla.redhat.com/show_bug.cgi?id=977130
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tom@compton.nu Assignee|nobody@fedoraproject.org |tom@compton.nu Flags| |fedora-review?
--- Comment #1 from Tom Hughes tom@compton.nu ---
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
[?]: %check is present and all tests pass.
Unable to run tests as vows won't install as it depends on an older version of glob than is now in the repositories and iconv is not yet packaged.
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 10240 bytes in 2 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment).
===== SHOULD items =====
Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define.
===== EXTRA items =====
Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: nodejs-iconv-lite-0.2.10-1.fc20.noarch.rpm nodejs-iconv-lite.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-iconv-lite nodejs-iconv-lite.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:'
Requires -------- nodejs-iconv-lite (rpmlib, GLIBC filtered): nodejs(engine)
Provides -------- nodejs-iconv-lite: nodejs-iconv-lite npm(iconv-lite)
Source checksums ---------------- http://registry.npmjs.org/iconv-lite/-/iconv-lite-0.2.10.tgz : CHECKSUM(SHA256) this package : 586657e40a7895d0841ce448a96743b560db73fcaf080dc3bc13875f6c3b8504 CHECKSUM(SHA256) upstream package : 586657e40a7895d0841ce448a96743b560db73fcaf080dc3bc13875f6c3b8504
Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: compton-rawhide-x86_64 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 977130
https://bugzilla.redhat.com/show_bug.cgi?id=977130
--- Comment #2 from Tom Hughes tom@compton.nu --- Also I don't think the "generation" directory needs to be packaged - that is just the code used for generating the tables under the "encoding" directory.
https://bugzilla.redhat.com/show_bug.cgi?id=977130
--- Comment #3 from Jamie Nguyen jamielinux@fedoraproject.org --- Spec URL: http://jamielinux.fedorapeople.org/grunt/nodejs-iconv-lite.spec SRPM URL: http://jamielinux.fedorapeople.org/grunt/SRPMS/nodejs-iconv-lite-0.2.10-2.fc...
%changelog * Wed Jul 10 2013 Jamie Nguyen jamielinux@fedoraproject.org - 0.2.10-2 - do not package generation/ directory
npm(iconv) actually requires libiconv, which is not yet packaged for Fedora and sadly it doesn't seem to be a completely trivial package. It'd be nice to enable the test suite for nodejs-iconv-lite, but I'd rather tackle these additional at a later time (particularly as my interest in them is marginal at best ;).
https://bugzilla.redhat.com/show_bug.cgi?id=977130
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Tom Hughes tom@compton.nu --- It doesn't really need libiconv - it just needs the iconv_open and iconv functions which glibc provides. That is probably why libiconv isn't packaged for Fedora - because it isn't needed as glibc provides iconv.
In any case the tests aren't essential as they are only a SHOULD so I think we can say package is approved.
https://bugzilla.redhat.com/show_bug.cgi?id=977130
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Jamie Nguyen jamielinux@fedoraproject.org --- New Package SCM Request ======================= Package Name: nodejs-iconv-lite Short Description: Convert character encodings in pure JavaScript Owners: jamielinux patches Branches: f18 f19 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=977130
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=977130
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=977130
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=977130
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- nodejs-iconv-lite-0.2.10-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-iconv-lite-0.2.10-2.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=977130
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- nodejs-iconv-lite-0.2.10-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-iconv-lite-0.2.10-2.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=977130
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- nodejs-iconv-lite-0.2.10-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-iconv-lite-0.2.10-2.el6
https://bugzilla.redhat.com/show_bug.cgi?id=977130
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- nodejs-iconv-lite-0.2.10-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-iconv-lite-0.2.10-3.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=977130
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- nodejs-iconv-lite-0.2.10-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-iconv-lite-0.2.10-3.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=977130
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- nodejs-iconv-lite-0.2.10-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-iconv-lite-0.2.10-3.el6
https://bugzilla.redhat.com/show_bug.cgi?id=977130
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- nodejs-iconv-lite-0.2.10-3.fc18 has been pushed to the Fedora 18 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=977130
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2013-07-17 17:31:47
https://bugzilla.redhat.com/show_bug.cgi?id=977130
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |nodejs-iconv-lite-0.2.10-3. | |fc19
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- nodejs-iconv-lite-0.2.10-3.fc19 has been pushed to the Fedora 19 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=977130
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-iconv-lite-0.2.10-3. |nodejs-iconv-lite-0.2.10-3. |fc19 |fc18
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- nodejs-iconv-lite-0.2.10-3.fc18 has been pushed to the Fedora 18 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=977130
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-iconv-lite-0.2.10-3. |nodejs-iconv-lite-0.2.10-3. |fc18 |el6
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- nodejs-iconv-lite-0.2.10-3.el6 has been pushed to the Fedora EPEL 6 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla