Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453
Bug ID: 906453 Summary: Review Request: bsfilter - Bayesian spam filter Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: mtasaka@fedoraproject.org
Spec URL: http://mtasaka.fedorapeople.org/Review_request/bsfilter/bsfilter.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/bsfilter/bsfilter-1.0.18-0.1.... Description: Bayesian spam filter. Fedora Account System Username: mtasaka Koji scratch build F-19: http://koji.fedoraproject.org/koji/taskinfo?taskID=4917760 F-18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4917758
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |906144
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453
--- Comment #1 from Mamoru TASAKA mtasaka@fedoraproject.org --- http://mtasaka.fedorapeople.org/Review_request/bsfilter/bsfilter-1.0.18-0.2.... http://mtasaka.fedorapeople.org/Review_request/bsfilter/bsfilter.spec
* Mon Feb 11 2013 Mamoru TASAKA mtasaka@fedoraproject.org - 1.0.18-0.2.rc4 - 1.0.18 rc4
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mschwendt@gmail.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453
Michael Schwendt mschwendt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #2 from Michael Schwendt mschwendt@gmail.com --- For this review, I've focused on:
| SHOULD: The reviewer should test that the package functions as described. | A package should not segfault instead of running, for example.
* I've installed and configured claws-mail-plugins-bsfilter and noticed that one can crash the plugin when configuring it sloppily: http://www.thewildbeast.co.uk/claws-mail/bugzilla/show_bug.cgi?id=2878
* I've built and installed bsfilter, which requires no configuration.
* When run within Claws Mail, bsfilter is redirected to --homedir ~/.claws-mail however, whereas when running it outside Claws Mail, it defaults to ~/.bsfilter. Hence I've set a link from ~/.bsfilter to ~/.claws-mail. Just taking a note of it here, this is unrelated to the packaging. ;-)
* I've edited my procmail setup to include two recipes from "bsfilter --help" (which is sort of a full manual page, btw, rather than ordinary --help output).
With that setup, bsfilter here _works for me_ and meanwhile has started marking Spam messages.
[...]
The packaging looks sane.
In particular, license GPLv2+ matches the preamble of the bsfilter script.
The "/usr/bin/env ruby" in the script could be replaced with a hardcoded /usr/bin/ruby: https://fedoraproject.org/wiki/Packaging:Ruby#Shebang_lines | | All other code should use #!/usr/bin/ruby.
The rpmlint W/E are commented on in the spec file already:
$ rpmlint bsfilter-1.0.18-0.2.rc4.fc.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint bsfilter-1.0.18-0.2.rc4.fc19.noarch.rpm bsfilter.noarch: E: incorrect-fsf-address /usr/bin/bsfilter bsfilter.noarch: E: incorrect-fsf-address /usr/share/doc/bsfilter-1.0.18/COPYING bsfilter.noarch: W: no-manual-page-for-binary bsfilter 1 packages and 0 specfiles checked; 2 errors, 1 warnings.
The %check section uses "|| :" and comments on it as a TODO item. Of course, this could mean that although bsfilter _seems to work_ here, some of its features may depend on stuff that also makes the few tests fail. https://fedoraproject.org/wiki/Packaging:Ruby#Running_test_suites
APPROVED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #3 from Mamoru TASAKA mtasaka@fedoraproject.org --- Thank you for review! I will check your comments later. Now write git request first.
New Package SCM Request ======================= Package Name: bsfilter Short Description: Bayesian spam filter Owners: mtasaka Branches: f17 f18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453
--- Comment #5 from Mamoru TASAKA mtasaka@fedoraproject.org --- Now I am trying to fix build for ruby-mecab with ruby 2.0.0
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- bsfilter-1.0.18-0.4.rc4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/bsfilter-1.0.18-0.4.rc4.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- bsfilter-1.0.18-0.4.rc4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/bsfilter-1.0.18-0.4.rc4.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2013-03-03 22:19:29
--- Comment #8 from Mamoru TASAKA mtasaka@fedoraproject.org --- Successfully built on F-19/18/17, push requested on F-18/17. Now closing. Thank you for review and git procedure.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- bsfilter-1.0.18-0.4.rc4.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=906453
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- bsfilter-1.0.18-0.4.rc4.fc18 has been pushed to the Fedora 18 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla