[Bug 1015778] New: Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities - package-review

List overview All Threads
Download

newer

[Bug 1015778] New: Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

older

[Bug 977589] New: Review Request:...

[Bug 1019435] New: Review Request:...

Red Hat Bugzilla

5 Oct 2013 5 Oct '13

5:53 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

Bug ID: 1015778 Summary: Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ktdreyer@ktdreyer.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org

Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-ruby-openid.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-ruby-openid-2.3.0-1.fc21.sr... Description: The Ruby OpenID library, with batteries included.

A Ruby library for verifying and serving OpenID identities. Ruby OpenID makes it easy to add OpenID authentication to your web applications.

Fedora Account System Username: ktdreyer

This is a rename of the "ruby-openid" package. As such, it follows http://fedoraproject.org/wiki/Package_Renaming_Process

-- You are receiving this mail because: You are on the CC list for the bug.

Show replies by thread

Red Hat Bugzilla

5 Oct 5 Oct

5:54 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

--- Comment #1 from Ken Dreyer ktdreyer@ktdreyer.com --- rpmlint output:

$ rpmlint rubygem-ruby-openid-2.3.0-1.fc21.src.rpm rubygem-ruby-openid.spec 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6027258

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

5:56 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

Ken Dreyer ktdreyer@ktdreyer.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |903854

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=903854 [Bug 903854] ruby-openid 2.2.2 is available

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

15 Oct 15 Oct

4:50 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

Mamoru TASAKA mtasaka@fedoraproject.org changed:

--- Comment #2 from Mamoru TASAKA mtasaka@fedoraproject.org --- I will take this.

Meanwhile, while my review request bug 912961 was already assigned to other people, would you take and review it?

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

17 Oct 17 Oct

2:15 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

--- Comment #3 from Mamoru TASAKA mtasaka@fedoraproject.org --- Initial notes:

* License - It seems that the correct license tag for -doc subpackage should be "ASL 2.0 and LGPLv2+ and MIT". Would you check this? (see attached) Also, it is preferred that some explanation is written on spec file about some detailed license information (or including license information notes in source rpm)

* Note that the licenses of files under test/data is somewhat unclear. Looking at linkparse.txt first and next the rest files, it seems that these files are copied from python openid (see:

https://svn.apache.org/repos/asf/incubator/heraldry/libraries/python/openid/...

https://svn.apache.org/repos/asf/incubator/heraldry/libraries/python/openid/... ). For now I don't think this is a blocker, however please try to clarify.

* Improper Obsoletes - Obsoletes: ruby-openid = 2.1.7-11 obsoletes "ruby-openid = 2.1.7-11" _only_ (not "no more than").

* Filtering depedendency from examples/ directory - The common way for this is to remove executable permission bits from all files under examples/ directory.

* Notes for documents - Files like "INSTALL.md" is in most cases not needed, because we install the software using packaged rpm (i.e. not by following the method written in INSTALL.md)

- I recommend to move "README.md" to main package, because it says "README", indicating the upstream want users to read this.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:16 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

--- Comment #4 from Mamoru TASAKA mtasaka@fedoraproject.org --- Created attachment 813204 --> https://bugzilla.redhat.com/attachment.cgi?id=813204&action=edit license analysis result

My license analysis result

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7:03 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

--- Comment #5 from Mamoru TASAKA mtasaka@fedoraproject.org --- Additional notes:

* Test suite files - Current ruby guidelines says not to include files under test/ into binary rpm:

https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test... See "Do not ship tests" . If you exclude test/ directory from -doc subpackage, "LGPLv2+" license tag is not needed.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

24 Oct 24 Oct

3:47 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

--- Comment #6 from Ken Dreyer ktdreyer@ktdreyer.com --- Thanks, I've filed https://github.com/openid/ruby-openid/issues/60 about the license question. I'm also excluding the test directory as you suggest, so we hopefully avoid the issue.

* Thu Oct 24 2013 Ken Dreyer ktdreyer@ktdreyer.com - 2.3.0-2 - Updates for review request (RHBZ #1015778) - Update license - Clean up whitespace - Adjust permissions on "examples" directory - Add link to upstream test suite encoding bug - Move README.md to main package - Exclude INSTALL.md file and "test" directory

Specific changes (in git): http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-ruby-openid.git/com...

Spec: http://ktdreyer.fedorapeople.org/reviews/rubygem-ruby-openid.spec SRPM: http://ktdreyer.fedorapeople.org/reviews/rubygem-ruby-openid-2.3.0-2.fc21.sr...

F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6092974

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

25 Oct 25 Oct

4:13 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

--- Comment #7 from Mamoru TASAKA mtasaka@fedoraproject.org --- For -2 * Obsoletes - What I said before is meant that Obsoletes lines must be changed to "Obsoletes: ruby-openid <= 2.1.7-11", for example (i.e. not = but <=)

* License tag - Ah, the license tag for the main package should be "Ruby and ASL 2.0 and MIT" (as lib/hmac/hmac.rb, lib/openid/yadis/htmltokenizer.rb are under Ruby). Please update the license tag again, sorry.

* Permission - It seems that some files in -doc subpackage have executable permission:

/usr/share/gems/gems/ruby-openid-2.3.0/examples/rails_openid/script/rails /usr/share/gems/gems/ruby-openid-2.3.0/examples/discover /usr/share/gems/doc/ruby-openid-2.3.0/rdoc/images/add.png /usr/share/gems/doc/ruby-openid-2.3.0/rdoc/images/arrow_up.png /usr/share/gems/doc/ruby-openid-2.3.0/rdoc/images/delete.png /usr/share/gems/doc/ruby-openid-2.3.0/rdoc/images/tag_blue.png

At least it seems wrong that png files have executable permission. * Note that the executable permission on /examples/rails_openid/script/rails, /examples/discover adds the dependency "/usr/bin/env" to -doc subpackage. You may also want to suppress this dependency (by also removing executable permission on these files, or to add filtering macro again (which is contrary to what I said before, however for this case it seems okay) )

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

27 Oct 27 Oct

5:03 p.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

--- Comment #8 from Ken Dreyer ktdreyer@ktdreyer.com --- (As a correction to comment #6: my license clarification request is at https://github.com/openid/ruby-openid/issues/64, not 60.)

(In reply to Mamoru TASAKA from comment #7)

...

* Note that the executable permission on 
  /examples/rails_openid/script/rails,
  /examples/discover adds the dependency "/usr/bin/env" to -doc
  subpackage. You may also want to suppress this dependency
  (by also removing executable permission on these files, or
   to add filtering macro again (which is contrary to what
   I said before, however for this case it seems okay) )

For the /usr/bin/env dependency in -doc, I switched that to /usr/bin/ruby. Please let me know if you're ok with this, or if you'd like me to adjust it further (ie. remove it altogether.)

The PNGs' executable bits is a bug in the rdoc gem. I've submitted https://github.com/rdoc/rdoc/pull/258 to fix this.

Here's the newest version.

* Sun Oct 27 2013 Ken Dreyer ktdreyer@ktdreyer.com - 2.3.0-3 - Updates for review request (RHBZ #1015778) - Update obsoletes - Update license - Remove /usr/bin/env from -doc auto-requires

Specific changes (in git): http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-ruby-openid.git/com...

Spec: http://ktdreyer.fedorapeople.org/reviews/rubygem-ruby-openid.spec SRPM: http://ktdreyer.fedorapeople.org/reviews/rubygem-ruby-openid-2.3.0-3.fc21.sr...

F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6105416

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

28 Oct 28 Oct

2:05 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

Mamoru TASAKA mtasaka@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #9 from Mamoru TASAKA mtasaka@fedoraproject.org --- (In reply to Ken Dreyer from comment #8)

...

The PNGs' executable bits is a bug in the rdoc gem. I've submitted https://github.com/rdoc/rdoc/pull/258 to fix this.

Ah, I did not notice this. Would you open a tracker bug for Fedora side?

For this package, approving.

------------------------------------------------------------ This package (rubygem-ruby-openid) is APPROVED by mtasaka ------------------------------------------------------------

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

5:48 p.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

--- Comment #10 from Ken Dreyer ktdreyer@ktdreyer.com --- Thanks for the review!

I've filed bug 1024122 for the PNG images in rubygem-rdoc.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

5:58 p.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

Ken Dreyer ktdreyer@ktdreyer.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #11 from Ken Dreyer ktdreyer@ktdreyer.com --- New Package SCM Request ======================= Package Name: rubygem-ruby-openid Short Description: A library for consuming and serving OpenID identities Owners: ktdreyer Branches: f19 f20

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

29 Oct 29 Oct

6:57 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

6:58 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

--- Comment #12 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

10:11 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

10:11 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- rubygem-ruby-openid-2.3.0-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-ruby-openid-2.3.0-3.fc20

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

10:12 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- rubygem-ruby-openid-2.3.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-ruby-openid-2.3.0-3.fc19

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

1:06 p.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- Package rubygem-ruby-openid-2.3.0-3.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing rubygem-ruby-openid-2.3.0-3.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-20238/rubygem-ruby-openi... then log in and leave karma (feedback).

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7 Nov 7 Nov

10:31 p.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

Fedora Update System updates@fedoraproject.org changed:

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- rubygem-ruby-openid-2.3.0-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10 Nov 10 Nov

12:09 a.m.

New subject: [Bug 1015778] Review Request: rubygem-ruby-openid - A library for consuming and serving OpenID identities

https://bugzilla.redhat.com/show_bug.cgi?id=1015778

Fedora Update System updates@fedoraproject.org changed:

--- Comment #17 from Fedora Update System updates@fedoraproject.org --- rubygem-ruby-openid-2.3.0-3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

4272

Age (days ago)

4308

Last active (days ago)

package-review@lists.fedoraproject.org

20 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla