[Bug 2279003] New: Review Request: aws-c-sdkutils - C99 library implementing AWS SDK specific utilities.
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
Bug ID: 2279003 Summary: Review Request: aws-c-sdkutils - C99 library implementing AWS SDK specific utilities. Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: dominik@wombacher.cc QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedor... SRPM URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedor... Description: C99 library implementing AWS SDK specific utilities. Includes utilities for ARN parsing, reading AWS profiles, etc... Fedora Account System Username: wombelix
Supersedes https://bugzilla.redhat.com/show_bug.cgi?id=2049397
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
Dominik Wombacher dominik@wombacher.cc changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |davdunc@amazon.com, | |domwom@amazon.de, | |mhayden@redhat.com, | |ngompa13@gmail.com Doc Type|--- |If docs needed, set a value
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/awslabs/ | |%{name}
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7403110 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
Dominik Wombacher dominik@wombacher.cc changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2049382, 2049792
--- Comment #2 from Dominik Wombacher dominik@wombacher.cc --- *** Bug 2049397 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2049382 [Bug 2049382] Review Request: aws-c-auth - C99 library implementation of AWS client-side authentication: standard credentials providers and signing. https://bugzilla.redhat.com/show_bug.cgi?id=2049792 [Bug 2049792] Review Request: aws-c-s3 - C99 library implementation for communicating with the Amazon S3 service
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
Dominik Wombacher dominik@wombacher.cc changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2240798, 2246663
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2240798 [Bug 2240798] Upgrade aws-c-common to latest release https://bugzilla.redhat.com/show_bug.cgi?id=2246663 [Bug 2246663] aws-c-common-0.9.17 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
Dominik Wombacher dominik@wombacher.cc changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2279008
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2279008 [Bug 2279008] Review Request: s2n-tls - A C99 implementation of the TLS/SSL protocols
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
Dominik Wombacher dominik@wombacher.cc changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2279009
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2279009 [Bug 2279009] Review Request: aws-c-io - IO package for AWS SDK for C
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
--- Comment #3 from Dominik Wombacher dominik@wombacher.cc --- Packaging order based on dependencies between AWS C libs:
1. aws-c-common [1][2] 2. aws-c-cal [3], aws-c-sdkutils [4], aws-c-compression [5], aws-checksums [6] 3. s2n-tls [7], aws-c-io [8] 4. aws-c-http [9], aws-c-event-stream [10] 5. aws-c-auth [11], aws-c-mqtt [12] 6. aws-c-s3 [13]
[1] https://bugzilla.redhat.com/show_bug.cgi?id=2240798 [2] https://bugzilla.redhat.com/show_bug.cgi?id=2246663 [3] https://bugzilla.redhat.com/show_bug.cgi?id=2049400 [4] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279003 [5] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279006 [6] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279007 [7] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279008 [8] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279009 [9] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279010 [10] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279011 [11] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279012 [12] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279013 [13] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279014
https://bugzilla.redhat.com/show_bug.cgi?id=2279003 Bug 2279003 depends on bug 2246663, which changed state.
Bug 2246663 Summary: aws-c-common-0.9.17 is available https://bugzilla.redhat.com/show_bug.cgi?id=2246663
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2279003 Bug 2279003 depends on bug 2240798, which changed state.
Bug 2240798 Summary: Upgrade aws-c-common to latest release https://bugzilla.redhat.com/show_bug.cgi?id=2240798
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
Dominik Wombacher dominik@wombacher.cc changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@emailplus.org
--- Comment #4 from Dominik Wombacher dominik@wombacher.cc --- *** Bug 2240805 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
Major Hayden 🤠 mhayden@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mhayden@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
Major Hayden 🤠 mhayden@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(dominik@wombacher | |.cc)
--- Comment #5 from Major Hayden 🤠 mhayden@redhat.com --- @dominik@wombacher.cc I can't seem to get aws-c-sdkutils to compile: https://koji.fedoraproject.org/koji/taskinfo?taskID=117388260
Are we missing another dependency?
The spec file looks okay to me so far.
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
Major Hayden 🤠 mhayden@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ |needinfo?(dominik@wombacher | |.cc) |
--- Comment #6 from Major Hayden 🤠 mhayden@redhat.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
No issues noted. Looks good. Approved. ✅
===== MUST items =====
C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "*No copyright* Apache License 2.0". 55 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/aws-c- sdkutils/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/cmake, /usr/src/debug, /usr/share, /usr/share/doc, /usr/include, /usr/lib, /usr/share/licenses, /usr/lib64, /usr/include/aws, /usr, /usr/src [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr, /usr/lib, /usr/lib64/cmake, /usr/share/licenses, /usr/src/debug, /usr/share, /usr/share/doc, /usr/lib64, /usr/include/aws, /usr/include, /usr/src [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 784 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [!]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in aws-c- sdkutils-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Rpmlint ------- Checking: aws-c-sdkutils-0.1.16-1.fc41.x86_64.rpm aws-c-sdkutils-libs-0.1.16-1.fc41.x86_64.rpm aws-c-sdkutils-devel-0.1.16-1.fc41.x86_64.rpm aws-c-sdkutils-debugsource-0.1.16-1.fc41.x86_64.rpm aws-c-sdkutils-0.1.16-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpdyefez7l')] checks: 32, packages: 5
aws-c-sdkutils-devel.x86_64: W: no-documentation aws-c-sdkutils.x86_64: E: no-binary aws-c-sdkutils.x86_64: E: explicit-lib-dependency aws-c-common-libs 5 packages and 0 specfiles checked; 2 errors, 1 warnings, 25 filtered, 2 badness; has taken 0.5 s
Rpmlint (debuginfo) ------------------- Checking: aws-c-sdkutils-libs-debuginfo-0.1.16-1.fc41.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpc4i2pdmw')] checks: 32, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 4 filtered, 0 badness; has taken 0.1 s
Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "aws-c-sdkutils-devel". (none): E: there is no installed rpm "aws-c-sdkutils". (none): E: there is no installed rpm "aws-c-sdkutils-debugsource". (none): E: there is no installed rpm "aws-c-sdkutils-libs-debuginfo". (none): E: there is no installed rpm "aws-c-sdkutils-libs". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5
0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s
Source checksums ---------------- https://github.com/awslabs/aws-c-sdkutils/archive/v0.1.16/aws-c-sdkutils-0.1... : CHECKSUM(SHA256) this package : 4a818563d7c6636b5b245f5d22d4d7c804fa33fc4ea6976e9c296d272f4966d3 CHECKSUM(SHA256) upstream package : 4a818563d7c6636b5b245f5d22d4d7c804fa33fc4ea6976e9c296d272f4966d3
Requires -------- aws-c-sdkutils (rpmlib, GLIBC filtered): aws-c-common-libs
aws-c-sdkutils-libs (rpmlib, GLIBC filtered): aws-c-sdkutils(x86-64) libaws-c-common.so.1()(64bit) libc.so.6()(64bit) rtld(GNU_HASH)
aws-c-sdkutils-devel (rpmlib, GLIBC filtered): aws-c-common-devel aws-c-sdkutils-libs(x86-64) cmake-filesystem(x86-64) libaws-c-sdkutils.so.1.0.0()(64bit)
aws-c-sdkutils-debugsource (rpmlib, GLIBC filtered):
Provides -------- aws-c-sdkutils: aws-c-sdkutils aws-c-sdkutils(x86-64)
aws-c-sdkutils-libs: aws-c-sdkutils-libs aws-c-sdkutils-libs(x86-64) libaws-c-sdkutils.so.1.0.0()(64bit)
aws-c-sdkutils-devel: aws-c-sdkutils-devel aws-c-sdkutils-devel(x86-64) cmake(aws-c-sdkutils)
aws-c-sdkutils-debugsource: aws-c-sdkutils-debugsource aws-c-sdkutils-debugsource(x86-64)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name aws-c-sdkutils --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: PHP, SugarActivity, fonts, Ocaml, Python, Perl, Haskell, Java, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
--- Comment #7 from Dominik Wombacher dominik@wombacher.cc --- Thanks for approving Major :)
(In reply to Major Hayden 🤠 from comment #5)
@dominik@wombacher.cc I can't seem to get aws-c-sdkutils to compile: https://koji.fedoraproject.org/koji/taskinfo?taskID=117388260
Are we missing another dependency?
The spec file looks okay to me so far.
Just for documentation purposes and context if someone looks into the Bug. We had a brief chat about this via Matrix.
The error is caused by aws-c-common 0.6.14. The 0.9.17 update is available in rawhide but for F40 it's still in testing stage [1]. So building against F41 will work (as seen above), for F40 we have to wait till the update moves to stable.
[1] https://bodhi.fedoraproject.org/updates/?packages=aws-c-common
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/aws-c-sdkutils
https://bugzilla.redhat.com/show_bug.cgi?id=2279003
Dominik Wombacher dominik@wombacher.cc changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2024-05-08 13:46:22
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com