[Bug 747008] New: Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

https://bugzilla.redhat.com/show_bug.cgi?id=747008

Summary: Review Request: drupal7-advanced_help - Allows module
                    developers to store their help outside the module
                    system in html
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail]
    Classification: Fedora
      Story Points: ---
              Type: ---

Spec URL: http://asrob.fedorapeople.org/SOURCES/drupal7-advanced_help.spec
SRPM URL:
http://asrob.fedorapeople.org/SOURCES/drupal7-advanced_help-1.0-0.1.beta1.fc...
Description: The advanced help module allows module developers to store their
help outside the module system, in pure .html files. The files can be easily
translated simply by copying them into the right translations directory.
The entire system can appear in a pop-up or not as the module prefers.

rpmlint output:

$ rpmlint drupal7-advanced_help.spec
../SRPMS/drupal7-advanced_help-1.0-0.1.beta1.fc15.src.rpm
../RPMS/noarch/drupal7-advanced_help-1.0-0.1.beta1.fc15.noarch.rpm 
drupal7-advanced_help.src: W: spelling-error Summary(en_US) html -> HTML, ht
ml, ht-ml
drupal7-advanced_help.src: W: spelling-error %description -l en_US html ->
HTML, ht ml, ht-ml
drupal7-advanced_help.noarch: W: spelling-error Summary(en_US) html -> HTML, ht
ml, ht-ml
drupal7-advanced_help.noarch: W: spelling-error %description -l en_US html ->
HTML, ht ml, ht-ml
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

koji output:

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=3440261
Watching tasks (this may be safely interrupted)...
3440261 build (dist-f15, drupal7-advanced_help-1.0-0.1.beta1.fc15.src.rpm):
free
3440261 build (dist-f15, drupal7-advanced_help-1.0-0.1.beta1.fc15.src.rpm):
free -> open (x86-15.phx2.fedoraproject.org)
  3440262 buildArch (drupal7-advanced_help-1.0-0.1.beta1.fc15.src.rpm, noarch):
free
  3440262 buildArch (drupal7-advanced_help-1.0-0.1.beta1.fc15.src.rpm, noarch):
free -> open (x86-04.phx2.fedoraproject.org)
  3440262 buildArch (drupal7-advanced_help-1.0-0.1.beta1.fc15.src.rpm, noarch):
open (x86-04.phx2.fedoraproject.org) -> closed
  0 free  1 open  1 done  0 failed
3440261 build (dist-f15, drupal7-advanced_help-1.0-0.1.beta1.fc15.src.rpm):
open (x86-15.phx2.fedoraproject.org) -> closed
  0 free  0 open  2 done  0 failed

3440261 build (dist-f15, drupal7-advanced_help-1.0-0.1.beta1.fc15.src.rpm)
completed successfully

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

Peter Borsa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |662103(InsightReviews)

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

Paul W. Frields  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

Paul W. Frields  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Paul W. Frields  2011-10-25 20:21:03 EDT ---
[ O K ] MUST: rpmlint must be run on every package. The output should be posted
in the review.

[ O K ] MUST: The package must be named according to the Package Naming
Guidelines.

[ O K ] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.

[ O K ] MUST: The package must meet the Packaging Guidelines.

[ O K ] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines.

[ O K ] MUST: The License field in the package spec file must match the actual
license.

[ O K ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.

[ O K ] MUST: The spec file must be written in American English.

[ O K ] MUST: The spec file for the package MUST be legible.

[ O K ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

$ md5sum
rpmbuild/SOURCES/drupal7-advanced_help-1.0/advanced_help-7.x-1.0-beta1.tar.gz ;
curl -s -o -
http://ftp.drupal.org/files/projects/advanced_help-7.x-1.0-beta1.tar.gz |
md5sum -
c25a39d3d4be4bf6d1dda4c29966ee7e 
rpmbuild/SOURCES/drupal7-advanced_help-1.0/advanced_help-7.x-1.0-beta1.tar.gz
c25a39d3d4be4bf6d1dda4c29966ee7e  -

[ O K ] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.

[ O K ] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.

[ O K ] MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.

[ O K ] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

[ O K ] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.

[ O K ] MUST: Packages must NOT bundle copies of system libraries.

[ O K ] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.

[ O K ] MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory.

[ O K ] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)

[ O K ] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line.

[ O K ] MUST: Each package must consistently use macros.

[ O K ] MUST: The package must contain code, or permissable content.

[ O K ] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).

[ O K ] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.

[ N/A ] MUST: Header files must be in a -devel package.

[ N/A ] MUST: Static libraries must be in a -static package.

[ N/A ] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.

[ N/A ] MUST: In the vast majority of cases, devel packages must require the
base package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}

[ O K ] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.

[ N/A ] MUST: Packages containing GUI applications must include a
%{name}.desktop file, and that file must be properly installed with
desktop-file-install in the %install section. If you feel that your packaged
GUI application does not need a .desktop file, you must put a comment in the
spec file with your explanation.

[ O K ] MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time.

[ O K ] MUST: All filenames in rpm packages must be valid UTF-8.

* * *
APPROVED.

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

Peter Borsa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #2 from Peter Borsa  2011-10-26 04:30:17 EDT ---
New Package SCM Request
=======================
Package Name: drupal7-advanced_help
Short Description: Allows module developers to store their help outside the
module system in html
Owners: asrob jsmith pfrields
Branches: f15 f16 el5 el6
InitialCC:

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

--- Comment #3 from Jon Ciesla  2011-10-26 07:53:10 EDT ---
Git done (by process-git-requests).

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

--- Comment #4 from Fedora Update System  2011-11-01 04:09:28 EDT ---
drupal7-advanced_help-1.0-0.1.beta1.fc15 has been submitted as an update for
Fedora 15.
https://admin.fedoraproject.org/updates/drupal7-advanced_help-1.0-0.1.beta1....

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

--- Comment #5 from Fedora Update System  2011-11-01 04:20:27 EDT ---
drupal7-advanced_help-1.0-0.1.beta1.fc16 has been submitted as an update for
Fedora 16.
https://admin.fedoraproject.org/updates/drupal7-advanced_help-1.0-0.1.beta1....

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

--- Comment #6 from Fedora Update System  2011-11-01 04:27:15 EDT ---
drupal7-advanced_help-1.0-0.1.beta1.el5 has been submitted as an update for
Fedora EPEL 5.
https://admin.fedoraproject.org/updates/drupal7-advanced_help-1.0-0.1.beta1....

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

--- Comment #7 from Fedora Update System  2011-11-01 04:32:53 EDT ---
drupal7-advanced_help-1.0-0.1.beta1.el6 has been submitted as an update for
Fedora EPEL 6.
https://admin.fedoraproject.org/updates/drupal7-advanced_help-1.0-0.1.beta1....

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

Peter Borsa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|                            |NEXTRELEASE
        Last Closed|                            |2011-11-01 04:33:39

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |drupal7-advanced_help-1.0-0
                   |                            |.1.beta1.el5
         Resolution|NEXTRELEASE                 |ERRATA

--- Comment #8 from Fedora Update System  2011-11-24 21:09:06 EST ---
drupal7-advanced_help-1.0-0.1.beta1.el5 has been pushed to the Fedora EPEL 5
stable repository.

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|drupal7-advanced_help-1.0-0 |drupal7-advanced_help-1.0-0
                   |.1.beta1.el5                |.1.beta1.el6

--- Comment #9 from Fedora Update System  2011-11-24 21:12:23 EST ---
drupal7-advanced_help-1.0-0.1.beta1.el6 has been pushed to the Fedora EPEL 6
stable repository.

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|drupal7-advanced_help-1.0-0 |drupal7-advanced_help-1.0-0
                   |.1.beta1.el6                |.1.beta1.fc15

--- Comment #10 from Fedora Update System  2011-11-24 21:21:34 EST ---
drupal7-advanced_help-1.0-0.1.beta1.fc15 has been pushed to the Fedora 15
stable repository.

[Bug 747008] Review Request: drupal7-advanced_help - Allows module developers to store their help outside the module system in html

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=747008

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|drupal7-advanced_help-1.0-0 |drupal7-advanced_help-1.0-0
                   |.1.beta1.fc15               |.1.beta1.fc16

--- Comment #11 from Fedora Update System  2011-12-03 21:41:51 EST ---
drupal7-advanced_help-1.0-0.1.beta1.fc16 has been pushed to the Fedora 16
stable repository.