[Bug 806093] New: Review Request: glade - User Interface Designer for GTK+ and GNOME

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: glade - User Interface Designer for GTK+ and GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=806093

           Summary: Review Request: glade - User Interface Designer for
                    GTK+ and GNOME
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: kalevlember(a)gmail.com
         QAContact: extras-qa(a)fedoraproject.org
                CC: notting(a)redhat.com,
                    package-review(a)lists.fedoraproject.org
    Classification: Fedora
      Story Points: ---
              Type: ---
        Regression: ---
        Mount Type: ---
     Documentation: ---


Spec URL: http://kalev.fedorapeople.org/glade.spec
SRPM URL: http://kalev.fedorapeople.org/glade-3.11.0-1.fc17.src.rpm
Description:
Glade is a RAD tool to enable quick and easy development of user interfaces for
the GTK+ toolkit and the GNOME desktop environment.

The user interfaces designed in Glade are saved as XML, which can be used in
numerous programming languages including C, C++, C#, Vala, Java, Perl, Python,
and others.

-----------------------------------------

This is the GTK+ 3 version of Glade.

During the gtk3 development cycle, upstream renamed 'glade3' to 'glade',
to
make the gtk2 and gtk3 versions parallel installable. 'glade3' is the gtk2
version and 'glade' is the gtk3 version. Confusingly enough,
 in Fedora we have the gtk3 version in 'glade3' package and don't have the
gtk2
version packaged up at all.

This package is the first step in getting back in line with upstream naming.

Upstream blog post about the rename:
http://blogs.gnome.org/tvb/2011/01/15/the-glade-dl/

Various tickets opened in Fedora bugzilla about providing both glade and
glade3:
https://bugzilla.redhat.com/show_bug.cgi?id=708834
https://bugzilla.redhat.com/show_bug.cgi?id=717763
https://bugzilla.redhat.com/show_bug.cgi?id=731227

P.S. I'm not yet sure how it's best to name the gtk2 compat package: should it
be 'glade3' like upstream is calling it, or should it be 'glade-gtk2' for
clarity? The latter would likely also involve renaming /us
r/bin/glade-3 to /usr/bin/glade-gtk2 as a downstream distro modification, so
I'm not sure we'd want to take that route.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 806093] Review Request: glade - User Interface Designer for GTK+ and GNOME

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806093

--- Comment #1 from Kalev Lember <kalevlember(a)gmail.com&gt; 2012-04-04 07:24:39 EDT
---
Spec URL: http://kalev.fedorapeople.org/glade.spec
SRPM URL: http://kalev.fedorapeople.org/glade-3.12.0-1.fc17.src.rpm

* Wed Apr 04 2012 Kalev Lember <kalevlember(a)gmail.com&gt; - 3.12.0-1
- Update to 3.12.0

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 806093] Review Request: glade - User Interface Designer for GTK+ and GNOME

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806093

Matthias Clasen <mclasen(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mclasen(a)redhat.com

--- Comment #2 from Matthias Clasen <mclasen(a)redhat.com&gt; 2012-04-06 15:22:26 EDT
---
Preliminary comments:

%check
desktop-file-validate $RPM_BUILD_ROOT%{_datadir}/applications/glade.desktop

I think this should be part of the regular %install section - do we even run
%check by default on builds ?


%{_datadir}/gnome/help/glade/
%{_datadir}/omf/glade/

If you pass --with-gnome to %find_lang, it should pick these up (and properly
decorate them with %lang)


%files libs
%doc COPYING*

I think it would be nice to ship COPYING in the main package as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 806093] Review Request: glade - User Interface Designer for GTK+ and GNOME

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806093

--- Comment #3 from Kalev Lember <kalevlember(a)gmail.com&gt; 2012-04-06 16:00:34 EDT
---
(In reply to comment #2)
>  %check
>  desktop-file-validate $RPM_BUILD_ROOT%{_datadir}/applications/glade.desktop
>  
>  I think this should be part of the regular %install section - do we even run
>  %check by default on builds ? 
Yes, %check is run by default for all builds, right after %install. I don't
think there's any practical difference whether to put this at the end of
%install or in %check.

https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_...


>  %{_datadir}/gnome/help/glade/
>  %{_datadir}/omf/glade/
>  
>  If you pass --with-gnome to %find_lang, it should pick these up (and properly
>  decorate them with %lang) 
Fixed.


>  %files libs
>  %doc COPYING*
>  
>  I think it would be nice to ship COPYING in the main package as well. 
The licensing guidelines say that it's OK to put the license files in just one
subpackage, provided that all other subpackages depend on the one that has
license files.

But sure, I guess it doesn't hurt to have multiple copies. Added COPYING* to
the main package as well.

https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Subpackage_L...


Spec URL: http://kalev.fedorapeople.org/glade.spec
SRPM URL: http://kalev.fedorapeople.org/glade-3.12.0-2.fc17.src.rpm

* Fri Apr 06 2012 Kalev Lember <kalevlember(a)gmail.com&gt; - 3.12.0-2
- Review fixes (#806093)
- Use find_lang --with-gnome for including help files
- Include license files also in the main package in addition to -libs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 806093] Review Request: glade - User Interface Designer for GTK+ and GNOME

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806093

Rui Matos <tiagomatos(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tiagomatos(a)gmail.com

--- Comment #4 from Rui Matos <tiagomatos(a)gmail.com&gt; 2012-04-12 05:05:50 EDT ---
* The .typelib should go in the -libs package

* This License line is quite confusing:

%package libs
...
License:        GPLv2+ and (GPLv2+ and LGPLv2+) and LGPLv2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 806093] Review Request: glade - User Interface Designer for GTK+ and GNOME

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806093

--- Comment #5 from Kalev Lember <kalevlember(a)gmail.com&gt; 2012-04-12 07:47:33 EDT
---
Thanks, all very good points.

Moved the typelib to -libs and updated the License tag along with the comment:

>  # - /usr/bin/glade is GPLv2+
>  # - /usr/bin/glade-previewer is LGPLv2+
>  # - libgladeui-2.so, libgladegtk.so, and libgladepython.so all combine
>  #   GPLv2+ and LGPLv2+ code, so the resulting binaries are GPLv2+
>  License:        GPLv2+ and LGPLv2+ 

Spec URL: http://kalev.fedorapeople.org/glade.spec
SRPM URL: http://kalev.fedorapeople.org/glade-3.12.0-3.fc17.src.rpm

* Thu Apr 12 2012 Kalev Lember <kalevlember(a)gmail.com&gt; - 3.12.0-3
- Update the spec file comments about licensing and simplify the License tag
- Install the typelib in -libs subpackage

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 806093] Review Request: glade - User Interface Designer for GTK+ and GNOME

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806093

Rui Matos <tiagomatos(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody(a)fedoraproject.org    |tiagomatos(a)gmail.com
               Flag|                            |fedora-review+

--- Comment #6 from Rui Matos <tiagomatos(a)gmail.com&gt; 2012-04-13 08:29:23 EDT ---
Just one more thing which IMO isn't a blocker:

%description    devel
The %{name}-devel package contains libraries and header files for
developing applications that use %{name}.

"applications that use glade" isn't strictly correct. Some (certainly very
far
from the majority) applications might use glade's widgets from the libgladeui-2
library but most won't have any dependency on any of these subpackages here.
So, I think it should say:

The %{name}-devel package contains libraries and header files for
developing applications that use %{name}'s widgets library.

Anyway, this looks APPROVED to me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 806093] Review Request: glade - User Interface Designer for GTK+ and GNOME

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806093

Rui Matos <tiagomatos(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review+              |fedora-review?

--- Comment #7 from Rui Matos <tiagomatos(a)gmail.com&gt; 2012-04-13 09:19:14 EDT ---
Here's a more formal review and it actually caught a problem:

+ OK
! needs attention

rpmlint output:
glade.x86_64: W: obsolete-not-provided glade3
glade.x86_64: E: incorrect-fsf-address /usr/share/doc/glade-3.12.0/COPYING.LGPL
glade.x86_64: E: incorrect-fsf-address /usr/share/doc/glade-3.12.0/COPYING.GPL
glade.x86_64: W: no-manual-page-for-binary glade-previewer
glade.x86_64: W: no-manual-page-for-binary glade
glade-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/glade-3.12.0/gladeui/glade-accumulators.c
glade-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/glade-3.12.0/src/glade-close-button.h
glade-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/glade-3.12.0/src/glade-close-button.c
glade-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/glade-3.12.0/gladeui/glade-clipboard.c
glade-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/glade-3.12.0/plugins/gtk+/glade-fixed.c
glade-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/glade-3.12.0/gladeui/glade-builtins.c
glade-devel.x86_64: W: obsolete-not-provided glade3-libgladeui-devel
glade-libs.x86_64: W: obsolete-not-provided glade3-libgladeui
glade-libs.x86_64: E: incorrect-fsf-address
/usr/share/doc/glade-libs-3.12.0/COPYING.LGPL
glade-libs.x86_64: E: incorrect-fsf-address
/usr/share/doc/glade-libs-3.12.0/COPYING.GPL
5 packages and 0 specfiles checked; 10 errors, 5 warnings.

+ Rpmlint warnings/errors are harmless and can be ignored
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  bc743c2b94b674770b67cbc0c90fb3eb  glade-3.12.0.tar.xz
  bc743c2b94b674770b67cbc0c90fb3eb  glade-3.12.0.tar.xz.upstream
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
+ The spec file handles locales properly
+ ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
+ Package isn't relocatable
+ Package MUST own all the directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
+ Header files should be in -devel
n/a Static libraries should be in -static
+ Library files that end in .so must go in a -devel package
+ -devel must require the fully versioned base
+ Packages should not contain libtool .la files
+ Proper .desktop file handling
! Doesn't own files or directories already owned by other packages

%doc %{_datadir}/gtk-doc/

This is taking ownership of both

/usr/share/gtk-doc
/usr/share/gtk-doc/html

which doesn't look right. Instead the -devel package should require gtk-doc I
believe. Hmmm, and now that I look at it, the build.log says:

 Build Reference Manual:  no

but here it is being installed. Sounds like an upstream bug, but gtk-doc should
be added to the BuildRequires too and maybe explicitly enable gtk-doc in
%configure.

+ Filenames are valid UTF-8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 806093] Review Request: glade - User Interface Designer for GTK+ and GNOME

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806093

--- Comment #8 from Kalev Lember <kalevlember(a)gmail.com&gt; 2012-04-13 09:54:38 EDT
---
Multiple directory ownership is permitted to avoid depending on package which
we wouldn't normally depend on. There's a section in the packaging guidelines
that explains this, and specifically mentions the gtk-doc case:

https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owne...


>  Hmmm, and now that I look at it, the build.log says:
>  
>   Build Reference Manual:  no
>  
>  but here it is being installed. Sounds like an upstream bug, but gtk-doc should
>  be added to the BuildRequires too and maybe explicitly enable gtk-doc in
>  %configure. 
Upstream tarball ships with prebuilt documentation. --enable-gtk-doc is needed
when we have to rebuild the docs, for example when building from git. But in
this case we can use what's in the tarball.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 806093] Review Request: glade - User Interface Designer for GTK+ and GNOME

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806093

Rui Matos <tiagomatos(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #9 from Rui Matos <tiagomatos(a)gmail.com&gt; 2012-04-13 10:26:40 EDT ---
Oh ok, that sounds logical. So it's all good then.

APPROVED again.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 806093] Review Request: glade - User Interface Designer for GTK+ and GNOME

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806093

Kalev Lember <kalevlember(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #10 from Kalev Lember <kalevlember(a)gmail.com&gt; 2012-04-13 10:35:24 EDT
---
Thanks for the review, Rui!

New Package SCM Request
=======================
Package Name: glade
Short Description: User Interface Designer for GTK+ and GNOME
Owners: kalev
Branches: f17
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 806093] Review Request: glade - User Interface Designer for GTK+ and GNOME

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806093

--- Comment #11 from Jon Ciesla <limburgher(a)gmail.com&gt; 2012-04-13 11:07:42 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 806093] Review Request: glade - User Interface Designer for GTK+ and GNOME

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806093

Kalev Lember <kalevlember(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
   Fixed In Version|                            |glade-3.12.0-3.fc17
         Resolution|                            |NEXTRELEASE
        Last Closed|                            |2012-04-13 18:04:29

--- Comment #12 from Kalev Lember <kalevlember(a)gmail.com&gt; 2012-04-13 18:04:29 EDT
---
Package imported and built; closing the ticket.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.