[Bug 1291921] New: Review Request: nodejs-replace-require-self - Require($THIS_PACKAGE) -> require('./') - package-review

List overview All Threads
Download

newer

[Bug 1291921] New: Review Request: nodejs-replace-require-self - Require($THIS_PACKAGE) -> require('./')

older

[Bug 1291934] New: Review Request:...

[Bug 1291920] New: Review Request:...

Red Hat Bugzilla

15 Dec 2015 15 Dec '15

4:09 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1291921

Bug ID: 1291921 Summary: Review Request: nodejs-replace-require-self - Require($THIS_PACKAGE) -> require('./') Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jsmith.fedora@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-replace-require-self/nodejs... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-replace-require-self/nodejs... Description: Require($THIS_PACKAGE) -> require('./') Fedora Account System Username: jsmith

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by thread

Red Hat Bugzilla

15 Dec 15 Dec

4:10 p.m.

New subject: [Bug 1291921] Review Request: nodejs-replace-require-self - Require($THIS_PACKAGE) -> require('./')

https://bugzilla.redhat.com/show_bug.cgi?id=1291921

Jared Smith jsmith.fedora@gmail.com changed:

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1291920 [Bug 1291920] Review Request: nodejs-stream-replace - Replace text in a stream

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:12 p.m.

New subject: [Bug 1291921] Review Request: nodejs-replace-require-self - Require($THIS_PACKAGE) -> require('./')

https://bugzilla.redhat.com/show_bug.cgi?id=1291921

--- Comment #1 from Jared Smith jsmith.fedora@gmail.com --- Updated packaging:

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-replace-require-self/nodejs... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-replace-require-self/nodejs...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

16 Dec 16 Dec

7:49 a.m.

New subject: [Bug 1291921] Review Request: nodejs-replace-require-self - Require($THIS_PACKAGE) -> require('./')

https://bugzilla.redhat.com/show_bug.cgi?id=1291921

--- Comment #2 from Jared Smith jsmith.fedora@gmail.com --- New upstream version, complete with LICENSE file.

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-replace-require-self/nodejs... SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-replace-require-self/nodejs...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:58 p.m.

New subject: [Bug 1291921] Review Request: nodejs-replace-require-self - Require($THIS_PACKAGE) -> require('./')

https://bugzilla.redhat.com/show_bug.cgi?id=1291921

--- Comment #3 from Jared Smith jsmith.fedora@gmail.com --- The required package nodejs-stream-replace is now in rawhide, so I think this package review can move forward now.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

20 Dec 20 Dec

10:52 a.m.

New subject: [Bug 1291921] Review Request: nodejs-replace-require-self - Require($THIS_PACKAGE) -> require('./')

https://bugzilla.redhat.com/show_bug.cgi?id=1291921

Piotr Popieluch piotr1212@gmail.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:04 a.m.

New subject: [Bug 1291921] Review Request: nodejs-replace-require-self - Require($THIS_PACKAGE) -> require('./')

https://bugzilla.redhat.com/show_bug.cgi?id=1291921

Piotr Popieluch piotr1212@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #4 from Piotr Popieluch piotr1212@gmail.com --- All ok, APPROVED

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/piotr/rpmbuild/1291921-nodejs-replace-require- self/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: nodejs-replace-require-self-1.0.1-1.fc24.noarch.rpm nodejs-replace-require-self-1.0.1-1.fc24.src.rpm nodejs-replace-require-self.noarch: W: only-non-binary-in-usr-lib nodejs-replace-require-self.noarch: W: no-documentation nodejs-replace-require-self.noarch: W: dangling-symlink /usr/lib/node_modules/replace-require-self/node_modules/stream-replace /usr/lib/node_modules/stream-replace nodejs-replace-require-self.noarch: W: no-manual-page-for-binary replace-require-self 2 packages and 0 specfiles checked; 0 errors, 4 warnings.

Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory nodejs-replace-require-self.noarch: W: only-non-binary-in-usr-lib nodejs-replace-require-self.noarch: W: no-documentation nodejs-replace-require-self.noarch: W: dangling-symlink /usr/lib/node_modules/replace-require-self/node_modules/stream-replace /usr/lib/node_modules/stream-replace nodejs-replace-require-self.noarch: W: no-manual-page-for-binary replace-require-self 1 packages and 0 specfiles checked; 0 errors, 4 warnings.

Requires -------- nodejs-replace-require-self (rpmlib, GLIBC filtered): /usr/bin/env nodejs nodejs(engine) npm(stream-replace)

Provides -------- nodejs-replace-require-self: nodejs-replace-require-self npm(replace-require-self)

Source checksums ---------------- https://registry.npmjs.org/replace-require-self/-/replace-require-self-1.0.1... : CHECKSUM(SHA256) this package : 4a5ed0d609e9d64fcd4909f187fba6faf8e80c5e0d2dfc842d62b438a650eae7 CHECKSUM(SHA256) upstream package : 4a5ed0d609e9d64fcd4909f187fba6faf8e80c5e0d2dfc842d62b438a650eae7

Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -x CheckOwnDirs -b 1291921 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

21 Dec 21 Dec

2:21 p.m.

New subject: [Bug 1291921] Review Request: nodejs-replace-require-self - Require($THIS_PACKAGE) -> require('./')

https://bugzilla.redhat.com/show_bug.cgi?id=1291921

--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/nodejs-replace-require-self

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

27 May 27 May

3:29 p.m.

New subject: [Bug 1291921] Review Request: nodejs-replace-require-self - Require( $THIS_PACKAGE) -> require('./')

https://bugzilla.redhat.com/show_bug.cgi?id=1291921

Piotr Popieluch piotr1212@gmail.com changed:

--- Comment #6 from Piotr Popieluch piotr1212@gmail.com --- in f24 and rawhide, closing

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4 Aug 4 Aug

5:47 a.m.

New subject: [Bug 1291921] Review Request: nodejs-replace-require-self - Require( $THIS_PACKAGE) -> require('./')

https://bugzilla.redhat.com/show_bug.cgi?id=1291921 Bug 1291921 depends on bug 1291920, which changed state.

Bug 1291920 Summary: Review Request: nodejs-stream-replace - Replace text in a stream https://bugzilla.redhat.com/show_bug.cgi?id=1291920

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3275

Age (days ago)

3508

Last active (days ago)

package-review@lists.fedoraproject.org

9 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla