[Bug 191667] New: Review Request: poker-engine - Python library that implements poker rules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191667
Summary: Review Request: poker-engine - Python library that implements poker rules Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: chris.stone@gmail.com QAContact: fedora-package-review@redhat.com
Spec URL: http://tkmame.retrogames.com/fedora-extras/poker-engine.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/poker-engine-1.0.14-2.src.rpm
*** NOTE *** You may have to download the src.rpm from http://tkmame.retrogames.com/fedora-extras/
Description:
This is a python library that implements poker rules according to variants and betting structures specified in configuration files. It designed to be used by a multiplayer poker server, a poker AI or a poker client.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: poker-engine - Python library that implements poker rules
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191667
------- Additional Comments From chris.stone@gmail.com 2006-05-15 20:23 EST ------- Spec URL: http://tkmame.retrogames.com/fedora-extras/poker-engine.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/poker-engine-1.0.14-3.src.rpm
*** NOTE *** You may have to download the src.rpm from http://tkmame.retrogames.com/fedora-extras/
%changelog * Mon May 15 2006 Christopher Stone chris.stone@gmail.com - 1.0.14-3 - Add Requires pypoker-eval-devel to devel package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: poker-engine - Python library that implements poker rules
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191667
wart@kobold.org changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bugzilla-sink@leemhuis.info |wart@kobold.org OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: poker-engine - Python library that implements poker rules
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191667
------- Additional Comments From wart@kobold.org 2006-05-26 16:11 EST ------- MUST ==== * rpmlint output: W: poker-engine-devel no-documentation This can be ignored since upstream doesn't provide developer documentation * Package and spec named appropriately * GPL license ok, license file included * Source matches upstream 23186d64a0ca1bcd22341355d6debc56 poker-engine-1.0.14.tar.gz * Spec file legible and in Am. English * No excessive BR: (though BR: rsync looks silly) * No Locales * No shared libs, headers, or libtool archives * pkgconfig file in -devel apckage * Not relocatable * No .desktop file needed * %{buildroot} cleaned where it ought to be * No duplicate %files * Builds in mock on FC4, FC5, and devel
SHOULD ====== * Patch the configure script instead of running autoreconf in %prep
QUESTIONS ========= * What's the difference between the xml files in /usr/share and /etc?
MUSTFIX ======= * Missing Requires: rsync (for pokerconfigupgrade)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: poker-engine - Python library that implements poker rules
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191667
------- Additional Comments From chris.stone@gmail.com 2006-05-30 16:03 EST ------- Spec URL: http://tkmame.retrogames.com/fedora-extras/poker-engine.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/poker-engine-1.0.15-1.src.rpm
%changelog * Tue May 30 2006 Christopher Stone chris.stone@gmail.com - 1.0.15-1 - Upstream sync - Add rsync to Requires - Remove patches and autoreconf since these have been fixed in new release
I've updated this to the 1.0.15 release which no longer requires the patches to be installed and no longer requires the autoreconf. I also added rsync to the Requires. Thanks for the review!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: poker-engine - Python library that implements poker rules
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191667
------- Additional Comments From chris.stone@gmail.com 2006-05-30 16:05 EST ------- Oh, and the xml files in /usr/share are supposed to be "reference" files while the ones in /etc are editable.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: poker-engine - Python library that implements poker rules
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191667
wart@kobold.org changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From wart@kobold.org 2006-05-30 19:13 EST ------- * Source still matches upstream. new md5sum: 5b51616881d0ee10354b0f5f573a52d1 poker-engine-1.0.15.tar.gz * rpmlint output unchanged from before * Still builds in mock on FC4, FC5 (devel not retested)
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: poker-engine - Python library that implements poker rules
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191667
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla