https://bugzilla.redhat.com/show_bug.cgi?id=2156080
Bug ID: 2156080 Summary: Review Request: python-qcustomplot-pyqt - QCustomPlot PyQt binding Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ti.eugene@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://tieugene.fedorapeople.org/rpms/python-qcustomplot-pyqt/python-qcusto... SRPM URL: https://tieugene.fedorapeople.org/rpms/python-qcustomplot-pyqt/python-qcusto... Description: This is Python bindings for QCustomPlot - Qt C++ library for plotting and data visualization. Fedora Account System Username: tieugene
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=95626276
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org CC| |benson_muite@emailplus.org Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
--- Comment #1 from Benson Muite benson_muite@emailplus.org --- Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated", "*No copyright* MIT License", "GNU General Public License, Version 3", "GNU General Public License v3.0 or later", "*No copyright* [generated file]". 20 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/python-qcustomplot-pyqt/2156080-python- qcustomplot-pyqt/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-qcustomplot-pyqt5 , python3-qcustomplot-pyqt6 [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-qcustomplot-pyqt5-2.1.1.1-1.fc37.x86_64.rpm python3-qcustomplot-pyqt6-2.1.1.1-1.fc37.x86_64.rpm python-qcustomplot-pyqt-2.1.1.1-1.fc37.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp5g0cf6u9')] checks: 31, packages: 3
3 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 12.4 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2
2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 3.2 s
Unversioned so-files -------------------- python3-qcustomplot-pyqt5: /usr/lib64/python3.11/site-packages/QCustomPlot_PyQt5.cpython-311-x86_64-linux-gnu.so python3-qcustomplot-pyqt6: /usr/lib64/python3.11/site-packages/QCustomPlot_PyQt6.cpython-311-x86_64-linux-gnu.so
Source checksums ---------------- https://github.com/salsergey/QCustomPlot-PyQt/releases/download/v2.1.1.1/QCu... : CHECKSUM(SHA256) this package : 689f7809a207d710c003db4bafc45ea57b90e6ad99797ee40050371db8a3a525 CHECKSUM(SHA256) upstream package : 689f7809a207d710c003db4bafc45ea57b90e6ad99797ee40050371db8a3a525
Requires -------- python3-qcustomplot-pyqt5 (rpmlib, GLIBC filtered): (python3.11dist(pyqt5-sip) < 13~~ with python3.11dist(pyqt5-sip) >= 12) libGL.so.1()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libqcustomplot-qt5.so.2()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) python(abi) python3-qt5 python3.11dist(pyqt5) qcustomplot-qt5 rtld(GNU_HASH)
python3-qcustomplot-pyqt6 (rpmlib, GLIBC filtered): (python3.11dist(pyqt6-sip) < 14~~ with python3.11dist(pyqt6-sip) >= 13) libGLX.so.0()(64bit) libOpenGL.so.0()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.4)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6PrintSupport.so.6()(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libqcustomplot-qt6.so.2()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) python(abi) python3-pyqt6 python3.11dist(pyqt6) qcustomplot-qt6 rtld(GNU_HASH)
Provides -------- python3-qcustomplot-pyqt5: python-qcustomplot-pyqt5 python3-qcustomplot-pyqt5 python3-qcustomplot-pyqt5(x86-64) python3.11-qcustomplot-pyqt5 python3.11dist(qcustomplot-pyqt5) python3dist(qcustomplot-pyqt5)
python3-qcustomplot-pyqt6: python-qcustomplot-pyqt6 python3-qcustomplot-pyqt6 python3-qcustomplot-pyqt6(x86-64) python3.11-qcustomplot-pyqt6 python3.11dist(qcustomplot-pyqt6) python3dist(qcustomplot-pyqt6)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -m fedora-37-x86_64 -b 2156080 Buildroot used: fedora-37-x86_64 Active plugins: Generic, C/C++, Python, Shell-api Disabled plugins: Java, Ruby, Ocaml, R, Haskell, PHP, SugarActivity, fonts, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comments: a) Consider packaging examples in the documentation b) Some files seem to be under GPL: GNU General Public License v3.0 or later ---------------------------------------- QCustomPlot_PyQt5-2.1.1.1/src/qcustomplot.cpp QCustomPlot_PyQt5-2.1.1.1/src/qcustomplot.h
GNU General Public License, Version 3 ------------------------------------- QCustomPlot_PyQt5-2.1.1.1/README.md QCustomPlot_PyQt5-2.1.1.1/sip/qpycore_qvector.sip
The first two files qcustomplot.cpp and qcustomplot.h are amalgamations of qcustomplot source code. Is it possible to remove these and build using what is packaged in Fedora, rather than use them to build the bindings and then remove them?
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
--- Comment #2 from Eugene A. Pivnev ti.eugene@gmail.com ---
BuildRequires against gcc, gcc-c++ or clang
Fixed
GNU General Public License, Version 3
Fixed
remove them?
Fixed PS. Naturally it use system QCP and not bundled (option `--no-static-qcustomplot`), but to insure this I kill the QCP sources.
SPEC: https://tieugene.fedorapeople.org/rpms/python-qcustomplot-pyqt/python-qcusto... SRPM: https://tieugene.fedorapeople.org/rpms/python-qcustomplot-pyqt/python-qcusto... Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=95687097
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Benson Muite benson_muite@emailplus.org --- Thanks. It works. The installed libraries have permissions -rw-r--r-- and should likely have permissions -rwxr-xr-x , perhaps update this when importing. For my information, why strip the libraries?
Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
--- Comment #4 from Eugene A. Pivnev ti.eugene@gmail.com --- (In reply to Benson Muite from comment #3)
For my information, why strip the libraries?
Debug package cannot be created (I don't know why, something about 'cannot find debuginfo.lst'). From other side debug info is in libraries and 'review' produces warnings about this.
Thank you.
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review? Status|POST |ASSIGNED
--- Comment #5 from Benson Muite benson_muite@emailplus.org --- Checking this. Sip does seem to allow for some debug information, in particular adding --debug and --tracing flags: https://www.riverbankcomputing.com/static/Docs/sip/command_line_tools.html#s... however, this does not solve the problem.
Tried following spec at: https://src.fedoraproject.org/rpms/pyqtwebengine/blob/rawhide/f/pyqtwebengin...
It seems changing permissions on the generated libraries enables creation of debuginfo.
Using the above as a basis, it seems to build and produce debuginfo packages, see: https://copr.fedorainfracloud.org/coprs/fed500/python-qcustomplot-pyqt/build...
There does not appear to be api information: https://download.copr.fedorainfracloud.org/results/fed500/python-qcustomplot... so the corresponding lines in the spec file need not be added: https://download.copr.fedorainfracloud.org/results/fed500/python-qcustomplot...
Possibly improvements could be made to: https://build.opensuse.org/package/view_file/home:sergeyopensuse:gpxviewer/p... to also produce debuginfo packages?
Note that not all the examples work unmodified for Qt6
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
--- Comment #6 from Eugene A. Pivnev ti.eugene@gmail.com --- SPEC: https://tieugene.fedorapeople.org/rpms/python-qcustomplot-pyqt/python-qcusto... SRPM: https://tieugene.fedorapeople.org/rpms/python-qcustomplot-pyqt/python-qcusto... Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=95777397
Notes: 1. This works (need both of them), thank you: `--no-make --qmake-setting ...` 2. [only] exec permission does not matter for producing debug packages 3. *.api produced but are empty (0 bytes) so I not enabled them 4. 'Original' spec at OBS not helps because debug packages disabled in repo (as the author say, he has same problem with debug packages) 5. Some examples are craching now so I not packaged 'examples/' until additional investigations
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
--- Comment #7 from Benson Muite benson_muite@emailplus.org --- In the spec file can you indicate that QCustomPlot_PyQt5-2.1.1.1/sip/qpycore_qvector.sip is under GPLv3, all other files are under MIT. That file is used in: https://github.com/salsergey/QCustomPlot-PyQt/blob/master/sip/all_PyQt6.sip#...
The examples worked for me with Qt5, but many had problems with Qt6. Perhaps raise an issue upstream with information on examples that fail.
Perhaps put the examples as documentation for python3-qcustomplot-pyqt5 adding %doc examples under files for python3-qcustomplot-pyqt5 should be sufficient.
At present would suggest only providing python3-qcustomplot-pyqt5 do to the many examples not working for python3-qcustomplot-pyqt5, which may give a bad user experience but it is upto you.
For the python3-qcustomplot-pyqt5 package, only the MIT license needs to be listed.
For the python3-qcustomplot-pyqt6 package, if it will be provided both the MIT and GPLv3 licenses needs to be listed.
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
--- Comment #9 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5201922 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-215...
Please make sure the package builds successfully at least for Fedora Rawhide.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
--- Comment #10 from Mamoru TASAKA mtasaka@fedoraproject.org --- (In reply to Jakub Kadlčík from comment #9)
Copr build: https://copr.fedorainfracloud.org/coprs/build/5201922 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review- 2156080-python-qcustomplot-pyqt/srpm-builds/05201922/builder-live.log.gz
Please make sure the package builds successfully at least for Fedora Rawhide.
And did you actually check the above log?
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@redhat.com Flags| |needinfo?(jkadlcik@redhat.c | |om)
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
--- Comment #11 from Eugene A. Pivnev ti.eugene@gmail.com --- (In reply to Jakub Kadlčík from comment #9)
Copr build: https://copr.fedorainfracloud.org/coprs/build/5201922 (failed)
Seems Fedora infrastructure has some problems right now. E.g. I cannot view my own https://tieugene.fedorapeople.org/ (but can use it via ssh). As for rawhide build: https://koji.fedoraproject.org/koji/taskinfo?taskID=95780461
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jkadlcik@redhat.c | |om) |
--- Comment #12 from Jakub Kadlčík jkadlcik@redhat.com ---
And did you actually check the above log?
I am sorry, it looks like a temporary issue. I tried to resubmit the build and it works now. Please ignore the failure.
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #14 from Benson Muite benson_muite@emailplus.org --- Sorry for the earlier confusion. Thanks for raising https://github.com/salsergey/QCustomPlot-PyQt/issues/7 If using the current release, can you add the GPLv3 text to the package on import? In the spec file, please also indicate the file using GPLv3 and that all other files are under MIT.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
Thanks for your patience and adding this package to Fedora. Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
--- Comment #16 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-qcustomplot-pyqt
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-aafc28c0e6 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-aafc28c0e6
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-aafc28c0e6 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-aafc28c0e6 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-aafc28c0e6
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2156080
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2023-01-21 03:31:14
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-aafc28c0e6 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com