[Bug 196601] New: Review Request: vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196601

Summary: Review Request: vobject -  A python library for
                    manipulating vCard and vCalendar files
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://www.dangerouslyinc.com/~bowes/fe/vobject.spec
SRPM URL: http://www.dangerouslyinc.com/~bowes/fe/vobject-0.3.0-1.src.rpm
Description: VObject is intended to be a full featured python library for parsing and generating vCard and vCalendar files.

[Bug 196601] Review Request: vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vobject -  A python library for manipulating vCard and vCalendar files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2006-06-25 23:18 EST -------
Not an official review as I'm not yet sponsored
Mock build for development i386 is suceesfull with some warnings
+ /usr/bin/python setup.py build
/usr/lib/python2.4/distutils/dist.py:236: UserWarning: Unknown distribution
option: 'zip_safe'
  warnings.warn(msg)
/usr/lib/python2.4/distutils/dist.py:236: UserWarning: Unknown distribution
option: 'install_requires'
  warnings.warn(msg)

MUST Items:
     - MUST: rpmlint shows no error on i386
     - MUST: dist tag is present
     - MUST: The package is named according to the Package Naming Guidelines.
     - MUST: The spec file name matching the base package vobject, in the
format vobject.spec
      - MUST: This package meets the Packaging Guidelines.
      - MUST: The package is licensed with an open-source compatible license
Apache Software License.
      - MUST: The License field in the package vobject.spec file did not match
any file in tarball.
      - MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct.
      - MUST: This package owns all directories that it creates. 
      - MUST: This package did not contain any duplicate files in the %files
listing.
      - MUST: This package  have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
      - MUST: This package used macros.
      - MUST: Document files are included like README.txt

* Source URL is present and working.
      * BuildRoot is correct BuildRoot:       
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
      * BuildRequires is correct

What you Need:-
      * You dont need to have 
Requires:       python-abi = %(%{__python} -c "import sys ; print sys.version[:3]")
       as this is only for rpms targetting for FC3 or prior.
       * Add License file in tarball if you can alter the tarball contents.

[Bug 196601] Review Request: vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vobject -  A python library for manipulating vCard and vCalendar files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2006-06-26 10:11 EST -------
The package should probably be named python-vobject as well.

[Bug 196601] Review Request: vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: vobject -  A python library for manipulating vCard and vCalendar files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196601

------- Additional Comments From [e-mail]  2006-06-26 13:22 EST -------
Updated locations:
Spec URL: http://www.dangerouslyinc.com/~bowes/fe/python-vobject.spec
SRPM URL: http://www.dangerouslyinc.com/~bowes/fe/python-vobject-0.3.0-1.src.rpm

Thanks for the feedback, guys!

I've:
* Renamed the package to python-vobject
* Removed the python-abi requires
* Removed the unused python-sitearch macro
* Removed some comments left over from the template

I didn't add in the license file, since the released version does not package it
in the tarball. However, the current sources in svn do have a LICENSE file, so
it should be in the next release.

[Bug 196601] Review Request: python-vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-vobject -  A python library for manipulating vCard and vCalendar files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: vobject -  A|Review Request: python-
                   |python library for          |vobject -  A python library
                   |manipulating vCard and      |for manipulating vCard and
                   |vCalendar files             |vCalendar files

[Bug 196601] Review Request: python-vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-vobject -  A python library for manipulating vCard and vCalendar files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail] |[e-mail]
OtherBugsDependingO|163776                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-06-26 23:25 EST -------
APPROVED, based upon the review by Parag AN and the updated package.  For
furture reference, please bump the release each time you update the package.

[Bug 196601] Review Request: python-vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-vobject -  A python library for manipulating vCard and vCalendar files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2006-06-28 09:37 EST -------
Thanks for your help, everyone!

[Bug 196601] Review Request: python-vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-vobject -  A python library for manipulating vCard and vCalendar files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-05-18 11:29 EST -------
Package Change Request
======================
Package Name: python-vobject
Updated Fedora Owners: [e-mail], [e-mail]

[Bug 196601] Review Request: python-vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-vobject -  A python library for manipulating vCard and vCalendar files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196601

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-05-20 08:30 EST -------
done

[Bug 196601] Review Request: python-vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=196601

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #8 from Dan Horák  2011-05-24 04:20:13 EDT ---
Package Change Request
======================
Package Name: python-vobject
New Branches: el6
Owners: sharkcz

[Bug 196601] Review Request: python-vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=196601

--- Comment #9 from Jason Tibbitts  2011-05-24 10:43:04 EDT ---
Need an ack here from the Fedora owners.

[Bug 196601] Review Request: python-vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=196601

--- Comment #10 from Dan Horák  2011-05-24 10:57:46 EDT ---
Hm, I got no response on email sent 2 weeks ago ... Let's wait a bit if James
shows here.

[Bug 196601] Review Request: python-vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=196601

--- Comment #11 from Jens Petersen  2011-05-31 02:56:32 EDT ---
Can you please set fedora-cvs flag again when you are ready?

[Bug 196601] Review Request: python-vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=196601

--- Comment #12 from James Bowes  2011-06-06 09:43:06 EDT ---
ACK. sorry.

[Bug 196601] Review Request: python-vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=196601

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 196601] Review Request: python-vobject - A python library for manipulating vCard and vCalendar files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=196601

--- Comment #13 from Jon Ciesla  2011-06-06 11:45:32 EDT ---
Git done (by process-git-requests).