[Bug 1555402] New: Review Request: golang-github-nsf-termbox - A minimalistic API which allows programmers to write text-based user interfaces
10:44 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1555402
Bug ID: 1555402
Summary: Review Request: golang-github-nsf-termbox - A
minimalistic API which allows programmers to write
text-based user interfaces
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: zebob.m(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/c6b1cca/golang-githu...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-ra...
Description: A minimalistic API which allows programmers to write text-based
user interfaces
Fedora Account System Username: eclipseo
This is a rename of golang-github-nsf-termbox-go. Please note that this uses
the new More Go Packaging guidelines:
https://fedoraproject.org/wiki/More_Go_packaging , which standardizes package
name via %goname, hence the rename.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:49 p.m.
New subject: [Bug 1555402] Review Request:
golang-github-nsf-termbox - A minimalistic API which allows programmers to
write text-based user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1555402
--- Comment #1 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/8cfad44/golang-githu...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/rclone/fedora-ra...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:45 p.m.
New subject: [Bug 1555402] Review Request:
golang-github-nsf-termbox - A minimalistic API which allows programmers to
write text-based user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1555402
Jared Smith <jsmith.fedora(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |jsmith.fedora(a)gmail.com
Assignee|nobody(a)fedoraproject.org |jsmith.fedora(a)gmail.com
Flags| |fedora-review?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:47 p.m.
New subject: [Bug 1555402] Review Request:
golang-github-nsf-termbox - A minimalistic API which allows programmers to
write text-based user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1555402
Jared Smith <jsmith.fedora(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
Flags|fedora-review? |fedora-review+
--- Comment #2 from Jared Smith <jsmith.fedora(a)gmail.com> ---
Package is APPROVED.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 29 files
have
unknown license. Detailed output of licensecheck in
/home/jsmith/Documents/Fedora/Reviews/1555402-golang-github-nsf-
termbox/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/gocode/src/github.com/nsf(golang-github-nsf-termbox-go-
devel), /usr/share/gocode/src/github.com/nsf/termbox-go(golang-github-
nsf-termbox-go-devel), /usr/share/gocode/src/github.com/nsf/termbox-
go/_demos(golang-github-nsf-termbox-go-devel),
/usr/share/gocode/src/github.com(golang-github-zyedidia-pty-devel,
golang-github-jlaffaye-ftp-devel, golang-github-nwidger-jsoncolor-
devel, golang-github-coreos-bbolt-devel, golang, golang-github-chzyer-
logex-devel, golang-github-AdRoll-goamz-devel, golang-googlecode-
goprotobuf-devel, golang-github-yuin-gopher-lua-devel, golang-github-
zyedidia-clipboard-devel, golang-github-spf13-pflag-devel, golang-
github-grpc-ecosystem-grpc-gateway-devel, etcd-devel, golang-github-
rfjakob-eme-devel, golang-github-Sirupsen-logrus-devel, golang-github-
spf13-cobra-devel, golang-github-billziss-gh-cgofuse-devel, golang-
github-mattn-go-runewidth-devel, golang-github-kdar-factorlog-devel,
golang-github-gogo-protobuf-devel, golang-github-robertkrimen-otto-
devel, golang-github-zyedidia-poller-devel, golang-github-zyedidia-
glob-devel, golang-github-zyedidia-tcell-devel, golang-github-xanzy-
ssh-agent-devel, golang-github-zyedidia-terminal-devel, golang-github-
flynn-json5-devel, golang-github-chzyer-test-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking:
golang-github-nsf-termbox-devel-0-0.3.20180314gite2050e4.fc28.noarch.rpm
golang-github-nsf-termbox-0-0.3.20180314gite2050e4.fc28.src.rpm
golang-github-nsf-termbox-devel.noarch: W: spelling-error Summary(en_US)
minimalistic -> minimalist, minimalism, animistic
golang-github-nsf-termbox-devel.noarch: W: spelling-error %description -l en_US
minimalistic -> minimalist, minimalism, animistic
golang-github-nsf-termbox-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/nsf/termbox-go/.goipath
golang-github-nsf-termbox-devel.noarch: E: zero-length
/usr/share/gocode/src/github.com/nsf/termbox-go/.goipath
golang-github-nsf-termbox.src: W: spelling-error Summary(en_US) minimalistic ->
minimalist, minimalism, animistic
golang-github-nsf-termbox.src: W: spelling-error %description -l en_US
minimalistic -> minimalist, minimalism, animistic
golang-github-nsf-termbox.src: W: no-%build-section
2 packages and 0 specfiles checked; 1 errors, 6 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
golang-github-nsf-termbox-devel.noarch: W: spelling-error Summary(en_US)
minimalistic -> minimalist, minimalism, animistic
golang-github-nsf-termbox-devel.noarch: W: spelling-error %description -l en_US
minimalistic -> minimalist, minimalism, animistic
golang-github-nsf-termbox-devel.noarch: W: invalid-url URL:
https://github.com/nsf/termbox-go <urlopen error [Errno -2] Name or service not
known>
golang-github-nsf-termbox-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/nsf/termbox-go/.goipath
golang-github-nsf-termbox-devel.noarch: E: zero-length
/usr/share/gocode/src/github.com/nsf/termbox-go/.goipath
1 packages and 0 specfiles checked; 1 errors, 4 warnings.
Requires
--------
golang-github-nsf-termbox-devel (rpmlib, GLIBC filtered):
golang(github.com/mattn/go-runewidth)
Provides
--------
golang-github-nsf-termbox-devel:
golang(github.com/nsf/termbox-go)
golang(github.com/nsf/termbox-go)(commit=e2050e41c8847748ec5288741c0b19a8...
golang-github-nsf-termbox-devel
golang-github-nsf-termbox-go-devel
Source checksums
----------------
https://github.com/nsf/termbox-go/archive/e2050e41c8847748ec5288741c0b19a...
:
CHECKSUM(SHA256) this package :
3cb113ceb2197f26905b2fc37f5c441927c00140ee537992cc39738c80d347ec
CHECKSUM(SHA256) upstream package :
3cb113ceb2197f26905b2fc37f5c441927c00140ee537992cc39738c80d347ec
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1555402
Buildroot used: fedora-28-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:27 p.m.
New subject: [Bug 1555402] Review Request:
golang-github-nsf-termbox - A minimalistic API which allows programmers to
write text-based user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1555402
--- Comment #3 from Gwyn Ciesla <limburgher(a)gmail.com> ---
(fedrepo-req-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-nsf-termbox
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:57 a.m.
New subject: [Bug 1555402] Review Request:
golang-github-nsf-termbox - A minimalistic API which allows programmers to
write text-based user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1555402
--- Comment #4 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-nsf-termbox-0-0.3.20180317gite2050e4.fc28 has been submitted as
an update to Fedora 28.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-e91161e236
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:57 a.m.
New subject: [Bug 1555402] Review Request:
golang-github-nsf-termbox - A minimalistic API which allows programmers to
write text-based user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1555402
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |MODIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:29 p.m.
New subject: [Bug 1555402] Review Request:
golang-github-nsf-termbox - A minimalistic API which allows programmers to
write text-based user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1555402
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |ON_QA
--- Comment #5 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-nsf-termbox-0-0.3.20180317gite2050e4.fc28 has been pushed to the
Fedora 28 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-e91161e236
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:22 p.m.
New subject: [Bug 1555402] Review Request:
golang-github-nsf-termbox - A minimalistic API which allows programmers to
write text-based user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1555402
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed| |2018-05-19 17:22:30
--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-nsf-termbox-0-0.3.20180317gite2050e4.fc28 has been pushed to the
Fedora 28 stable repository. If problems still persist, please make note of it
in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:46 a.m.
New subject: [Bug 1555402] Review Request:
golang-github-nsf-termbox - A minimalistic API which allows programmers to
write text-based user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1555402
--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-nsf-termbox-0-0.3.20180317gite2050e4.fc27 has been submitted as
an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-19e86f0620
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:36 p.m.
New subject: [Bug 1555402] Review Request:
golang-github-nsf-termbox - A minimalistic API which allows programmers to
write text-based user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1555402
--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-nsf-termbox-0-0.3.20180317gite2050e4.fc27 has been pushed to the
Fedora 27 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-19e86f0620
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:15 p.m.
New subject: [Bug 1555402] Review Request:
golang-github-nsf-termbox - A minimalistic API which allows programmers to
write text-based user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1555402
--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org> ---
golang-github-nsf-termbox-0-0.3.20180317gite2050e4.fc27 has been pushed to the
Fedora 27 stable repository. If problems still persist, please make note of it
in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2179
days inactive
2271
days old
package-review@lists.fedoraproject.org
11 comments
1 participants
participants (1)
-
bugzilla＠redhat.com