[Bug 2255654] New: Review Request: golang-github-1player-host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

Bug ID: 2255654
           Summary: Review Request: golang-github-1player-host-spawn - Run
                    commands on your host from inside your toolbox or
                    flatpak sandbox
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL:
https://yselkowitz.fedorapeople.org/golang-github-1player-host-spawn.spec
SRPM URL:
https://yselkowitz.fedorapeople.org/golang-github-1player-host-spawn-1.5.1-1...
Description: Run commands on your host from inside your toolbox or flatpak
sandbox. (Needed for qmlkonsole flatpak.)
Fedora Account System Username: yselkowitz

[Bug 2255654] Review Request: golang-github-1player-host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6784938
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2255654] Review Request: golang-github-1player-host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

Pavel Solovev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Pavel Solovev  ---
If you only need the binary (not the library) you can regenerate with go2rpm
github.com/1player/host-spawn --name host-spawn, remove %gopkg, %gopkginstall
and %gopkgfiles.
> %{_bindir}/*

%{_bindir}/host-spawn

[Bug 2255654] Review Request: host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

Yaakov Selkowitz  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request: host-spawn
                   |golang-github-1player-host- |- Run commands on your host
                   |spawn - Run commands on     |from inside your toolbox or
                   |your host from inside your  |flatpak sandbox
                   |toolbox or flatpak sandbox  |

[Bug 2255654] Review Request: host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

--- Comment #3 from Yaakov Selkowitz  ---
Spec URL: https://yselkowitz.fedorapeople.org/host-spawn.spec
SRPM URL: https://yselkowitz.fedorapeople.org/host-spawn-1.5.1-1.fc40.src.rpm
Description: Run commands on your host from inside your toolbox or flatpak
sandbox. (Needed for qmlkonsole flatpak.)
Fedora Account System Username: yselkowitz

[Bug 2255654] Review Request: host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |AutomationTriaged

--- Comment #4 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6873490
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2255654] Review Request: host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

Pavel Solovev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
             Status|NEW                         |POST
           Assignee|[e-mail]    |[e-mail]

--- Comment #5 from Pavel Solovev  ---
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

- [x] The specfile is sane.
- [x] The latest version is packaged or packaging an earlier version is
justified.
- [x] The License tag reflects the package contents and uses the correct
identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [-] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the
distribution. (Some Go projects include utility binaries with very generic
names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these
by default)
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the
Bodhi ticket.

Thanks!

[Bug 2255654] Review Request: host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

--- Comment #6 from Pavel Solovev  ---
- [x] The package's binaries don't conflict with binaries already in the
distribution. (Some Go projects include utility binaries with very generic
names)
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these
by default)
Just want to sleep :)

Could you please review https://bugzilla.redhat.com/show_bug.cgi?id=2256995 ?

[Bug 2255654] Review Request: host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

--- Comment #7 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/host-spawn

[Bug 2255654] Review Request: host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #8 from Fedora Update System  ---
FEDORA-2024-8cd1379ee3 has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-8cd1379ee3

[Bug 2255654] Review Request: host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

--- Comment #9 from Fedora Update System  ---
FEDORA-2024-3b94820c3b has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3b94820c3b

[Bug 2255654] Review Request: host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #10 from Fedora Update System  ---
FEDORA-2024-8cd1379ee3 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2024-8cd1379ee3 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-8cd1379ee3

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2255654] Review Request: host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

--- Comment #11 from Fedora Update System  ---
FEDORA-2024-3b94820c3b has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2024-3b94820c3b *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-3b94820c3b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2255654] Review Request: host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2024-01-17 01:05:22

--- Comment #12 from Fedora Update System  ---
FEDORA-2024-8cd1379ee3 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2255654] Review Request: host-spawn - Run commands on your host from inside your toolbox or flatpak sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=2255654

--- Comment #13 from Fedora Update System  ---
FEDORA-2024-3b94820c3b has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.