https://bugzilla.redhat.com/show_bug.cgi?id=1014344
Bug ID: 1014344 Summary: Review Request: gallery3-openid - OpenID support for Gallery3 Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: puiterwijk@gmail.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
Spec URL: http://puiterwijk.fedorapeople.org//gallery3-openid.spec SRPM URL: http://puiterwijk.fedorapeople.org//gallery3-openid-2.0-0.1.beta.fc19.src.rp...
Description: Adds OpenID authentication support to Gallery3
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
--- Comment #1 from Patrick Uiterwijk puiterwijk@gmail.com --- Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6012971
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
Ian Weller ian@ianweller.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ian@ianweller.org Assignee|nobody@fedoraproject.org |ian@ianweller.org Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
--- Comment #2 from Patrick Uiterwijk puiterwijk@gmail.com --- I will decouple the embedded libraries.
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
--- Comment #3 from Ian Weller ian@ianweller.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "BSD (2 clause)", "GPL (v2 or later)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/ianweller/REVIEW/1014344-gallery3-openid/licensecheck.txt
Will evaluate after LightOpenID and openid-selector are unbundled
[!]: Package contains no bundled libraries without FPC exception.
LightOpenID, openid-selector
[x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment).
The non-executable-script errors are actually part of openid-selector which you told me is being split out in IRC
[x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures.
(noarch)
[-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files.
I do not believe cp -R is sufficient for preserving timestamps, I believe you need to add -p
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: gallery3-openid-2.0-0.1.beta.fc18.noarch.rpm gallery3-openid-2.0-0.1.beta.fc18.src.rpm gallery3-openid.noarch: W: no-documentation gallery3-openid.noarch: E: non-executable-script /usr/share/gallery3/modules/openid/lib/openid-selector/generate-sprite.sh 0644L /bin/bash gallery3-openid.noarch: E: non-executable-script /usr/share/gallery3/modules/openid/lib/openid-selector/generate-sprite.rb 0644L /usr/bin/env gallery3-openid.noarch: E: non-executable-script /usr/share/gallery3/modules/openid/lib/openid-selector/remcomments.sed 0644L /bin/sed 2 packages and 0 specfiles checked; 3 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint gallery3-openid gallery3-openid.noarch: W: no-documentation gallery3-openid.noarch: E: non-executable-script /usr/share/gallery3/modules/openid/lib/openid-selector/generate-sprite.sh 0644L /bin/bash gallery3-openid.noarch: E: non-executable-script /usr/share/gallery3/modules/openid/lib/openid-selector/generate-sprite.rb 0644L /usr/bin/env gallery3-openid.noarch: E: non-executable-script /usr/share/gallery3/modules/openid/lib/openid-selector/remcomments.sed 0644L /bin/sed 1 packages and 0 specfiles checked; 3 errors, 1 warnings. # echo 'rpmlint-done:'
Requires -------- gallery3-openid (rpmlib, GLIBC filtered): gallery3
Provides -------- gallery3-openid: gallery3-openid
Source checksums ---------------- http://kott.fm/tomek/wp-content/uploads/2012/05/openid-2.0-beta.zip : CHECKSUM(SHA256) this package : ffcd87a205f438b2bd1f08525c18d1958d2c1c6d78500023de0abb5144f88c81 CHECKSUM(SHA256) upstream package : ffcd87a205f438b2bd1f08525c18d1958d2c1c6d78500023de0abb5144f88c81
Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -P PHP -b 1014344 Buildroot used: fedora-18-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, SugarActivity, Perl, R, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
--- Comment #4 from Patrick Uiterwijk puiterwijk@gmail.com --- I split the lightopenid and openid-selector libraries, and added -p. I also emailed the author to ask for a new release with license text attached.
Spec URL: http://puiterwijk.fedorapeople.org//gallery3-openid.spec SRPM URL: http://puiterwijk.fedorapeople.org//gallery3-openid-2.0-0.2.beta.fc19.src.rp...
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
Patrick Uiterwijk puiterwijk@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1014353, 1014385
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
Ian Weller ian@ianweller.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Ian Weller ian@ianweller.org --- All problems noted in review are fixed, so this is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
Patrick Uiterwijk puiterwijk@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-cvs?
--- Comment #6 from Patrick Uiterwijk puiterwijk@gmail.com --- New Package SCM Request ======================= Package Name: gallery3-openid Short Description: OpenID support for Gallery3 Owners: puiterwijk Branches: f19 f20 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- gallery3-openid-2.0-0.2.beta.fc19,php-lightopenid-0.6-1.fc19,openid-selector-1.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/gallery3-openid-2.0-0.2.beta.fc19,ph...
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- gallery3-openid-2.0-0.2.beta.fc19, php-lightopenid-0.6-1.fc19, openid-selector-1.3-1.fc19 has been pushed to the Fedora 19 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |gallery3-openid-2.0-0.2.bet | |a.fc19 Resolution|--- |ERRATA Last Closed| |2013-10-18 15:58:22
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- gallery3-openid-2.0-0.2.beta.fc19, php-lightopenid-0.6-1.fc19, openid-selector-1.3-1.fc19 has been pushed to the Fedora 19 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
Bug 1014344 depends on bug 1014353, which changed state.
Bug 1014353 Summary: Review Request: php-lightopenid - PHP OpenID library https://bugzilla.redhat.com/show_bug.cgi?id=1014353
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1014344
Bug 1014344 depends on bug 1014385, which changed state.
Bug 1014385 Summary: Review Request: openid-selector - A user-friendly way to select an OpenID https://bugzilla.redhat.com/show_bug.cgi?id=1014385
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla