https://bugzilla.redhat.com/show_bug.cgi?id=2097677
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
|requires_doc_text? |
--- Comment #4 from Petr Pisar <ppisar(a)redhat.com> ---
Changes in the spec file:
--- perl-MikroTik-API.spec.old 2022-06-16 11:44:21.000000000 +0200
+++ perl-MikroTik-API.spec 2022-06-30 15:42:18.000000000 +0200
@@ -1,54 +1,50 @@
Name: perl-MikroTik-API
Version: 2.0.1
-Release: 1%{?dist}
-Summary: Client to MikroTik RouterOS API
+Release: 2%{?dist}
+Summary: Client for the MikroTik RouterOS API
License: MIT
URL:
https://metacpan.org/dist/MikroTik-API
Source0:
https://cpan.metacpan.org/authors/id/M/MA/MARTINGO/MikroTik-API-%{version...
BuildArch: noarch
+BuildRequires: make
BuildRequires: perl-generators
BuildRequires: perl-interpreter
BuildRequires: perl(Carp)
BuildRequires: perl(Digest::MD5)
-BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(IO::Socket::IP)
BuildRequires: perl(IO::Socket::SSL)
BuildRequires: perl(Moo)
BuildRequires: perl(MooX::Types::MooseLike::Base)
BuildRequires: perl(namespace::autoclean)
-BuildRequires: perl(Test::More)
BuildRequires: perl(Time::Out)
BuildRequires: perl(Try::Tiny)
BuildRequires: perl(Type::Tiny)
-BuildRequires: perl(Module::Install)
-Requires: perl(Carp)
-Requires: perl(Digest::MD5)
-Requires: perl(IO::Socket::IP)
-Requires: perl(IO::Socket::SSL)
-Requires: perl(Moo)
-Requires: perl(MooX::Types::MooseLike::Base)
-Requires: perl(namespace::autoclean)
-Requires: perl(Time::Out)
-Requires: perl(Try::Tiny)
-Requires: perl(Type::Tiny)
+BuildRequires: perl(inc::Module::Install)
+BuildRequires: perl(strict)
+BuildRequires: perl(warnings)
+# tests
+BuildRequires: perl(Pod::Coverage)
+BuildRequires: perl(Test::More)
+BuildRequires: perl(Test::Pod)
+BuildRequires: perl(Test::Pod::Coverage)
+
+Requires: perl(:VERSION) >= 5.6
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
%description
-Client to MikroTik RouterOS API
+Perl client for the MikroTik RouterOS API.
%prep
%setup -q -n MikroTik-API-%{version}
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
-make %{?_smp_mflags}
+perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
+%make_build
%install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
-find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-
+%make_install
%{_fixperms} $RPM_BUILD_ROOT/*
FIX: Build-require 'coreutils' (perl-MikroTik-API.spec:48).
+Requires: perl(:VERSION) >= 5.6
FIX: This should be a
BuildRequires (Makefile.PL:1). Requires is already
generated.
TODO: Use plain 'perl' instead of macro '%{__perl}'
(perl-MikroTik-API.spec:34).
+BuildRequires: perl(Test::Pod)
FIX: Add '>= 1.22'
constraint (t/pod.t:8).
+BuildRequires: perl(Test::Pod::Coverage)
FIX: Add '>=
1.08' constraint (t/pod-coverage.t:8).
+BuildRequires: perl(Pod::Coverage)
FIX: Add '>=
0.18' constraint (t/pod-coverage.t:15).
$ rpmlint perl-MikroTik-API.spec
../SRPMS/perl-MikroTik-API-2.0.1-2.fc37.src.rpm
../RPMS/noarch/perl-MikroTik-API-2.0.1-2.fc37.noarch.rpm
======================================== rpmlint session starts
=======================================
rpmlint: 2.2.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/licenses.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
========= 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness;
has taken 0.4 s ========
rpmlint is Ok.
The package builds in F37
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=88944280). Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-MikroTik-API-2.0.1-2.fc37.noarch.rpm
| sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.36.0)
1 perl(:VERSION) >= 5.6
1 perl(:VERSION) >= 5.6.0
1 perl(Carp)
1 perl(Digest::MD5)
1 perl(IO::Socket::IP)
1 perl(IO::Socket::SSL)
1 perl(Moo)
1 perl(MooX::Types::MooseLike::Base)
1 perl(namespace::autoclean)
1 perl(strict)
1 perl(Time::Out)
1 perl(Try::Tiny)
1 perl(Type::Tiny)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
FIX: Do not run-require 'perl(:VERSION) >= 5.6' explicitly. This dependency is
detected.
$ resolvedeps rawhide ../RPMS/noarch/perl-MikroTik-API-2.0.1-2.fc37.noarch.rpm
Binary dependencies are resolvable. Ok.
The spec file is much better now. Thanks for fixing the issues.
Please correct the 'FIX' items and consider fixing a 'TODO' item before
building this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2097677