[Bug 690726] New: Review Request: python-hg-git - mercurial client to talk to git server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-hg-git - mercurial client to talk to git server
https://bugzilla.redhat.com/show_bug.cgi?id=690726
Summary: Review Request: python-hg-git - mercurial client to talk to git server Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: johnhford@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://people.mozilla.com/~jford/fedora/hg-git.spec SRPM URL: http://people.mozilla.com/~jford/fedora/python-hg-git-0.2.6-1.fc14.src.rpm Description: (not sure if this should be upstream's description or mine, upstream's is in the spec)
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2944506
This is a mercurial extension that allows someone to use mercurial to interact with git servers. It is a fairly simple package but I had a question regarding naming.
The upstream project is called 'hg-git' but the module is 'hggit'. according to the naming guidelines [1], I think i should use hggit (more specifically python-hggit). Is this correct?
[1]https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690726
John F johnhford@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |johnhford@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690726
--- Comment #1 from John F johnhford@gmail.com 2011-03-25 14:54:56 EDT --- Thanks, thm. I have modified the spec to use the python-hggit name as well as running tests as a part of the build.
SPEC URL: http://people.mozilla.com/~jford/fedora/python-hggit.spec SRPM URL: http://people.mozilla.com/~jford/fedora/python-hggit-0.2.6-1.fc14.src.rpm
scratch koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=2946182
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690726
W. Michael Petullo mike@flyn.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mike@flyn.org
--- Comment #2 from W. Michael Petullo mike@flyn.org 2011-10-27 21:16:28 EDT --- I tried to build this package but received:
[...] -% expect 'git@heroku.com' -git@heroku.com -% expect '/webjam/webjam.git' -/webjam/webjam.git -% expect 'github.com' -github.com +Traceback (most recent call last): + File "/home/mike/Source/rpms/BUILD/hg-git-0.2.6/tests/test-url-parsing.py", line 6, in <module> + from hggit.git_handler import GitHandler + File "/home/mike/Source/rpms/BUILDROOT/python-hggit-0.2.6-1.fc15.x86_64/usr/lib/python2.7/site-packages/hggit/__init__.py", line 134, in <module> + extensions.wrapfunction(discovery, 'findoutgoing', findoutgoing) + File "/usr/lib64/python2.7/site-packages/mercurial/extensions.py", line 184, in wrapfunction + origfn = getattr(container, funcname) +AttributeError: 'module' object has no attribute 'findoutgoing'
Failed test-empty-working-tree: output changed and returned error code 1 Failed test-push-r: output changed and returned error code 1 Failed test-url-parsing.py: output changed and returned error code 1 # Tested unexpected mercurial: None # Ran 20 tests, 17 skipped, 3 failed. # Cleaning up HGTMP /tmp/hgtests.TcaV1E error: Bad exit status from /tmp/rpm-tmp.2Lrf4h (%check)
RPM build errors: user jhford does not exist - using root group jhford does not exist - using root user jhford does not exist - using root group jhford does not exist - using root Bad exit status from /tmp/rpm-tmp.2Lrf4h (%check)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=690726
Ed Marshall esm@logic.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |esm@logic.net
--- Comment #3 from Ed Marshall esm@logic.net 2012-01-31 14:54:01 EST --- Updating to the latest version of hg-git (0.3.2 as of this posting) resolves the problem and allows this to build (the discovery API changed in Mercurial 1.9, and findoutgoing is no longer available).
Also, Source0 could be changed to http://pypi.python.org/packages/source/h/%%7Bsrcname%7D/%%7Bsrcname%7D-%%7Bv... (upstream doesn't provide tarballs directly from their website, but they do make them available in pypi). The downside is, the version shipped via pypi doesn't include the tests directory, so perhaps grabbing the tagged releases from bitbucket are still a better idea (the list of tags on github doesn't seem to be up-to-date).
John, would you be willing to post an updated version?
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla