https://bugzilla.redhat.com/show_bug.cgi?id=1120293
Bug ID: 1120293 Summary: Review Request: perl-Inline-C - Write Perl subroutines in C Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: psabata@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://psabata.fedorapeople.org/pkgs/perl-Inline-C/perl-Inline-C.spec SRPM URL: http://psabata.fedorapeople.org/pkgs/perl-Inline-C/perl-Inline-C-0.60-1.fc20... Description: Inline::C is a module that allows you to write Perl subroutines in C. Since version 0.30 the Inline module supports multiple programming languages and each language has its own support module. Fedora Account System Username: psabata
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1120297
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1120297 [Bug 1120297] Review Request: perl-Inline-Filters - Common source code filters for Inline modules
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1120299
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1120299 [Bug 1120299] Review Request: perl-Inline-Struct - Manipulate C structures directly from Perl
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1118648
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1118648 [Bug 1118648] perl-Inline-0.58 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com Assignee|nobody@fedoraproject.org |ppisar@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
--- Comment #1 from Petr Pisar ppisar@redhat.com --- URL and Source0 are usable. Ok. Source tar ball is original (SHA-256: f8593750d45d1c068195b4f16643fe4b3d50956e79d26c3c8aa7ba887ae75a45). Ok. Summary verified from README. Ok. Description verified from README. Ok.
FATAL: lib/Inline/C/Cookbook.pod license is Artistic:
=head1 COPYRIGHT
Copyright 2000-2014. Ingy döt Net.
Copyright 2008, 2010-2014. Sisyphus.
See Lhttp://www.perl.com/perl/misc/Artistic.html
The URL points to The "Artistic License" license which is not allowed by Fedora. Please remove the file from source archive, or clarify the license with the upstream and Fedora legal department.
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |182235 (FE-Legal)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|182235 (FE-Legal) |
--- Comment #2 from Petr Šabata psabata@redhat.com --- I removed the offending file from the distribution for now.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
--- Comment #3 from Petr Pisar ppisar@redhat.com --- You need to remove the file from Inline-C-0.60.tar.gz archive. Deleting in the SPEC file is too late.
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
--- Comment #4 from Petr Šabata psabata@redhat.com --- Alright, removed. Links updated.
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
--- Comment #5 from Petr Pisar ppisar@redhat.com --- URL and Source0 are usable. Ok. Source tar ball is modified (original SHA-256: f8593750d45d1c068195b4f16643fe4b3d50956e79d26c3c8aa7ba887ae75a45). lib/Inline/C/Cookbook.pod has been removed and MANIFEST updated. Ok. Summary verified from README. Ok. Description verified from README. Ok. License verified from lib/Inline/C.pod, lib/Inline/C/ParseRecDescent.pod, lib/Inline/C/ParseRegExp.pod, LICENSE, README. Ok. No XS is code in the binary packages, noarch BuildArch is Ok.
TODO: Due to NO_PACKLIST=1 added in recent ExtUtil::MakeMaker, you should increase perl(ExtUtils::MakeMaker) build-time dependency to `>= 6.76'.
The Concflicts is Ok.
TODO: Constrain `perl(File::Spec)' dependency with `>= 0.8' (Makefile.PL:23). TODO: Constrain `perl(Parse::RecDescent)' dependency with `>= 1.80' (Makefile.PL:25). TODO: Constrain `perl(Test::More)' dependency with `>= 0.88' (Makefile.PL:45). TODO: Constrain `perl(Test::Warn)' dependency with `>= 0.23' (Makefile.PL:46).
TODO: I recommend to conditionalize dependencies on Inline::Filters and Inline::Struct by %perl_bootstrap macro as they are optional as Parse::RecDescent.
Test::Pod is not used. Ok.
All tests pass. Ok.
$ rpmlint perl-Inline-C.spec ../SRPMS/perl-Inline-C-0.60-1.fc22.src.rpm ../RPMS/noarch/perl-Inline-C-0.60-1.fc22.noarch.rpm perl-Inline-C.spec:8: W: macro-in-comment %{version} perl-Inline-C.spec:9: W: macro-in-comment %{version} perl-Inline-C.spec:10: W: macro-in-comment %{version} perl-Inline-C.spec:11: W: macro-in-comment %{version} perl-Inline-C.spec:12: W: macro-in-comment %{version} perl-Inline-C.spec:12: W: macro-in-comment %{version} perl-Inline-C.spec: W: invalid-url Source0: Inline-C-0.60.fedora.tar.gz perl-Inline-C.src:8: W: macro-in-comment %{version} perl-Inline-C.src:9: W: macro-in-comment %{version} perl-Inline-C.src:10: W: macro-in-comment %{version} perl-Inline-C.src:11: W: macro-in-comment %{version} perl-Inline-C.src:12: W: macro-in-comment %{version} perl-Inline-C.src:12: W: macro-in-comment %{version} perl-Inline-C.src: W: invalid-url Source0: Inline-C-0.60.fedora.tar.gz 2 packages and 1 specfiles checked; 0 errors, 14 warnings. TODO: Escape % in comments.
$ rpm -q -lv -p ../RPMS/noarch/perl-Inline-C-0.60-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Jul 17 15:50 /usr/share/doc/perl-Inline-C -rw-r--r-- 1 root root 1267 Jul 14 07:04 /usr/share/doc/perl-Inline-C/CONTRIBUTING -rw-r--r-- 1 root root 5435 Jul 14 07:04 /usr/share/doc/perl-Inline-C/Changes -rw-r--r-- 1 root root 18350 Jul 14 07:04 /usr/share/doc/perl-Inline-C/LICENSE -rw-r--r-- 1 root root 19756 Jul 14 07:04 /usr/share/doc/perl-Inline-C/README -rw-r--r-- 1 root root 9345 Jul 17 15:48 /usr/share/man/man3/Inline::C.3pm.gz -rw-r--r-- 1 root root 2159 Jul 17 15:48 /usr/share/man/man3/Inline::C::ParseRecDescent.3pm.gz -rw-r--r-- 1 root root 2159 Jul 17 15:48 /usr/share/man/man3/Inline::C::ParseRegExp.3pm.gz drwxr-xr-x 2 root root 0 Jul 17 15:48 /usr/share/perl5/vendor_perl/Inline/C -rw-r--r-- 1 root root 33308 Jul 14 07:04 /usr/share/perl5/vendor_perl/Inline/C.pm -rw-r--r-- 1 root root 19197 Jul 14 07:04 /usr/share/perl5/vendor_perl/Inline/C.pod -rw-r--r-- 1 root root 4122 Jul 14 07:04 /usr/share/perl5/vendor_perl/Inline/C/ParseRecDescent.pm -rw-r--r-- 1 root root 775 Jul 14 07:04 /usr/share/perl5/vendor_perl/Inline/C/ParseRecDescent.pod -rw-r--r-- 1 root root 5576 Jul 14 07:04 /usr/share/perl5/vendor_perl/Inline/C/ParseRegExp.pm -rw-r--r-- 1 root root 743 Jul 14 07:04 /usr/share/perl5/vendor_perl/Inline/C/ParseRegExp.pod File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Inline-C-0.60-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Carp) 1 perl(Config) 1 perl(Cwd) 1 perl(Data::Dumper) 1 perl(ExtUtils::MakeMaker) 1 perl(Fcntl) 1 perl(File::Spec) 1 perl(Inline) >= 0.56 1 perl(Inline) >= 0.58 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: Remove under-specified dependency on `perl(Inline) >= 0.56'. FIX: Run-require `perl(FindBin)' (lib/Inline/C.pm:47). TODO: I recommend to run-require Inline::Filters, Inline::Struct, Parse::RecDescent, Time::HiRes. The code croaks without them. This is just a prettier die.
$ rpm -q --provides -p ../RPMS/noarch/perl-Inline-C-0.60-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Inline::C) = 0.60 1 perl(Inline::C::ParseRecDescent) 1 perl(Inline::C::ParseRegExp) 1 perl-Inline-C = 0.60-1.fc22 Binary provides are Ok.
resolvedeps f22-build ../RPMS/noarch/perl-Inline-C-0.60-1.fc22.noarch.rpm Binary dependencies resolvable. Ok.
Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7158331). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct all `FIX' items, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
--- Comment #6 from Petr Šabata psabata@redhat.com --- (In reply to Petr Pisar from comment #5)
TODO: I recommend to conditionalize dependencies on Inline::Filters and Inline::Struct by %perl_bootstrap macro as they are optional as Parse::RecDescent.
That's planned once they get into Fedora.
TODO: Due to NO_PACKLIST=1 added in recent ExtUtil::MakeMaker, you should increase perl(ExtUtils::MakeMaker) build-time dependency to `>= 6.76'.
Done.
TODO: Escape % in comments.
Done.
FIX: Run-require `perl(FindBin)' (lib/Inline/C.pm:47).
Done.
TODO: I recommend to run-require Inline::Filters, Inline::Struct, Parse::RecDescent, Time::HiRes. The code croaks without them. This is just a prettier die.
Planned. Will be done once they're available.
Links updated.
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Petr Pisar ppisar@redhat.com --- Spec file changes:
$ diff -u perl-Inline-C.spec{.old,} --- perl-Inline-C.spec.old 2014-07-17 15:13:52.000000000 +0200 +++ perl-Inline-C.spec 2014-07-17 16:24:15.000000000 +0200 @@ -6,10 +6,10 @@ Group: Development/Libraries URL: http://search.cpan.org/dist/Inline-C/ # Created from http://www.cpan.org/authors/id/I/IN/INGY/Inline-C-%%7Bversion%7D.tar.gz -# tar xzf Inline-C-%{version}.tar.gz && \ -# rm -f Inline-C-%{version}/lib/Inline/C/Cookbook.pod && \ -# sed -e '/Cookbook.pod$/d' -i Inline-C-%{version}/MANIFEST && \ -# tar czf Inline-C-%{version}.fedora.tar.gz Inline-C-%{version} +# tar xzf Inline-C-%%{version}.tar.gz && \ +# rm -f Inline-C-%%{version}/lib/Inline/C/Cookbook.pod && \ +# sed -e '/Cookbook.pod$/d' -i Inline-C-%%{version}/MANIFEST && \ +# tar czf Inline-C-%%{version}.fedora.tar.gz Inline-C-%{version} Source0: Inline-C-%{version}.fedora.tar.gz BuildArch: noarch BuildRequires: perl @@ -19,7 +19,7 @@ BuildRequires: perl(Cwd) BuildRequires: perl(Data::Dumper) BuildRequires: perl(diagnostics) -BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30 +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 BuildRequires: perl(Fcntl) BuildRequires: perl(File::Path) BuildRequires: perl(File::Spec) @@ -34,6 +34,7 @@ BuildRequires: perl(Test::Warn) BuildRequires: perl(Time::HiRes) BuildRequires: perl(warnings) +Requires: perl(FindBin) Requires: perl(Inline) >= 0.58 Requires: perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version)) # Split from Inline in 0.58
TODO: Due to NO_PACKLIST=1 added in recent ExtUtil::MakeMaker, you should increase perl(ExtUtils::MakeMaker) build-time dependency to `>= 6.76'.
-BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30 +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 Ok.
TODO: Constrain `perl(File::Spec)' dependency with `>= 0.8' (Makefile.PL:23).
Not addressed.
TODO: Constrain `perl(Parse::RecDescent)' dependency with `>= 1.80' (Makefile.PL:25).
Not addressed.
TODO: Constrain `perl(Test::More)' dependency with `>= 0.88' (Makefile.PL:45).
Not addressed.
TODO: Constrain `perl(Test::Warn)' dependency with `>= 0.23' (Makefile.PL:46).
Not addressed.
TODO: I recommend to conditionalize dependencies on Inline::Filters and Inline::Struct by %perl_bootstrap macro as they are optional as Parse::RecDescent.
Not addressed. One can add %global perl_bootstrap 1 at the beginning of the spec file now and use the macros now.
$ rpmlint perl-Inline-C.spec ../SRPMS/perl-Inline-C-0.60-1.fc22.src.rpm ../RPMS/noarch/perl-Inline-C-0.60-1.fc22.noarch.rpm perl-Inline-C.spec:8: W: macro-in-comment %{version} perl-Inline-C.spec:12: W: macro-in-comment %{version} perl-Inline-C.spec: W: invalid-url Source0: Inline-C-0.60.fedora.tar.gz perl-Inline-C.src:8: W: macro-in-comment %{version} perl-Inline-C.src:12: W: macro-in-comment %{version} perl-Inline-C.src: W: invalid-url Source0: Inline-C-0.60.fedora.tar.gz 2 packages and 1 specfiles checked; 0 errors, 6 warnings.
TODO: Remove under-specified dependency on `perl(Inline) >= 0.56'.
Not addressed.
$ rpm -q --requires -p ../RPMS/noarch/perl-Inline-C-0.60-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Carp) 1 perl(Config) 1 perl(Cwd) 1 perl(Data::Dumper) 1 perl(ExtUtils::MakeMaker) 1 perl(Fcntl) 1 perl(File::Spec) 1 perl(FindBin) 1 perl(Inline) >= 0.56 1 perl(Inline) >= 0.58 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: Remove under-specified dependency on `perl(Inline) >= 0.56'.
Not addressed.
FIX: Run-require `perl(FindBin)' (lib/Inline/C.pm:47).
Ok.
TODO: I recommend to run-require Inline::Filters, Inline::Struct, Parse::RecDescent, Time::HiRes. The code croaks without them. This is just a prettier die.
Not addressed.
Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7158611). Ok.
Please consider fixing the `TODO' items before building the package. Resolution: Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #8 from Petr Šabata psabata@redhat.com --- New Package SCM Request ======================= Package Name: perl-Inline-C Short Description: Write Perl subroutines in C Upstream URL: http://search.cpan.org/dist/Inline-C/ Owners: psabata jplesnik ppisar Branches: f21 InitialCC: perl-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
--- Comment #10 from Petr Šabata psabata@redhat.com --- Thank you, both.
https://bugzilla.redhat.com/show_bug.cgi?id=1120293
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-Inline-C-0.60-1.fc21 Resolution|--- |RAWHIDE Last Closed| |2014-08-01 08:22:13
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla