[Bug 755498] New: Review Request: trayer - Lightweight GTK2-based systray for UNIX desktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: trayer - Lightweight GTK2-based systray for UNIX desktop
https://bugzilla.redhat.com/show_bug.cgi?id=755498
Summary: Review Request: trayer - Lightweight GTK2-based systray for UNIX desktop Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nlminhtl@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: https://raw.github.com/Ignotus/trayer-fedora/53c21d91c901fe3153393d92c4dd041... SRPM URL: https://github.com/Ignotus/trayer-fedora/blob/53c21d91c901fe3153393d92c4dd04... Description: trayer is a small program designed to provide systray functionality present in GNOME/KDE desktop environments for window managers which do not support that function. System tray is a place, where various applications put their icons, so they are always visible presenting status of applications and allowing user to control programs.
The code started out as an extraction from fbpanel.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755498
Volker Fröhlich volker27@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@gmx.at
--- Comment #1 from Volker Fröhlich volker27@gmx.at 2011-12-09 13:39:15 EST --- According to the files, the license is GPLv2+, not MIT. The FSF address is wrong. Feel free to correct it or not, but inform upstream. Inform upstream, they're shipping a wrong license file and therefore don't include it or replace it with the proper one for Fedora. Even other files state LGPL.
I'm not really sure, whether you're packaging a real release or a snapshot. If it is a snapshot, you must change release and give guidelines how to build the tarball you're using. If it is not a snapshot, use a URL for Source0.
See http://fedoraproject.org/wiki/Packaging:NamingGuidelines
The build does not respect Fedora's optflags.
You can drop defattr.
CREDITS is not UTF8.
Buildroot, clean section and the rm in the install section are only useful for EPEL 5 or older. If you're not going for these, remove them.
Don't exceed 80 characters per line with your description.
Please align the entries for Source0 and Group with the rest (mixed use of tabs and spaces)
Ask upstream to release tarball names and directories that don't contain a Git hash, but name-version or something different that makes sense: http://ftp.sunet.se/pub/Linux/kernel.org/software/scm/git/docs/git-archive.h...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=755498
--- Comment #2 from Volker Fröhlich volker27@gmx.at 2012-04-10 17:50:27 EDT --- Any news, Minh?
https://bugzilla.redhat.com/show_bug.cgi?id=755498
Robin Lee robinlee.sysu@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |robinlee.sysu@gmail.com Flags| |needinfo?(nlminhtl@gmail.co | |m)
--- Comment #3 from Robin Lee robinlee.sysu@gmail.com --- Any news? There is a new duplicated request. If the requester is not responsive, then this one will be marked as duplicate.
https://bugzilla.redhat.com/show_bug.cgi?id=755498
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |mario.blaettermann@gmail.co | |m Resolution|--- |DUPLICATE Flags|needinfo?(nlminhtl@gmail.co | |m) | Last Closed| |2012-07-07 15:26:25
--- Comment #4 from Mario Blättermann mario.blaettermann@gmail.com --- Because the reporter doesn't response within a reasonable time frame, this review request will be closed now.
*** This bug has been marked as a duplicate of bug 827101 ***
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla