[Bug 435572] New: Review Request: gnome-hearts - Hearts game for GNOME - package-review

List overview All Threads
Download

newer

[Bug 435572] New: Review Request: gnome-hearts - Hearts game for GNOME

older

[Bug 447778] New: Review Request:...

[Bug 449367] New: Review Request:...

Red Hat Bugzilla

1 Mar 2008 1 Mar '08

5:12 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=435572

Summary: Review Request: gnome-hearts - Hearts game for GNOME Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: caillon@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://caillon.fedorapeople.org/gnome-hearts.spec SRPM URL: http://caillon.fedorapeople.org/gnome-hearts-0.2.1-1.fc9.src.rpm Description: An implementation of the classic hearts card game for the GNOME desktop, featuring configurable rulesets and editable computer opponents to satisfy widely diverging playing styles. Gnome Hearts is Free Software, released under the GNU General Public License and should be able to run on any computer that can run the GNOME desktop.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by thread

Red Hat Bugzilla

1 Mar 1 Mar

5:14 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From caillon@redhat.com 2008-03-01 18:14 EST ------- Bug 291741 was closed due to inactivity. I took richi's version at 0.2-3.svn163 and did my own package review of it before posting it, and this is the result.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

2 Mar 2 Mar

10:01 a.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |richip@richip.dhs.org

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-02 11:01 EST ------- *** Bug 291741 has been marked as a duplicate of this bug. ***

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

8:16 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From richip@richip.dhs.org 2008-03-02 21:16 EST ------- Pardonez moi. First baby threw a wrench in the gears. Glad to hear it's coming, though.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

3 Mar 3 Mar

8:20 a.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

mtasaka@ioa.s.u-tokyo.ac.jp changed:

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-03 09:20 EST ------- For 0.2.1-1:

* License - Please change the license tag to "GPLv2+ aned GFDL". * Document files under %{_datadir}/gnome/help/ are licensed under GFDL. * The rest parts are licensed under GPLv2+

* Documents - "COPYING" file is rather mandatory for %doc if it exists.

* desktop-file-install - Please call desktop-file-install for installing desktop file.

* Timestamps - I recommend to use ------------------------------------------------------ make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ------------------------------------------------------ to keep timestamps on installed files. This method usually works for recent autotool-based Makefiles.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

7 Mar 7 Mar

10:39 a.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From caillon@redhat.com 2008-03-07 11:39 EST ------- (In reply to comment #4)

...

For 0.2.1-1:

License

Please change the license tag to "GPLv2+ aned GFDL".

Document files under %{_datadir}/gnome/help/ are licensed under GFDL.

The rest parts are licensed under GPLv2+

Documents

"COPYING" file is rather mandatory for %doc if it exists.

Above two items OK.

...

desktop-file-install

Please call desktop-file-install for installing desktop file.

It is useless here. The app installs it for us. We should only use desktop-file-install for Fedora-managed specs, not for ones installed by the application.

...

Timestamps

I recommend to use

make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
to keep timestamps on installed files. This method usually
works for recent autotool-based Makefiles.

I recommend getting this fixed in autotools, and not tweaking packages.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:50 a.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-07 11:50 EST ------- (In reply to comment #5)

...

...

desktop-file-install

Please call desktop-file-install for installing desktop file.

It is useless here. The app installs it for us. We should only use desktop-file-install for Fedora-managed specs, not for ones installed by the application.

This is not. desktop-file-utils is used on Fedora packaging not only for installing desktop files but also for checking if installed desktop file meets freedesktop standards (i.e. if desktop-file-install (--delete-original, for example) rejects installed desktop files, it must be fixed).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

9 Mar 9 Mar

5:18 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From caillon@redhat.com 2008-03-09 18:18 EST ------- If we want it to be validated, then we should run desktop-file-validate and stop pretending we need to install it. This way in case the desktop file ever stops being installed automatically, or gets installed into a different location, we also fail the build.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

7:26 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-09 20:26 EST ------- Then ask for fedora-packaing. Now this is a must.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12 Mar 12 Mar

1:20 a.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From caillon@redhat.com 2008-03-12 02:20 EST ------- I have no idea what that means.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

2:40 a.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-12 03:40 EST ------- Just look at the subsection "desktop-file-install usage" of http://fedoraproject.org/wiki/Packaging/Guidelines

and the MUST item of http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

15 Mar 15 Mar

5:13 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From caillon@redhat.com 2008-03-15 18:13 EST ------- Okay, are those the only things wrong with the spec?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:23 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-03-15 23:23 EST ------- (In reply to comment #11)

...

Okay, are those the only things wrong with the spec?

Please also fix the issue below: (In reply to comment #5)

...

(In reply to comment #4)

...
For 0.2.1-1:

License

Please change the license tag to "GPLv2+ aned GFDL".

Document files under %{_datadir}/gnome/help/ are licensed under GFDL.

The rest parts are licensed under GPLv2+

Documents

"COPYING" file is rather mandatory for %doc if it exists.

Above two items OK.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

20 Apr 20 Apr

10:25 a.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From caillon@redhat.com 2008-04-20 11:25 EST ------- For reference, I raised comment 10 with FPC: https://www.redhat.com/archives/fedora-packaging/2008-April/msg00076.html

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:36 a.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From caillon@redhat.com 2008-04-20 11:36 EST ------- And fixed the license and copying file in the spec url. Those are very very minor issues and i'd prefer to start with a revision of 1 instead having to bump for that here. If you absolutely require a bump for some reason, i can create an srpm with a .fc10 disttag instead of .fc9

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

10:41 a.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-04-20 11:41 EST ------- Does it mean that you want me to wait for FPC voting?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12:43 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From caillon@redhat.com 2008-04-20 13:43 EST ------- If you feel you cannot trust me to do the right thing based on the outcome of FPC, then yes please wait. If you feel you can trust me to do the right thing, then please approve with such a statement.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

8 May 8 May

1:37 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From caillon@redhat.com 2008-05-08 14:37 EST ------- FPC passed my proposal on May 6, 2008 https://www.redhat.com/archives/fedora-devel-list/2008-May/msg00637.html and FESCo ratified it on May 8, 2008 http://bpepple.fedorapeople.org/fesco/FESCo-2008-05-08.html

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

1:57 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-05-08 14:57 EST ------- Would you update your srpm anyway as the last time I checked your srpm is more than 2 months?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

1:58 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-05-08 14:58 EST ------- (In reply to comment #18)

...

Would you update your srpm anyway as the last time I checked your srpm is more than 2 months?

as the last time I checked your srpm was more than 2 months ago?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

2:15 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From caillon@redhat.com 2008-05-08 15:15 EST ------- It's current.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11 May 11 May

12:23 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-05-11 13:23 EST ------- - Please also add "COPYING-DOCS" to %doc - Should desktop-file-validate be moved to %check?

Other things seem okay. -------------------------------------------------------------- This package (gnome-hearts) is APPROVED by me --------------------------------------------------------------

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

19 May 19 May

noon

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

mtasaka@ioa.s.u-tokyo.ac.jp changed:

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-05-19 13:00 EST ------- ping?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

28 May 28 May

11:58 a.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2008-05-28 12:58 EST ------- ping again?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

1:56 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

caillon@redhat.com changed:

------- Additional Comments From caillon@redhat.com 2008-05-28 14:56 EST ------- Okay, I'll add COPYING-DOCS and I'll investigate %check.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

2 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

caillon@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From caillon@redhat.com 2008-05-28 15:00 EST ------- New Package CVS Request ======================= Package Name: gnome-hearts Short Description: Hearts game for GNOME Owners: caillon Branches: F-8 F-9 Cvsextras Commits: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

30 May 30 May

2:24 p.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-05-30 15:24 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

3 Jun 3 Jun

9:50 a.m.

New subject: [Bug 435572] Review Request: gnome-hearts - Hearts game for GNOME

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-hearts - Hearts game for GNOME

https://bugzilla.redhat.com/show_bug.cgi?id=435572

caillon@redhat.com changed:

------- Additional Comments From caillon@redhat.com 2008-06-03 10:50 EST ------- packages built, closing out.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

6258

Age (days ago)

6352

Last active (days ago)

package-review@lists.fedoraproject.org

27 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla