[Bug 1701021] New: Review Request: golang-github-dnsimple - Go client for the DNSimple API v2
https://bugzilla.redhat.com/show_bug.cgi?id=1701021
Bug ID: 1701021 Summary: Review Request: golang-github-dnsimple - Go client for the DNSimple API v2 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: carl@george.computer QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/reviews/fedora-r... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/reviews/fedora-r...
Description: This library is a Go client you can use to interact with the DNSimple API v2.
Fedora Account System Username: carlwgeorge
https://bugzilla.redhat.com/show_bug.cgi?id=1701021
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- %global goipath github.com/dnsimple/dnsimple-go/dnsimple
Not github.com/dnsimple/dnsimple-go? Are you sure the last dnsimple is necessary here?
Package approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 236 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/golang-github-dnsimple/review-golang- github-dnsimple/licensecheck.txt [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: golang-github-dnsimple-devel-0.23.0-1.fc31.noarch.rpm golang-github-dnsimple-0.23.0-1.fc31.src.rpm golang-github-dnsimple-devel.noarch: W: invalid-url URL: https://github.com/dnsimple/dnsimple-go/dnsimple HTTP Error 404: Not Found golang-github-dnsimple-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dnsimple/dnsimple-go/dnsimple/.goipath golang-github-dnsimple.src: W: invalid-url URL: https://github.com/dnsimple/dnsimple-go/dnsimple HTTP Error 404: Not Found golang-github-dnsimple.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1701021
--- Comment #2 from Carl George carl@george.computer ---
Are you sure the last dnsimple is necessary here?
That's what upstream advertises in their README. I'm happy to change it if needed but my understanding is that should match the upstream import path.
https://github.com/dnsimple/dnsimple-go/blob/v0.23.0/README.md#installation
https://bugzilla.redhat.com/show_bug.cgi?id=1701021
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-dnsimple
https://bugzilla.redhat.com/show_bug.cgi?id=1701021
--- Comment #4 from Carl George carl@george.computer --- We discussed this in #fedora-golang, and the consensus was to change goipath to github.com/dnsimple/dnsimple-go. I'll make that adjustment when I import the SRPM.
https://bugzilla.redhat.com/show_bug.cgi?id=1701021
--- Comment #5 from Carl George carl@george.computer --- Rawhide build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1253157
https://bugzilla.redhat.com/show_bug.cgi?id=1701021
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- golang-github-dnsimple-0.23.0-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-94f8f3d784
https://bugzilla.redhat.com/show_bug.cgi?id=1701021
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- golang-github-dnsimple-0.23.0-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-1c5cc0cd10
https://bugzilla.redhat.com/show_bug.cgi?id=1701021
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- golang-github-dnsimple-0.23.0-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-94f8f3d784
https://bugzilla.redhat.com/show_bug.cgi?id=1701021
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-dnsimple-0.23.0-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-1c5cc0cd10
https://bugzilla.redhat.com/show_bug.cgi?id=1701021
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-05-01 00:40:29
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- golang-github-dnsimple-0.23.0-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1701021
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- golang-github-dnsimple-0.23.0-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com