[Bug 443310] New: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4 - package-review

List overview All Threads
Download

newer

[Bug 443310] New: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

older

[Bug 672957] New: Review Request:...

[Bug 740561] New: Review Request:...

Red Hat Bugzilla

20 Apr 2008 20 Apr '08

3:44 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=443310

Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4 Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: fedora@christoph-wickert.de QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://cwickert.fedorapeople.org/review/xfwm4-theme-nodoka.spec SRPM URL: http://cwickert.fedorapeople.org/review/xfwm4-theme-nodoka-0.1-1.fc9.src.rpm Description: The Nodoka theme for xfwm4. A clean theme featuring soft gradients and Echoey look and feel.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by date

Red Hat Bugzilla

20 Apr 20 Apr

3:46 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

https://bugzilla.redhat.com/show_bug.cgi?id=443310

fedora@christoph-wickert.de changed:

------- Additional Comments From fedora@christoph-wickert.de 2008-04-20 10:46 EST ------- If someone could review this package quickly we might be able to make it into final.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:21 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

https://bugzilla.redhat.com/show_bug.cgi?id=443310

martin.sourada@gmail.com changed:

------- Additional Comments From martin.sourada@gmail.com 2008-04-20 11:21 EST ------- Must items: rpmlint clean name OK specfile OK follow the guidelines OK has approved license OK md5 correct for the temporary source on your page package builds OK no locales OK no shared libs OK owns its dirs OK

Problems: URL was not correct so I've uploaded the sources in your stead to speed up the review. (https://fedorahosted.org/releases/n/o/nodoka/xfwm4-theme-nodoka-0.1.tar.gz) missing rm -rf $RPM_BUILD_ROOT in %%install section

Once you fix the last issue, I'll approve it.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:23 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

https://bugzilla.redhat.com/show_bug.cgi?id=443310

martin.sourada@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |martin.sourada@gmail.com

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:26 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

https://bugzilla.redhat.com/show_bug.cgi?id=443310

------- Additional Comments From martin.sourada@gmail.com 2008-04-20 11:26 EST ------- Oh and I missed the srpm rpmlint output: xfwm4-theme-nodoka.src: E: no-cleaning-of-buildroot %install xfwm4-theme-nodoka.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 30)

Please fix the warning as well.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:45 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

https://bugzilla.redhat.com/show_bug.cgi?id=443310

------- Additional Comments From fedora@christoph-wickert.de 2008-04-20 11:45 EST ------- (In reply to comment #2)

...

URL was not correct so I've uploaded the sources in your stead to speed up the review.

thanks

(In reply to comment #3)

...

Oh and I missed the srpm rpmlint output: xfwm4-theme-nodoka.src: E: no-cleaning-of-buildroot %install xfwm4-theme-nodoka.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 30)

My bad, I did not rpmlint the package. Both fixed in http://cwickert.fedorapeople.org/review/xfwm4-theme-nodoka.spec You want me to do another SRPM?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:50 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

https://bugzilla.redhat.com/show_bug.cgi?id=443310

martin.sourada@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From martin.sourada@gmail.com 2008-04-20 11:50 EST ------- (In reply to comment #4)

...

(In reply to comment #2)

...
URL was not correct so I've uploaded the sources in your stead to speed up the review.

thanks

(In reply to comment #3)

...
Oh and I missed the srpm rpmlint output: xfwm4-theme-nodoka.src: E: no-cleaning-of-buildroot %install xfwm4-theme-nodoka.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 30)

My bad, I did not rpmlint the package. Both fixed in http://cwickert.fedorapeople.org/review/xfwm4-theme-nodoka.spec You want me to do another SRPM?

Nice, that's acceptable. Would be better though, to bump the release number and mention the fixes in the %%changelog (and post new srpm here), but I do not require it.

ACCEPTED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

5:04 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

https://bugzilla.redhat.com/show_bug.cgi?id=443310

fedora@christoph-wickert.de changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From fedora@christoph-wickert.de 2008-04-20 12:04 EST ------- (In reply to comment #5)

...

Would be better though, to bump the release number and mention the fixes in the %%changelog (and post new srpm here), but I do not require it.

I usually do this but I found these changes to trivial and did not want to do another mockbuild.

New Package CVS Request ======================= Package Name: xfwm4-theme-nodoka Short Description: Nodoka theme for xfwm4 Owners: cwickert Branches: F-7 F-8 F-9 InitialCC: mso Cvsextras Commits: no

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

22 Apr 22 Apr

6:36 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

https://bugzilla.redhat.com/show_bug.cgi?id=443310

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-04-22 13:36 EST ------- Why deny cvsextras commits here? Any reason?

cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

6:56 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

https://bugzilla.redhat.com/show_bug.cgi?id=443310

------- Additional Comments From fedora@christoph-wickert.de 2008-04-22 13:56 EST ------- (In reply to comment #7)

...

Why deny cvsextras commits here? Any reason?

Other people can fix whatever they want on all my packages, but for the artwork I'd like to be in control, since I'm maintaining it upstream too.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

27 Apr 27 Apr

9:43 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

https://bugzilla.redhat.com/show_bug.cgi?id=443310

------- Additional Comments From updates@fedoraproject.org 2008-04-27 16:43 EST ------- xfwm4-theme-nodoka-0.1-1.fc8 has been submitted as an update for Fedora 8

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

29 Apr 29 Apr

9:58 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

https://bugzilla.redhat.com/show_bug.cgi?id=443310

------- Additional Comments From updates@fedoraproject.org 2008-04-29 16:58 EST ------- xfwm4-theme-nodoka-0.1-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4 May 4 May

5:23 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

https://bugzilla.redhat.com/show_bug.cgi?id=443310

fedora@christoph-wickert.de changed:

------- Additional Comments From fedora@christoph-wickert.de 2008-05-04 12:23 EST ------- xfwm4-theme-nodoka-0.1-1.fc9 and xfwm4-4.4.2-3.fc9 were successfully tagged into f9-final by notting on Wed, 30 Apr 2008 18:01:29, so they will be available in F9. Closing.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

20 May 20 May

4:43 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=443310

Orion Poplawski orion@cora.nwra.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |orion@cora.nwra.com

--- Comment #12 from Orion Poplawski orion@cora.nwra.com 2011-05-20 11:43:04 EDT --- Package Change Request ====================== Package Name: xfwm4-theme-nodoka New Branches: el6 Owners: cwickert mso InitialCC:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

26 Sep 26 Sep

4:16 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=443310

Orion Poplawski orion@cora.nwra.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:42 p.m.

New subject: [Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=443310

--- Comment #13 from Jon Ciesla limb@jcomserv.net 2011-09-26 11:42:44 EDT --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4659

Age (days ago)

5913

Last active (days ago)

package-review@lists.fedoraproject.org

15 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla