[Bug 1206528] New: Review Request: python-oslo-middleware - OpenStack Oslo Middleware library
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
Bug ID: 1206528 Summary: Review Request: python-oslo-middleware - OpenStack Oslo Middleware library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: apevec@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://apevec.fedorapeople.org/python-oslo-middleware.spec SRPM URL: https://apevec.fedorapeople.org/python-oslo-middleware-1.0.0-1.fc23.src.rpm Description: The OpenStack Oslo Middleware library. Oslo middleware library includes components that can be injected into wsgi pipelines to intercept request/response flows. The base class can be enhanced with functionality like add/delete/modification of http headers and support for limiting size/connection etc.
Fedora Account System Username: apevec
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
--- Comment #1 from Alan Pevec apevec@gmail.com --- Koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=9345630
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |karlthered@gmail.com Assignee|nobody@fedoraproject.org |karlthered@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
--- Comment #2 from Haïkel Guémar karlthered@gmail.com --- few minor issues: * missing fallback macros for %license (required for EL7) %{!?_licensedir:%global license %%doc} * missing Requires: python-oslo-context (just approved) https://bugzilla.redhat.com/show_bug.cgi?id=1201325 => I was able to confirm that it works with that package installed
Everything else is good, should be approved as soon as these points are fixed.
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
--- Comment #3 from Alan Pevec apevec@gmail.com ---
- missing fallback macros for %license (required for EL7)
%{!?_licensedir:%global license %%doc}
You mean required for EL6? %license seems to work out of the box on EL7 but I'll add it for possible EL6 rebuilds.
- missing Requires: python-oslo-context (just approved)
Also stevedore in requirements.txt.
Spec URL: https://apevec.fedorapeople.org/python-oslo-middleware.spec SRPM URL: https://apevec.fedorapeople.org/python-oslo-middleware-1.0.0-2.fc23.src.rpm Description: The OpenStack Oslo Middleware library. Oslo middleware library includes components that can be injected into wsgi pipelines to intercept request/response flows. The base class can be enhanced with functionality like add/delete/modification of http headers and support for limiting size/connection etc.
Fedora Account System Username: apevec
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Haïkel Guémar karlthered@gmail.com --- Since this package complies with Fedora packaging guidelines, I hereby approve it into Fedora Packages Collection. Please submit a SCM request.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 2 files have unknown license. Detailed output of licensecheck in /home/haikel/1206528-python-oslo-middleware/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python2.7/site- packages/oslo(python-oslo-vmware, python-oslo-messaging, python-oslo- i18n, python-oslo-sphinx, python-oslo-rootwrap, python-oslo-config, python-oslo-concurrency) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- oslo-middleware-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python-oslo-middleware-1.0.0-2.fc23.noarch.rpm python-oslo-middleware-doc-1.0.0-2.fc23.noarch.rpm python-oslo-middleware-1.0.0-2.fc23.src.rpm python-oslo-middleware.noarch: W: spelling-error %description -l en_US wsgi -> swig, wigs, newsgirl python-oslo-middleware.noarch: W: spelling-error %description -l en_US http -> HTTP python-oslo-middleware.noarch: W: incoherent-version-in-changelog 1.0.0-1 ['1.0.0-2.fc23', '1.0.0-2'] python-oslo-middleware-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-oslo-middleware-doc/html/_static/jquery.js python-oslo-middleware.src: W: spelling-error %description -l en_US wsgi -> swig, wigs, newsgirl python-oslo-middleware.src: W: spelling-error %description -l en_US http -> HTTP 3 packages and 0 specfiles checked; 0 errors, 6 warnings.
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Requires -------- python-oslo-middleware-doc (rpmlib, GLIBC filtered):
python-oslo-middleware (rpmlib, GLIBC filtered): python(abi) python-babel python-oslo-config python-oslo-context python-oslo-i18n python-six python-stevedore python-webob
Provides -------- python-oslo-middleware-doc: python-oslo-middleware-doc
python-oslo-middleware: python-oslo-middleware
Source checksums ---------------- https://pypi.python.org/packages/source/o/oslo.middleware/oslo.middleware-1.... : CHECKSUM(SHA256) this package : 5ccf160ae5ce23f3f59b86535352e3b5a9fa35dab0edc4ede8b17438da559995 CHECKSUM(SHA256) upstream package : 5ccf160ae5ce23f3f59b86535352e3b5a9fa35dab0edc4ede8b17438da559995
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
Alan Pevec apevec@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Alan Pevec apevec@gmail.com --- New Package SCM Request ======================= Package Name: python-oslo-middleware Short Description: OpenStack Oslo Middleware library Upstream URL: https://launchpad.net/oslo Owners: apevec Branches: f22 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
Patrick Uiterwijk puiterwijk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
--- Comment #6 from Patrick Uiterwijk puiterwijk@redhat.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
Alan Pevec apevec@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Fixed In Version| |python-oslo-middleware-1.0. | |0-2.fc23
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
--- Comment #7 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- social's scratch build of openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6 for git://pkgs.fedoraproject.org/openstack-puppet-modules?#db4e135626252ebf0b23b8a0e6e98ce0dcf2f9e6 and rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11426591
https://bugzilla.redhat.com/show_bug.cgi?id=1206528
Charalampos Stratakis cstratak@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED CC| |cstratak@redhat.com Resolution|--- |CURRENTRELEASE Last Closed| |2016-09-27 10:46:14
--- Comment #8 from Charalampos Stratakis cstratak@redhat.com --- Since the package has been built for quite some time now, the review request bugzilla should be closed.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla