[Bug 698576] New: Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: pal - Command line calendar that displays holidays and events

https://bugzilla.redhat.com/show_bug.cgi?id=698576

Summary: Review Request: pal - Command line calendar that
                    displays holidays and events
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
      Story Points: ---

Spec URL: http://www.physics.muni.cz/~cermak/pal/pal.spec
SRPM URL: http://www.physics.muni.cz/~cermak/pal/pal-0.4.3-1.fc14.src.rpm
Description:

Hi! I found a useful piece of software that I'd like to get packaged in Fedora.
I would appreciate a review so that I can get it into Fedora Extras.

Pal is command-line calendar program that can keep track of events pal is a
command-line calendar program for Unix/Linux systems that can keep track of
events. It has similarities with the Unix cal command, the more complex GNU
gcal program, and the calendar program distributed with the BSDs.

$ rpmlint pal.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint pal-0.4.3-1.fc14.src.rpm 
pal.src: W: spelling-error %description -l en_US gcal -> gal, cal, goal
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint x86_64/pal-0.4.3-1.fc14.x86_64.rpm 
pal.x86_64: W: spelling-error %description -l en_US gcal -> gal, cal, goal
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

Martin Cermak  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

Hans de Goede  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
             Blocks|177841(FE-NEEDSPONSOR)      |
         AssignedTo|[e-mail]    |[e-mail]

--- Comment #1 from Hans de Goede  2011-04-29 08:22:04 EDT ---
I'll review this (and your other submission), and assuming all goes well
sponsor you eventually, removing FE_NEEDSPONSOR blocker.

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

Hans de Goede  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #2 from Hans de Goede  2011-04-29 09:00:10 EDT ---
Full review done, results:

Good:
=====
- rpmlint checks return:
pal.src: W: spelling-error %description -l en_US gcal -> gal, cal, goal
pal.x86_64: W: spelling-error %description -l en_US gcal -> gal, cal, goal
 These can be ignored
- package meets naming guidelines
- package meets packaging guidelines
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- locales handled properly
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Needs work:
===========
- rpmlint checks return:
pal-debuginfo.x86_64: E: empty-debuginfo-package
 This is caused by the Makefile stripping the binary directly after the build,
 you can stop it from doing this by passing DEBUG=1 on the make cmdline.

- The license should be GPLv2+

- Fedora has a standard url for sf.net downloads, please use:
Source0:    http://downloads.sourceforge.net/palcal/pal-%%7Bversion%7D.tgz

- No need to pass: " -n %{name}-%{version}" to %setup, this is the default

- The preferred form for %defattr in fedora is:
%defattr(-,root,root,-)

- The files under %{_datadir}/doc/pal-%{version} should be marked as %doc,
  not gzipped and not include INSTALL. The easiest way is to add the following
  line to %files:
%doc doc/example.css COPYING ChangeLog
  Note traditionally this lines comes directly after the %defattr line

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

--- Comment #3 from Jason Tibbitts  2011-04-30 14:12:17 EDT ---
I see no SCM request to process here.  Perhaps the wrong flag was set by
mistake?

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

Hans de Goede  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #4 from Hans de Goede  2011-04-30 15:09:02 EDT ---
(In reply to comment #3)
> I see no SCM request to process here.  Perhaps the wrong flag was set by
> mistake?

My bad, I meant to set fedora-review to ?, same for bug 700833, don't know how
this happened...

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

--- Comment #5 from Golo Fuchert  2011-05-03 15:33:38 EDT ---
Uhm, could you please read the description again?

"Pal is command-line calendar program that can keep track of events pal is a
command-line calendar program for Unix/Linux systems that can keep track of
events. [...]"

I think this should really be corrected (e.g. remove the first part until "pal
is a...").

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

--- Comment #6 from Hans de Goede  2011-05-04 03:18:53 EDT ---
(In reply to comment #5)
> Uhm, could you please read the description again?
>
> "Pal is command-line calendar program that can keep track of events pal is a
> command-line calendar program for Unix/Linux systems that can keep track of
> events. [...]"
>
> I think this should really be corrected (e.g. remove the first part until "pal
> is a...").

Agreed, Martin you can add that to the needswork list...

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

--- Comment #7 from Martin Cermak  2011-05-06 04:30:58 EDT ---
I belive pal-0.4.3-2 contains all the requested fixes:

Spec URL: http://www.physics.muni.cz/~cermak/pal-0.4.3-2/pal.spec
SRPM URL:
http://www.physics.muni.cz/~cermak/pal-0.4.3-2/pal-0.4.3-2.fc14.src.rpm

+ rpmlint pal.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

+ rpmlint pal-0.4.3-2.fc14.src.rpm
pal.src: W: spelling-error %description -l en_US gcal -> gal, cal, goal
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ rpmlint pal-debuginfo-0.4.3-2.fc14.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ rpmlint pal-0.4.3-2.fc14.x86_64.rpm
pal.x86_64: W: spelling-error %description -l en_US gcal -> gal, cal, goal
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Hans, please, review my changes.

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

Hans de Goede  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #8 from Hans de Goede  2011-05-06 04:39:29 EDT ---
Looks good now, approved! If you can go and create a fas account (if you've not
done so already) and tell me your fas username, I'll add you to the packager
group and sponsor you, see:
http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

--- Comment #9 from Martin Cermak  2011-05-06 09:11:38 EDT ---
Great, thanks! My fas username is mcermak. What should I do next?

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

--- Comment #10 from Hans de Goede  2011-05-06 09:26:54 EDT ---
Hi,

(In reply to comment #9)
> Great, thanks! My fas username is mcermak. What should I do next?

I've just added you to the packager group and sponsored you, the next steps,
are described here:
http://fedoraproject.org/wiki/PackageMaintainers/Join

The first thing to do is request creation of git and bugzilla modules for your
approved packages, see:
http://fedoraproject.org/wiki/Package_SCM_admin_requests

Note that it may take up to an hour for your newer packager rights to propagate
to all servers, and you won't be able to set the fedora-cvs flag until you've
those rights.

Regards,

Hans

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

Martin Cermak  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #11 from Martin Cermak  2011-05-07 06:38:19 EDT ---
New Package SCM Request
=======================
Package Name: pal
Short Description: Command line calendar that displays holidays and events
Owners: mcermak
Branches: f14 f15
InitialCC: jwrdegoede

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

--- Comment #12 from Jason Tibbitts  2011-05-10 11:36:06 EDT ---
Git done (by process-git-requests).

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

--- Comment #13 from Fedora Update System  2011-05-12 10:23:04 EDT ---
pal-0.4.3-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/pal-0.4.3-2.fc14

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

--- Comment #14 from Fedora Update System  2011-05-12 10:27:29 EDT ---
pal-0.4.3-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/pal-0.4.3-2.fc15

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #15 from Fedora Update System  2011-05-13 19:15:10 EDT ---
pal-0.4.3-2.fc14 has been pushed to the Fedora 14 testing repository.

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

--- Comment #16 from Fedora Update System  2011-05-24 22:54:48 EDT ---
pal-0.4.3-2.fc14 has been pushed to the Fedora 14 stable repository.

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |pal-0.4.3-2.fc14
         Resolution|                            |ERRATA
        Last Closed|                            |2011-05-24 22:54:53

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

--- Comment #17 from Fedora Update System  2011-06-08 19:56:26 EDT ---
pal-0.4.3-2.fc15 has been pushed to the Fedora 15 stable repository.

[Bug 698576] Review Request: pal - Command line calendar that displays holidays and events

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=698576

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|pal-0.4.3-2.fc14            |pal-0.4.3-2.fc15