https://bugzilla.redhat.com/show_bug.cgi?id=1305390
Bug ID: 1305390 Summary: Review Request: dreamchess-tools - DreamChess Tools Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: projects.rg@smart.ms QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raphgro.fedorapeople.org/review/chess/dreamchess/dreamchess-tools.sp... SRPM URL: https://raphgro.fedorapeople.org/review/chess/dreamchess/dreamchess-tools-0-... Description: DreamChess Tools Fedora Account System Username: raphgro
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1305382, 1140403
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1140403 [Bug 1140403] Review Request: dreamchess - open source chess game https://bugzilla.redhat.com/show_bug.cgi?id=1305382 [Bug 1305382] Review Request: tristripper - Triangle stripification (algorithm by Tanguy Fautré)
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rdieter@math.unl.edu Assignee|nobody@fedoraproject.org |rdieter@math.unl.edu Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
--- Comment #1 from Rex Dieter rdieter@math.unl.edu --- 1. SHOULD replace multiline/complicated:
libtoolize --force aclocal autoheader automake --force-missing --add-missing autoconf
with:
autoreconf --force --install
2. FTBFS, checking for SDL_ttf.h... no configure: error: Cannot find SDL_ttf header file
Hrm, trying to figure out what satisfies this (apparently not SDL2_ttf-devel)
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Rex Dieter rdieter@math.unl.edu --- 2. MUST add BuildRequires: SDL_ttf-devel
otherwise,
naming: ok
license: ok
sources: ok c46192e1b07fa437f9ba7467cde3956f dreamchess-tools-f8f32aa6fed41d82b4577dbce6f7eb106a9eb63e.tar.gz
3. scriptlets: NOT ok, remove needless icon scriptlets (package includes no icons)
4. SHOULD improve %description, really no idea what this package is for or what it does.
APPROVED.
(I'll leave the MUST FTBFS fix to you, since it won't build without it)
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
--- Comment #3 from Raphael Groner projects.rg@smart.ms --- Thanks for the review!
For completeness:
Spec URL: https://raphgro.fedorapeople.org/review/chess/dreamchess/dreamchess-tools.sp... SRPM URL: https://raphgro.fedorapeople.org/review/chess/dreamchess/dreamchess-tools-0-...
%changelog * Tue Mar 22 2016 Raphael Groner projects.rg@smart.ms - 0-0.2.20141101gitf8f32aa - add BR: pkgconfig(SDL_ttf), remove icon scriptlets, use autoreconf
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=13428424
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/dreamchess-tools
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- dreamchess-tools-0-0.2.20141101gitf8f32aa.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-062d911117
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- dreamchess-tools-0-0.2.20141101gitf8f32aa.fc23 tristripper-1.10-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0b0250e202
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- dreamchess-tools-0-0.2.20141101gitf8f32aa.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-062d911117
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- dreamchess-tools-0-0.2.20141101gitf8f32aa.fc23, tristripper-1.10-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0b0250e202
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- dreamchess-tools-0-0.2.20141101gitf8f32aa.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-03-27 17:58:11
https://bugzilla.redhat.com/show_bug.cgi?id=1305390
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- dreamchess-tools-0-0.2.20141101gitf8f32aa.fc23, tristripper-1.10-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1305390 Bug 1305390 depends on bug 1305382, which changed state.
Bug 1305382 Summary: Review Request: tristripper - Triangle stripification (algorithm by Tanguy Fautre) https://bugzilla.redhat.com/show_bug.cgi?id=1305382
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
package-review@lists.fedoraproject.org