[Bug 2279791] New: Review Request: python-pymarkdownlnt - A GitHub Flavored Markdown compliant Markdown linter
https://bugzilla.redhat.com/show_bug.cgi?id=2279791
Bug ID: 2279791 Summary: Review Request: python-pymarkdownlnt - A GitHub Flavored Markdown compliant Markdown linter Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: gwync@protonmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
SRPM:https://fedorapeople.org/~limb/review/python-pymarkdownlnt/python-pymarkdown... is primarily a Markdown linter. To ensure that the Markdown linting is conducted with the highest attention to detail, our linting rules analyze the tokens produced by the project's own Markdown parser. The project's Markdown parser aims to be highly compliant to both the GitHub Flavored Markdown specification and the CommonMark specification.
https://bugzilla.redhat.com/show_bug.cgi?id=2279791
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Cannot find any valid SRPM URL for this ticket. Common causes are:
- You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2279791
Gwyn Ciesla gwync@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
SRPM:https://fedorapeople.org/~limb/review/python-pymarkdownlnt/python-pymarkdown... SPEC:https://fedorapeople.org/~limb/review/python-pymarkdownlnt/python-pymarkdown...
Description: PyMarkdown is primarily a Markdown linter. To ensure that the Markdown linting is conducted with the highest attention to detail, our linting rules analyze the tokens produced by the project's own Markdown parser. The project's Markdown parser aims to be highly compliant to both the GitHub Flavored Markdown specification and the CommonMark specification.
https://bugzilla.redhat.com/show_bug.cgi?id=2279791
Gwyn Ciesla gwync@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2279792 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2279792 [Bug 2279792] Review Request: python-application-properties - A simple, easy to use, unified manner of accessing program properties
https://bugzilla.redhat.com/show_bug.cgi?id=2279791
Gwyn Ciesla gwync@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2279794
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2279794 [Bug 2279794] Review Request: python-columnar - A tool for printing data in a columnar format
https://bugzilla.redhat.com/show_bug.cgi?id=2279791
Gwyn Ciesla gwync@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
SRPM:https://fedorapeople.org/~limb/review/python-pymarkdownlnt/python-pymarkdown... SPEC:https://fedorapeople.org/~limb/review/python-pymarkdownlnt/python-pymarkdown...
Description: PyMarkdown is primarily a Markdown linter. To ensure that the Markdown linting is conducted with the highest attention to detail, our linting rules analyze the tokens produced by the project's own Markdown parser. The project's Markdown parser aims to be highly compliant to both the GitHub Flavored Markdown specification and the CommonMark specification.
Product: Fedora Version: rawhide Component: Package Review
Gwyn Ciesla gwync@protonmail.com has canceled Package Review package-review@lists.fedoraproject.org's request for Gwyn Ciesla gwync@protonmail.com's needinfo: Bug 2279791: Review Request: python-pymarkdownlnt - A GitHub Flavored Markdown compliant Markdown linter https://bugzilla.redhat.com/show_bug.cgi?id=2279791
https://bugzilla.redhat.com/show_bug.cgi?id=2279791
Gwyn Ciesla gwync@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(gwync@protonmail. | |com) |
https://bugzilla.redhat.com/show_bug.cgi?id=2279791
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- SRPM:https://fedorapeople.org/~limb/review/python-pymarkdownlnt/python-pymarkdown... SPEC:https://fedorapeople.org/~limb/review/python-pymarkdownlnt/python-pymarkdown...
https://bugzilla.redhat.com/show_bug.cgi?id=2279791 Bug 2279791 depends on bug 2279792, which changed state.
Bug 2279792 Summary: Review Request: python-application-properties - A simple, easy to use, unified manner of accessing program properties https://bugzilla.redhat.com/show_bug.cgi?id=2279792
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2279791 Bug 2279791 depends on bug 2279794, which changed state.
Bug 2279794 Summary: Review Request: python-columnar - A tool for printing data in a columnar format https://bugzilla.redhat.com/show_bug.cgi?id=2279794
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2279791
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@emailplus.org
--- Comment #4 from Benson Muite benson_muite@emailplus.org --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2279791
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://github.com/jackdewi | |nter/pymarkdown
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9103714 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2279791
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org Flags| |fedora-review?
--- Comment #6 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated", "*No copyright* MIT License". 216 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python- pymarkdownlint/2279791-python-pymarkdownlnt/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14, /usr/lib/python3.14/site-packages [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9476 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-pymarkdownlnt-0.9.29-1.fc44.noarch.rpm python-pymarkdownlnt-0.9.29-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpovdbmujj')] checks: 32, packages: 2
python-pymarkdownlnt.src: E: spelling-error ('linter', 'Summary(en_US) linter -> liner, liter, inter') python-pymarkdownlnt.src: E: spelling-error ('linter', '%description -l en_US linter -> liner, liter, inter') python3-pymarkdownlnt.noarch: E: spelling-error ('linter', 'Summary(en_US) linter -> liner, liter, inter') python3-pymarkdownlnt.noarch: E: spelling-error ('linter', '%description -l en_US linter -> liner, liter, inter') python3-pymarkdownlnt.noarch: W: no-manual-page-for-binary pymarkdown python3-pymarkdownlnt.noarch: W: no-manual-page-for-binary pymarkdownlnt python3-pymarkdownlnt.noarch: W: files-duplicate /usr/bin/pymarkdownlnt /usr/bin/pymarkdown 2 packages and 0 specfiles checked; 4 errors, 3 warnings, 7 filtered, 4 badness; has taken 1.4 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
python3-pymarkdownlnt.noarch: E: spelling-error ('linter', 'Summary(en_US) linter -> liner, liter, inter') python3-pymarkdownlnt.noarch: E: spelling-error ('linter', '%description -l en_US linter -> liner, liter, inter') python3-pymarkdownlnt.noarch: W: no-manual-page-for-binary pymarkdown python3-pymarkdownlnt.noarch: W: no-manual-page-for-binary pymarkdownlnt python3-pymarkdownlnt.noarch: W: files-duplicate /usr/bin/pymarkdownlnt /usr/bin/pymarkdown 1 packages and 0 specfiles checked; 2 errors, 3 warnings, 3 filtered, 2 badness; has taken 0.9 s
Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/pymarkdownlnt/pymarkdownlnt... : CHECKSUM(SHA256) this package : cfa37fe778fbaa11714bcc617e90f7293c628cfadce9c2ec3ea89d9b24aca086 CHECKSUM(SHA256) upstream package : cfa37fe778fbaa11714bcc617e90f7293c628cfadce9c2ec3ea89d9b24aca086
Requires -------- python3-pymarkdownlnt (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.14dist(application-properties) python3.14dist(columnar) python3.14dist(typing-extensions) python3dist(application-properties) python3dist(columnar) python3dist(setuptools) python3dist(typing-extensions)
Provides -------- python3-pymarkdownlnt: python-pymarkdownlnt python3-pymarkdownlnt python3.14-pymarkdownlnt python3.14dist(pymarkdownlnt) python3dist(pymarkdownlnt)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2279791 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: Java, Perl, PHP, fonts, C/C++, Haskell, SugarActivity, R, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comments: a) latest release 0.9.32 seems to need python3-application-properties > 0.9 but Fedora currently has 0.8 https://packages.fedoraproject.org/pkgs/python-application-properties/python... b) Upstream seems to use pytest to run tests: https://github.com/jackdewinter/pymarkdown/blob/8510c312755bbb8482d668fddc6c... but this does not work on Fedora Rawhide, unclear if this can be made to work without too much effort. c) The line %license LICENSE.txt is not needed, license is packaged and has appropriate metadata. The python package directories can be obtained by using a macro so consider using: %files -n python3-%{pypi_name} -f %{pyproject_files} %doc README.md %{_bindir}/pymarkdown %{_bindir}/pymarkdownlnt
https://bugzilla.redhat.com/show_bug.cgi?id=2279791
--- Comment #7 from Gwyn Ciesla gwync@protonmail.com --- a. and application-properties 0.9 needs pyjson5. NOT json5 that's already in Fedora, mind you....I'll submit a review for that.
https://bugzilla.redhat.com/show_bug.cgi?id=2279791
--- Comment #8 from Benson Muite benson_muite@emailplus.org --- Ok. Would be helpful to determine why tests do not run when adding %pytest to the check section. Packaging an older release is not blocking, but where possible good to know package functions as desired.
https://bugzilla.redhat.com/show_bug.cgi?id=2279791
Gwyn Ciesla gwync@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2402008
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2402008 [Bug 2402008] Review Request: python-pyjson5 - JSON5 serializer and parser for Python 3 written in Cython.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com