https://bugzilla.redhat.com/show_bug.cgi?id=2007995
Bug ID: 2007995 Summary: Review Request: rust-yansi - Rust terminal color painting library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: jan@baudisch.xyz QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-yansi/rust-yansi.s... Patch URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-yansi/remove-parki... SRPM URL: https://kojipkgs.fedoraproject.org/work/tasks/6308/76326308/rust-yansi-0.5.0... Description: Rust terminal color painting library Fedora Account System Username: janbaudisch
COPR package: https://copr.fedorainfracloud.org/coprs/janbaudisch/rust/package/rust-yansi Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=76326307
https://bugzilla.redhat.com/show_bug.cgi?id=2007995
Jan Baudisch jan@baudisch.xyz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=2007995
Jan Baudisch jan@baudisch.xyz changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-yansi/rust-yansi.s... Patch URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-yansi/remove-parki... SRPM URL: https://git.sr.ht/~janbaudisch/copr-rust/blob/master/rust-yansi/rust-yansi-0... Description: Rust terminal color painting library Fedora Account System Username: janbaudisch
COPR package: https://copr.fedorainfracloud.org/coprs/janbaudisch/rust/package/rust-yansi Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=77947173
https://bugzilla.redhat.com/show_bug.cgi?id=2007995
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |michel@michel-slm.name Assignee|nobody@fedoraproject.org |michel@michel-slm.name Doc Type|--- |If docs needed, set a value Blocks|177841 (FE-NEEDSPONSOR) | Flags| |fedora-review? | |needinfo?(jan@baudisch.xyz)
--- Comment #1 from Michel Alexandre Salim michel@michel-slm.name --- Taking this review (removing the blocker on FE-NEEDSPONSOR since you're sponsored now!)
One change request: so the %bcond_without you see at the top of the spec as generated by rust2rpm actually controls whether that flag is enabled or not, see https://rpm-software-management.github.io/rpm/manual/conditionalbuilds.html
so:
%bcond_without check means %{with check} by default, unless compiled --without check
If the Rust compiler we have is too old for the test suite, then you just flip that definition to be %bcond_with check, and put a comment above it, no need to comment out the entire %check section
This makes it easy to test locally if you think checks can be enabled again:
fedpkg srpm (or rpmbuild -bs rust-yansi.spec) mock /path/to/rust-yansi-*.src.rpm --with check
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=2007995
Jan Baudisch jan@baudisch.xyz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jan@baudisch.xyz) |
--- Comment #2 from Jan Baudisch jan@baudisch.xyz --- Thank you for pointing this out. I changed it and updated the spec and srpm.
https://bugzilla.redhat.com/show_bug.cgi?id=2007995
Jan Baudisch jan@baudisch.xyz changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |CLOSED Last Closed| |2022-05-03 21:21:51
--- Comment #3 from Jan Baudisch jan@baudisch.xyz ---
*** This bug has been marked as a duplicate of bug 2079341 ***
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com