[Bug 1065058] New: Review Request: textql - Execute SQL against structured text like CSV or TSV

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1065058

Bug ID: 1065058
           Summary: Review Request: textql - Execute SQL against
                    structured text like CSV or TSV
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: http://data.fabiolocati.com/fedora/textql/textql.spec
SRPM URL:
http://data.fabiolocati.com/fedora/textql/textql-0.0-1.gita7fbbe2.fc20.src.r...
Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=6527905
Description: This tool allows you to run sql-like queries on structured files
like CSV and TSV.
Fedora Account System Username: fale

This is my second fedora package (1st one is at bug 1062942) from scratch and
third work on fedora packages (there is also bug 1062668) and I'm looking for a
sponsor.

[Bug 1065058] Review Request: textql - Execute SQL against structured text like CSV or TSV

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1065058

Fabio Alessandro Locati  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1065058] Review Request: textql - Execute SQL against structured text like CSV or TSV

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1065058

Mukundan Ragavan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Mukundan Ragavan  ---
Some quick comments -

You can drop

* BuildRequires: gcc
* BuildRequires: gcc-go

You package builds for me in mock. Try building the binary rpm and check for
errors using rpmlint.

$ rpmlint textql.spec /var/lib/mock/fedora-rawhide-x86_64/result/textql-*rpm
textql.spec: W: invalid-url Source0: textql-a7fbbe2.tar
textql.src: W: spelling-error %description -l en_US sql -> sq, sol, sq l
textql.src: W: invalid-url Source0: textql-a7fbbe2.tar
textql.x86_64: W: spelling-error %description -l en_US sql -> sq, sol, sq l
textql.x86_64: W: no-manual-page-for-binary textql
textql-debuginfo.x86_64: E: debuginfo-without-sources
3 packages and 1 specfiles checked; 1 errors, 5 warnings.

debuginfo-without-source is particularly a problem.
 -
https://fedoraproject.org/wiki/Common_Rpmlint_issues#debuginfo-without-sourc...

Hope this helps.

[Bug 1065058] Review Request: textql - Execute SQL against structured text like CSV or TSV

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1065058

--- Comment #2 from Fabio Alessandro Locati  ---
Hi :),

Thanks for the comment. I've ignored the error since another package is created
(textql-debuginfo-0.0-1.gita7fbbe2.fc20.i686.rpm) which contains all debug
files:

/usr/lib/debug
/usr/lib/debug/.build-id
/usr/lib/debug/.build-id/30
/usr/lib/debug/.build-id/30/f803f80c1250509f25a3984b7c5084bfd5592f
/usr/lib/debug/.build-id/30/f803f80c1250509f25a3984b7c5084bfd5592f.debug
/usr/lib/debug/usr
/usr/lib/debug/usr/bin
/usr/lib/debug/usr/bin/textql.debug

I'll move the debug part in the core package and drop the second one :).

[Bug 1065058] Review Request: textql - Execute SQL against structured text like CSV or TSV

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1065058

Christopher Meng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Christopher Meng  ---
You'd better wait for a while, go packaging guideline is being developed:

https://fedorahosted.org/fpc/ticket/382

(In reply to Fabio Alessandro Locati from comment #2)
> Hi :),
>
> Thanks for the comment. I've ignored the error since another package is
> created (textql-debuginfo-0.0-1.gita7fbbe2.fc20.i686.rpm) which contains all
> debug files:
>
> /usr/lib/debug
> /usr/lib/debug/.build-id
> /usr/lib/debug/.build-id/30
> /usr/lib/debug/.build-id/30/f803f80c1250509f25a3984b7c5084bfd5592f
> /usr/lib/debug/.build-id/30/f803f80c1250509f25a3984b7c5084bfd5592f.debug
> /usr/lib/debug/usr
> /usr/lib/debug/usr/bin
> /usr/lib/debug/usr/bin/textql.debug
>
> I'll move the debug part in the core package and drop the second one :).

Please nuke the debuginfo, it's nonsense to include them in the main package.

golang packages should have no debuginfo.

[Bug 1065058] Review Request: textql - Execute SQL against structured text like CSV or TSV

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1065058

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]
              Flags|                            |needinfo?([e-mail])

--- Comment #4 from Miroslav Suchý  ---
ping. What is the situation here? Do you want to continue or drop this one?

[Bug 1065058] Review Request: textql - Execute SQL against structured text like CSV or TSV

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1065058

Fabio Alessandro Locati  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail])  |

--- Comment #5 from Fabio Alessandro Locati  ---
In the mean time a lot of polices on GOLANG has been polished, and therefore
I've re-created the SPEC from scratch.

SPEC: https://fale.fedorapeople.org/rpms/golang-github-dinedal-textql.spec
SRPM:
https://fale.fedorapeople.org/rpms/golang-github-dinedal-textql-2.0.3-1.fc24...
KOJI: http://koji.fedoraproject.org/koji/taskinfo?taskID=15115062

[Bug 1065058] Review Request: textql - Execute SQL against structured text like CSV or TSV

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1065058

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |

--- Comment #6 from Parag AN(पराग)  ---
Just found this https://bugzilla.redhat.com/show_bug.cgi?id=1062942#c25 and
according to that this review should not block for FE-NEEDSPONSOR queue.

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1065058] Review Request: textql - Execute SQL against structured text like CSV or TSV

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1065058

--- Comment #7 from Fabio Alessandro Locati  ---
That is true. I forgot to remove the blocking status from this repo when I got
accepted as a packager. Good catch Parag :) and thanks!