[Bug 2176394] New: Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

Bug ID: 2176394
           Summary: Review Request: xine-ui - A skinned xlib-based gui for
                    xine-lib
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://www.bachelot.org/fedora/SPECS/xine-ui.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/xine-ui-0.99.14-1.fc39.src.rpm
Description: xine-ui is the traditional, skinned GUI for xine-lib

Fedora Account System Username: xavierb

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

Xavier Bachelot  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |[e-mail]

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

Jakub Kadlčík  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.xine-project.org
                   |                            |/

--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5613863
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review?

--- Comment #2 from Neal Gompa  ---
Taking this review.

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

--- Comment #3 from Neal Gompa  ---
Initial spec review:
> %{!?_without_caca:BuildRequires:  libcaca-devel}
> %{!?_without_lirc:BuildRequires:  lirc-devel}

We can drop the conditional goop here since it's available everywhere xine-lib
is (EPEL9 and Fedora)
> %if 0%{!?_without_lirc}
> export LIRC_CFLAGS="-llirc_client"
> export LIRC_LIBS="-llirc_client"
> %endif

Ditto for here too.
> %if 0%{?rhel} && 0%{?rhel} < 8
> %post
> # Mime type
> update-desktop-database &> /dev/null || :
> update-mime-database %{_datadir}/mime &> /dev/null || :
> # Icon cache
> touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
>
> %postun
> # Mime type
> update-desktop-database &> /dev/null || :
> update-mime-database %{_datadir}/mime &> /dev/null || :
> # Icon cache
> if [ $1 -eq 0 ] ; then
>     touch --no-create %{_datadir}/icons/hicolor &>/dev/null
>     gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> fi
>
> %posttrans
> gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> %endif

We can drop all this since this package can't be built on anything older than
EPEL 9.
> %{!?_without_caca:%{_bindir}/cacaxine}

We can drop the conditional goop here since it's available everywhere xine-lib
is (EPEL9 and Fedora)

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

--- Comment #4 from Neal Gompa  ---
> It also contains the %{!?_without_caca:color ascii art and} framebuffer version%{!?_without_caca:s}.

One more of the conditional goop that can be dropped too.

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

--- Comment #5 from Xavier Bachelot  ---
Thanks Neal, all (and more) fixed:
- Use SPDX License: tag
- Drop useless conditionals
- Drop useless comments
- Add EL7 cond for %%post/%%postun
- Escape unescaped %% in %%changelog
- Drop very old Obsoletes:/Provides: for xine/xine-skins

Spec URL: https://www.bachelot.org/fedora/SPECS/xine-ui.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/xine-ui-0.99.14-2.fc39.src.rpm

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

--- Comment #6 from Jakub Kadlčík  ---
Created attachment 1949075
  --> https://bugzilla.redhat.com/attachment.cgi?id=1949075&action=edit
The .spec file difference from Copr build 5613863 to 5615144

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

--- Comment #7 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5615144
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

--- Comment #8 from Xavier Bachelot  ---
Fixed skins URLs.

Spec URL: https://www.bachelot.org/fedora/SPECS/xine-ui.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/xine-ui-0.99.14-3.fc39.src.rpm

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

--- Comment #9 from Jakub Kadlčík  ---
Created attachment 1949132
  --> https://bugzilla.redhat.com/attachment.cgi?id=1949132&action=edit
The .spec file difference from Copr build 5615144 to 5615532

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

--- Comment #10 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5615532
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

--- Comment #11 from Neal Gompa  ---
It probably makes sense to drop all the EL7 specific stuff, since we don't have
xine-lib in EPEL7 (or even EPEL8).

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

--- Comment #12 from Xavier Bachelot  ---
Sure, but xine-lib still lives in RPM Fusion for EL7 and EL8, so I'd like to
keep the conditionals to be able to keep the spec synch'ed across branches.

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #13 from Neal Gompa  ---
Okay, fine with me.

Everything else looks good here.

PACKAGE APPROVED.

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

--- Comment #14 from Xavier Bachelot  ---
Thanks Neal !

Request for unretirement: https://pagure.io/releng/issue/11329

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

Dominik 'Rathann' Mierzejewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Link ID|                            |Fedora Pagure
                   |                            |releng/issue/11329

--- Comment #15 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Xavier Bachelot from comment #14)
> Thanks Neal !
>
> Request for unretirement: https://pagure.io/releng/issue/11329

Unretirement was done. You can go ahead and build this.

[Bug 2176394] Review Request: xine-ui - A skinned xlib-based gui for xine-lib

https://bugzilla.redhat.com/show_bug.cgi?id=2176394

Xavier Bachelot  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |CURRENTRELEASE
             Status|POST                        |CLOSED
        Last Closed|                            |2023-09-01 13:04:30