[Bug 979332] New: Review Request: <main package name here> - <short summary here>

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=979332

Bug ID: 979332
           Summary: Review Request: <main package name here> - <short
                    summary here>
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail],
                    [e-mail]

Spec URL: http://jmlich.fedorapeople.org/libpqtypes.spec
SRPM URL: http://jmlich.fedorapeople.org/libpqtypes-1.5.1-1.fc20.src.rpm
Description: Software extension to the PostgreSQL libpq interface
Fedora Account System Username: jmlich

[Bug 979332] Review Request: libpqtypes - Software extension to the PostgreSQL libpq interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=979332

Jozef Mlich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: <main       |Review Request: libpqtypes
                   |package name here> - <short |- Software extension to the
                   |summary here>               |PostgreSQL libpq interface

[Bug 979332] Review Request: libpqtypes - Software extension to the PostgreSQL libpq interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=979332

--- Comment #1 from Jozef Mlich  ---
This is my first package and you need a sponsor.
I did my homework http://koji.fedoraproject.org/koji/taskinfo?taskID=5553430

[Bug 979332] Review Request: libpqtypes - Software extension to the PostgreSQL libpq interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=979332

Volker Fröhlich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Blocks|                            |177841 (FE-NEEDSPONSOR)

[Bug 979332] Review Request: libpqtypes - Software extension to the PostgreSQL libpq interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=979332

--- Comment #2 from Volker Fröhlich  ---
The .so symlink belongs into the devel sub-package.

Please include AUTHORS and ChangeLog as documentation.

Commonly the %package and %description sections are all before the prep
section.

Your build appends -O3 to the Fedora flags. To my knowledge, that results in O3
being used.

The group seems wrong to me, as this is no application.

You've got two percent signs in from of description devel!

Use the name and version macro in Source0 and potentially in the files section.

rm -rf $RPM_BUILD_ROOT is obsolete and can be removed.

[Bug 979332] Review Request: libpqtypes - Software extension to the PostgreSQL libpq interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=979332

Jozef Mlich  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |

--- Comment #3 from Jozef Mlich  ---
I am already member of "Fedora Packager GIT Commit Group" so I do not need a
sponsor.

[Bug 979332] Review Request: libpqtypes - Software extension to the PostgreSQL libpq interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=979332

--- Comment #4 from Volker Fröhlich  ---
(In reply to Jozef Mlich from comment #1)
> This is my first package and you need a sponsor.

What's that about then?

I have no idea what group that is, but I can't see it via FAS.

[Bug 979332] Review Request: libpqtypes - Software extension to the PostgreSQL libpq interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=979332

--- Comment #5 from Jozef Mlich  ---
(In reply to Volker Fröhlich from comment #4)
> (In reply to Jozef Mlich from comment #1)
> > This is my first package and you need a sponsor.
>
> What's that about then?
>
> I have no idea what group that is, but I can't see it via FAS.

I am sorry, I am not very familiar with all processes in Fedora. I followed
tutorial 'how to add new package into fedora'. My mentor in Red Hat explained
me, I do not need mentor any more.

I need just review for package.

(In reply to Volker Fröhlich from comment #2)
> The .so symlink belongs into the devel sub-package.
>
> Please include AUTHORS and ChangeLog as documentation.
>
> Commonly the %package and %description sections are all before the prep
> section.
>
> The group seems wrong to me, as this is no application.
>
> You've got two percent signs in from of description devel!
>
> rm -rf $RPM_BUILD_ROOT is obsolete and can be removed.

These should be fixed right now.
> Your build appends -O3 to the Fedora flags. To my knowledge, that results in
> O3 being used.

I have sent this request to upstream developer.
> Use the name and version macro in Source0 and potentially in the files
> section.

The URL (in Source 0) depends also on pgfoundry release_id. I am not sure if is
good practice to use here this macro, because you can get wrong url afterwards.

[Bug 979332] Review Request: libpqtypes - Software extension to the PostgreSQL libpq interface

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=979332

Michael Schwendt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]

--- Comment #6 from Michael Schwendt  ---
Your sponsor needs to be the one to review and approve your first package
review request. https://fedoraproject.org/wiki/Package_Review_Process#Reviewer

I've looked up your account in FAS and found Dan Horák is your sponsor.

This is no full review, just a very brief look at the spec file:
> Group: Development/Libraries

"System Environment/Libraries" has been the group for run-time library base
packages since many years.
> Requires: postgresql%{?_isa} >= 8.4

https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
> %changelog

https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

[Bug 979332] Review Request: libpqtypes - Software extension to the PostgreSQL libpq interface

https://bugzilla.redhat.com/show_bug.cgi?id=979332

Dan Horák  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |WONTFIX
        Last Closed|                            |2018-01-22 03:53:36