Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request:fedora-ksplice - Script Collection for Using KSplice on Fedora Linux
https://bugzilla.redhat.com/show_bug.cgi?id=466147
Summary: Review Request:fedora-ksplice - Script Collection for Using KSplice on Fedora Linux Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jochen@herr-schmitt.de QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://www.herr-schmitt.de/pub/fedora-ksplice/fedora-ksplice.spec SRPM URL: http://www.herr-schmitt.de/pub/fedora-ksplice/fedora-ksplice-0.1-1.fc9.src.r... Description: fedora-ksplice is a collection of shell scripts to use ksplice in a Fedora environment.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466147
--- Comment #1 from Jochen Schmitt jochen@herr-schmitt.de 2008-10-30 12:24:54 EDT --- New upstream release:
Spec URL: http://www.herr-schmitt.de/pub/fedora-ksplice/fedora-ksplice.spec SRPM URL: http://www.herr-schmitt.de/pub/fedora-ksplice/fedora-ksplice-0.2-1.fc9.src.r...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466147
--- Comment #2 from Jochen Schmitt jochen@herr-schmitt.de 2008-11-04 13:05:24 EDT --- New upstream release:
Spec URL: http://www.herr-schmitt.de/pub/fedora-ksplice/fedora-ksplice.spec SRPM URL: http://www.herr-schmitt.de/pub/fedora-ksplice/fedora-ksplice-0.3-1.fc9.src.r...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466147
--- Comment #3 from Jason Tibbitts tibbs@math.uh.edu 2008-11-06 14:05:23 EDT --- The two included scripts, which seem to be the meat of the package, are clearly under GPLv2, yet COPYING is GPLv3. This seems a bit confused. Legally we're supposed to take the versioning from the licenses on the actual code, so GPLv2 is correct here.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466147
--- Comment #4 from Jochen Schmitt jochen@herr-schmitt.de 2008-11-06 14:44:12 EDT --- Thank you for you comment. The COPYING file was created by the autotools, but I have noew corrected it on
svn://fedorahosted.org/fedora-ksplice/trunk
Because I have create some new enhancement/bugfixes, I will create a new release next week.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466147
--- Comment #5 from Jochen Schmitt jochen@herr-schmitt.de 2008-11-09 15:47:34 EDT --- New upstream release:
Spec URL: http://www.herr-schmitt.de/pub/fedora-ksplice/fedora-ksplice.spec SRPM URL: http://www.herr-schmitt.de/pub/fedora-ksplice/fedora-ksplice-0.4-1.fc9.src.r...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466147
--- Comment #6 from Jochen Schmitt jochen@herr-schmitt.de 2008-12-15 11:21:56 EDT --- New upstream release:
Spec URL: http://www.herr-schmitt.de/pub/fedora-ksplice/fedora-ksplice.spec SRPM URL: http://www.herr-schmitt.de/pub/fedora-ksplice/fedora-ksplice-0.5-1.fc10.src....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466147
--- Comment #7 from Jochen Schmitt jochen@herr-schmitt.de 2009-02-18 15:56:33 EDT --- New upstream release:
Spec URL: http://www.herr-schmitt.de/pub/fedora-ksplice/fedora-ksplice.spec SRPM URL: http://www.herr-schmitt.de/pub/fedora-ksplice/fedora-ksplice-0.5-2.fc10.src....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466147
Stefan Posdzich cheekyboinc@foresightlinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cheekyboinc@foresightlinux. | |org Flag| |fedora-review+
--- Comment #8 from Stefan Posdzich cheekyboinc@foresightlinux.org 2009-02-18 16:11:07 EDT --- ++ REVIEW ++
MUST: rpmlint output | GOOD
rpmlint fedora-ksplice-0.5-1.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint fedora-ksplice-0.5-1.fc10.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
MUST: package must be named according to Package Naming Guidelines | GOOD
MUST: The spec file name must match the base package | GOOD
MUST: The package must meet the Packaging Guidelines | GOOD
MUST: licensed with a Fedora approved license | GOOD
License: GPLv3
MUST: License field must match the actual license | GOOD
MUST: Docs (with license) | GOOD
AUTHORS COPYING README
MUST: The spec file must be written in American English | GOOD
MUST: The spec file for the package MUST be legible | GOOD
MUST: md5sum | GOOD
src.rpm: 8b6a7bbc5a1d14bd53b62fd405056fc2 fedora-ksplice-0.5.tar.gz upstream: 8b6a7bbc5a1d14bd53b62fd405056fc2 fedora-ksplice-0.5.tar.gz
MUST: compile and build on at least one primary architecture. | GOOD
http://koji.fedoraproject.org/koji/taskinfo?taskID=1136624
MUST: All build dependencies must be listed in BuildRequires | GOOD
MUST: not contain any duplicate files in the %files listing | GOOD
MUST: Permissions on files must be set properly | GOOD
MUST: Package is working | GOOD
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466147
Jochen Schmitt jochen@herr-schmitt.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #9 from Jochen Schmitt jochen@herr-schmitt.de 2009-02-18 16:13:21 EDT --- New Package CVS Request ======================= Package Name: fedora-ksplice Short Description: Script Collection for Using KSplice on Fedora Linux Owners: s4504kr Branches: F-9 F-10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466147
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |cheekyboinc@foresightlinux. | |org Flag|fedora-cvs? |fedora-cvs+
--- Comment #10 from Kevin Fenzi kevin@tummy.com 2009-02-19 15:17:47 EDT --- The upstream README says GPLv3 or later... shouldn't the tag in the spec be 'GPLv3+'?
cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=466147
Jochen Schmitt jochen@herr-schmitt.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
package-review@lists.fedoraproject.org