[Bug 2181779] New: Review Request: rust-trust-dns-client - Trust-DNS is a safe and secure DNS library
https://bugzilla.redhat.com/show_bug.cgi?id=2181779
Bug ID: 2181779 Summary: Review Request: rust-trust-dns-client - Trust-DNS is a safe and secure DNS library Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-trust-dns-client.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-trust-dns-client-0.22.0-1.fc38.src....
Description: Trust-DNS is a safe and secure DNS library. This is the Client library with DNSec support. DNSSec with NSEC validation for negative records, is complete. The client supports dynamic DNS with SIG0 authenticated requests, implementing easy to use high level funtions. Trust-DNS is based on the Tokio and Futures libraries, which means it should be easily integrated into other software that also use those libraries.
Fedora Account System Username: decathorpe
koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=99124970
https://bugzilla.redhat.com/show_bug.cgi?id=2181779
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/tr | |ust-dns-client
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5708628 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2181779
blinxen h-k-81@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |h-k-81@hotmail.com CC| |h-k-81@hotmail.com
--- Comment #2 from blinxen h-k-81@hotmail.com --- Taking this review
General comments:
- Spec file was generated with rust2rpm and edited manually. - All features / dependencies that depend on ring were dropped because of limited architecture support [1]. Should be OK if the features are not required by other crates.
Questions:
- You deactivated the check stage because of a missing `dev-dependency`. Is there a reason why you did not just package the missing dependency?
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License", "Apache License 2.0". 7 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/rust-trust-dns-client/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- trust-dns-client-devel , rust-trust-dns-client+default-devel , rust- trust-dns-client+backtrace-devel , rust-trust-dns-client+dns-over- https-devel , rust-trust-dns-client+dns-over-https-openssl-devel , rust-trust-dns-client+dns-over-native-tls-devel , rust-trust-dns- client+dns-over-openssl-devel , rust-trust-dns-client+dns-over-tls- devel , rust-trust-dns-client+dnssec-devel , rust-trust-dns- client+dnssec-openssl-devel , rust-trust-dns-client+mdns-devel , rust- trust-dns-client+openssl-devel , rust-trust-dns-client+serde-devel , rust-trust-dns-client+serde-config-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: rust-trust-dns-client-devel-0.22.0-1.fc39.noarch.rpm rust-trust-dns-client+default-devel-0.22.0-1.fc39.noarch.rpm rust-trust-dns-client+backtrace-devel-0.22.0-1.fc39.noarch.rpm rust-trust-dns-client+dns-over-https-devel-0.22.0-1.fc39.noarch.rpm
rust-trust-dns-client+dns-over-https-openssl-devel-0.22.0-1.fc39.noarch.rpm
rust-trust-dns-client+dns-over-native-tls-devel-0.22.0-1.fc39.noarch.rpm rust-trust-dns-client+dns-over-openssl-devel-0.22.0-1.fc39.noarch.rpm rust-trust-dns-client+dns-over-tls-devel-0.22.0-1.fc39.noarch.rpm rust-trust-dns-client+dnssec-devel-0.22.0-1.fc39.noarch.rpm rust-trust-dns-client+dnssec-openssl-devel-0.22.0-1.fc39.noarch.rpm rust-trust-dns-client+mdns-devel-0.22.0-1.fc39.noarch.rpm rust-trust-dns-client+openssl-devel-0.22.0-1.fc39.noarch.rpm rust-trust-dns-client+serde-devel-0.22.0-1.fc39.noarch.rpm rust-trust-dns-client+serde-config-devel-0.22.0-1.fc39.noarch.rpm rust-trust-dns-client-0.22.0-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp07s76em9')] checks: 31, packages: 15
rust-trust-dns-client+backtrace-devel.noarch: W: no-documentation rust-trust-dns-client+default-devel.noarch: W: no-documentation rust-trust-dns-client+dns-over-https-devel.noarch: W: no-documentation rust-trust-dns-client+dns-over-https-openssl-devel.noarch: W: no-documentation rust-trust-dns-client+dns-over-native-tls-devel.noarch: W: no-documentation rust-trust-dns-client+dns-over-openssl-devel.noarch: W: no-documentation rust-trust-dns-client+dns-over-tls-devel.noarch: W: no-documentation rust-trust-dns-client+dnssec-devel.noarch: W: no-documentation rust-trust-dns-client+dnssec-openssl-devel.noarch: W: no-documentation rust-trust-dns-client+mdns-devel.noarch: W: no-documentation rust-trust-dns-client+openssl-devel.noarch: W: no-documentation rust-trust-dns-client+serde-config-devel.noarch: W: no-documentation rust-trust-dns-client+serde-devel.noarch: W: no-documentation 15 packages and 0 specfiles checked; 0 errors, 13 warnings, 0 badness; has taken 0.3 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 14
rust-trust-dns-client+mdns-devel.noarch: W: no-documentation rust-trust-dns-client+dnssec-openssl-devel.noarch: W: no-documentation rust-trust-dns-client+openssl-devel.noarch: W: no-documentation rust-trust-dns-client+default-devel.noarch: W: no-documentation rust-trust-dns-client+dns-over-native-tls-devel.noarch: W: no-documentation rust-trust-dns-client+dns-over-openssl-devel.noarch: W: no-documentation rust-trust-dns-client+dns-over-https-openssl-devel.noarch: W: no-documentation rust-trust-dns-client+dns-over-https-devel.noarch: W: no-documentation rust-trust-dns-client+serde-devel.noarch: W: no-documentation rust-trust-dns-client+serde-config-devel.noarch: W: no-documentation rust-trust-dns-client+dns-over-tls-devel.noarch: W: no-documentation rust-trust-dns-client+dnssec-devel.noarch: W: no-documentation rust-trust-dns-client+backtrace-devel.noarch: W: no-documentation 14 packages and 0 specfiles checked; 0 errors, 13 warnings, 0 badness; has taken 0.1 s
Source checksums ---------------- https://crates.io/api/v1/crates/trust-dns-client/0.22.0/download#/trust-dns-... : CHECKSUM(SHA256) this package : 6c408c32e6a9dbb38037cece35740f2cf23c875d8ca134d33631cec83f74d3fe CHECKSUM(SHA256) upstream package : 6c408c32e6a9dbb38037cece35740f2cf23c875d8ca134d33631cec83f74d3fe
Requires -------- rust-trust-dns-client-devel (rpmlib, GLIBC filtered): (crate(cfg-if/default) >= 1.0.0 with crate(cfg-if/default) < 2.0.0~) (crate(data-encoding/default) >= 2.2.0 with crate(data-encoding/default) < 3.0.0~) (crate(futures-channel) >= 0.3.5 with crate(futures-channel) < 0.4.0~) (crate(futures-channel/std) >= 0.3.5 with crate(futures-channel/std) < 0.4.0~) (crate(futures-util) >= 0.3.5 with crate(futures-util) < 0.4.0~) (crate(futures-util/std) >= 0.3.5 with crate(futures-util/std) < 0.4.0~) (crate(lazy_static/default) >= 1.2.0 with crate(lazy_static/default) < 2.0.0~) (crate(radix_trie/default) >= 0.2.0 with crate(radix_trie/default) < 0.3.0~) (crate(rand/default) >= 0.8.0 with crate(rand/default) < 0.9.0~) (crate(thiserror/default) >= 1.0.20 with crate(thiserror/default) < 2.0.0~) (crate(time/default) >= 0.3.0 with crate(time/default) < 0.4.0~) (crate(tokio/default) >= 1.0.0 with crate(tokio/default) < 2.0.0~) (crate(tokio/rt) >= 1.0.0 with crate(tokio/rt) < 2.0.0~) (crate(tracing/default) >= 0.1.30 with crate(tracing/default) < 0.2.0~) (crate(trust-dns-proto/default) >= 0.22.0 with crate(trust-dns-proto/default) < 0.23.0~) cargo
rust-trust-dns-client+default-devel (rpmlib, GLIBC filtered): cargo crate(trust-dns-client)
rust-trust-dns-client+backtrace-devel (rpmlib, GLIBC filtered): (crate(trust-dns-proto/backtrace) >= 0.22.0 with crate(trust-dns-proto/backtrace) < 0.23.0~) cargo crate(trust-dns-client)
rust-trust-dns-client+dns-over-https-devel (rpmlib, GLIBC filtered): (crate(trust-dns-proto/dns-over-https) >= 0.22.0 with crate(trust-dns-proto/dns-over-https) < 0.23.0~) cargo crate(trust-dns-client)
rust-trust-dns-client+dns-over-https-openssl-devel (rpmlib, GLIBC filtered): cargo crate(trust-dns-client) crate(trust-dns-client/dns-over-https) crate(trust-dns-client/dns-over-openssl)
rust-trust-dns-client+dns-over-native-tls-devel (rpmlib, GLIBC filtered): (crate(trust-dns-proto/dns-over-native-tls) >= 0.22.0 with crate(trust-dns-proto/dns-over-native-tls) < 0.23.0~) cargo crate(trust-dns-client) crate(trust-dns-client/dns-over-tls)
rust-trust-dns-client+dns-over-openssl-devel (rpmlib, GLIBC filtered): cargo crate(trust-dns-client) crate(trust-dns-client/dns-over-tls) crate(trust-dns-client/dnssec-openssl) crate(trust-dns-client/openssl)
rust-trust-dns-client+dns-over-tls-devel (rpmlib, GLIBC filtered): cargo crate(trust-dns-client)
rust-trust-dns-client+dnssec-devel (rpmlib, GLIBC filtered): (crate(trust-dns-proto/dnssec) >= 0.22.0 with crate(trust-dns-proto/dnssec) < 0.23.0~) cargo crate(trust-dns-client)
rust-trust-dns-client+dnssec-openssl-devel (rpmlib, GLIBC filtered): (crate(trust-dns-proto/dnssec-openssl) >= 0.22.0 with crate(trust-dns-proto/dnssec-openssl) < 0.23.0~) cargo crate(trust-dns-client) crate(trust-dns-client/dnssec) crate(trust-dns-client/openssl)
rust-trust-dns-client+mdns-devel (rpmlib, GLIBC filtered): (crate(trust-dns-proto/mdns) >= 0.22.0 with crate(trust-dns-proto/mdns) < 0.23.0~) cargo crate(trust-dns-client)
rust-trust-dns-client+openssl-devel (rpmlib, GLIBC filtered): (crate(openssl/default) >= 0.10.0 with crate(openssl/default) < 0.11.0~) (crate(openssl/v102) >= 0.10.0 with crate(openssl/v102) < 0.11.0~) (crate(openssl/v110) >= 0.10.0 with crate(openssl/v110) < 0.11.0~) cargo crate(trust-dns-client)
rust-trust-dns-client+serde-devel (rpmlib, GLIBC filtered): (crate(serde/default) >= 1.0.0 with crate(serde/default) < 2.0.0~) (crate(serde/derive) >= 1.0.0 with crate(serde/derive) < 2.0.0~) cargo crate(trust-dns-client)
rust-trust-dns-client+serde-config-devel (rpmlib, GLIBC filtered): cargo crate(trust-dns-client) crate(trust-dns-client/serde)
Provides -------- rust-trust-dns-client-devel: crate(trust-dns-client) rust-trust-dns-client-devel
rust-trust-dns-client+default-devel: crate(trust-dns-client/default) rust-trust-dns-client+default-devel
rust-trust-dns-client+backtrace-devel: crate(trust-dns-client/backtrace) rust-trust-dns-client+backtrace-devel
rust-trust-dns-client+dns-over-https-devel: crate(trust-dns-client/dns-over-https) rust-trust-dns-client+dns-over-https-devel
rust-trust-dns-client+dns-over-https-openssl-devel: crate(trust-dns-client/dns-over-https-openssl) rust-trust-dns-client+dns-over-https-openssl-devel
rust-trust-dns-client+dns-over-native-tls-devel: crate(trust-dns-client/dns-over-native-tls) rust-trust-dns-client+dns-over-native-tls-devel
rust-trust-dns-client+dns-over-openssl-devel: crate(trust-dns-client/dns-over-openssl) rust-trust-dns-client+dns-over-openssl-devel
rust-trust-dns-client+dns-over-tls-devel: crate(trust-dns-client/dns-over-tls) rust-trust-dns-client+dns-over-tls-devel
rust-trust-dns-client+dnssec-devel: crate(trust-dns-client/dnssec) rust-trust-dns-client+dnssec-devel
rust-trust-dns-client+dnssec-openssl-devel: crate(trust-dns-client/dnssec-openssl) rust-trust-dns-client+dnssec-openssl-devel
rust-trust-dns-client+mdns-devel: crate(trust-dns-client/mdns) rust-trust-dns-client+mdns-devel
rust-trust-dns-client+openssl-devel: crate(trust-dns-client/openssl) rust-trust-dns-client+openssl-devel
rust-trust-dns-client+serde-devel: crate(trust-dns-client/serde) rust-trust-dns-client+serde-devel
rust-trust-dns-client+serde-config-devel: crate(trust-dns-client/serde-config) rust-trust-dns-client+serde-config-devel
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-trust-dns-client --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: R, Python, Perl, fonts, Haskell, Ocaml, PHP, Java, C/C++, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
[1] List of supported architectures: https://github.com/briansmith/ring/blob/main/build.rs#L177
https://bugzilla.redhat.com/show_bug.cgi?id=2181779
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- (In reply to blinxen from comment #2)
Taking this review
General comments:
- Spec file was generated with rust2rpm and edited manually.
- All features / dependencies that depend on ring were dropped because of
limited architecture support [1]. Should be OK if the features are not required by other crates.
Yes, no crates that will depend on trust-dns-client use the features that depend on ring / rustls. These features are also already disabled in other packages for the trust-dns-* crates.
Questions:
- You deactivated the check stage because of a missing `dev-dependency`. Is
there a reason why you did not just package the missing dependency?
I plan to package tracing-subscriber in the near future, but tracing-subscriber also has a few dependencies that are not packaged yet. I haven't gotten around to packaging all of them yet, and since tracing-subscriber is only a dependency for running tests of a few crates, it was not high priority.
However, it turns out that the dependency on tracing-subscriber is entirely unused in this crate (?), so I've just removed it and enabled tests. Updated spec and SRPM is available behind the same links.
https://bugzilla.redhat.com/show_bug.cgi?id=2181779
blinxen h-k-81@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from blinxen h-k-81@hotmail.com ---
However, it turns out that the dependency on tracing-subscriber is entirely unused in this crate
Nice! Maybe this should be reported to upstream
Updated spec and SRPM is available behind the same links
Build is successful locally and the tests are running again.
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=2181779
--- Comment #5 from Fabio Valentini decathorpe@gmail.com ---
Nice! Maybe this should be reported to upstream
True. I'll do that later. Thanks for the review!
https://bugzilla.redhat.com/show_bug.cgi?id=2181779
--- Comment #6 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-trust-dns-client
https://bugzilla.redhat.com/show_bug.cgi?id=2181779
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |ERRATA Last Closed| |2023-03-28 23:13:05
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- Package was imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-0a4eba7151
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com