[Bug 191624] New: Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191624

Summary: Review Request: perl-Test-Expect - Automated driving and
                    testing of terminal-based programs
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Test-Expect.spec
SRPM URL:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-Test-Expect-0.30-1.src.rpm

Description:
Test::Expect is a module for automated driving and testing of
terminal-based programs. It is handy for testing interactive programs
which have a prompt, and is based on the same concepts as the Tcl Expect
tool. As in Expect::Simple, the Expect object is made available for
tweaking.

[Bug 191624] Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191624

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |191623

[Bug 191624] Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191624

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail] |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

[Bug 191624] Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191624

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-05-16 20:05 EST -------
Module::Build is still having trouble in development; I'll review this on FC5. 
(We really should try to help Steve with that.)

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   b22cb4575d910bb2d36e506a958da300  Test-Expect-0.30.tar.gz
   b22cb4575d910bb2d36e506a958da300  Test-Expect-0.30.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (FC5, x86_64), with perl-Expect and perl-Expect-Simple
added.
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=18,  0 wallclock secs ( 0.08 cusr +  0.04 csys =  0.12 CPU)
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED, but note that you won't be able to build on the development branch
until the Module::Build problem gets worked out.

[Bug 191624] Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191624

------- Additional Comments From [e-mail]  2006-05-17 10:47 EST -------
(In reply to comment #1)
> Module::Build is still having trouble in development; I'll review this on FC5. 
> (We really should try to help Steve with that.)

Last saturday I started looking into it but gave up after one hour or so - I
also wasn't able to see why perl(YAML) < 0.49 is being required.  I will try
again later in the day and/or tomorrow.

[Bug 191624] Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191624

Bug 191624 depends on bug 191623, which changed state.

Bug 191623 Summary: Review Request: perl-Expect-Simple - Wrapper around the Expect module
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191623

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 191624] Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191624

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2006-05-18 17:51 EST -------
Thanks for the review.

Imported and built for FC-5 and devel.

[Bug 191624] Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

https://bugzilla.redhat.com/show_bug.cgi?id=191624

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide

[Bug 191624] Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=191624

Mark Chappell  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|                            |fedora-cvs?

--- Comment #4 from Mark Chappell  2010-06-18 12:47:18 EDT ---
https://bugzilla.redhat.com/show_bug.cgi?id=191622 - cweyl implied he's not
interested in EPEL, and at todays EPEL meeting Smooge suggested I should just
put the requests through.

Package Change Request
======================
Package Name: perl-Expect
New Branches: EL-6
Owners: tremble

[Bug 191624] Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=191624

--- Comment #5 from Jason Tibbitts  2010-06-18 12:53:10 EDT ---
Did you mean perl-Test-Expect there?

[Bug 191624] Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=191624

--- Comment #6 from Mark Chappell  2010-06-18 12:58:48 EDT ---
I did, yes, sorry

Package Change Request
======================
Package Name: perl-Test-Expect
New Branches: EL-6
Owners: tremble

[Bug 191624] Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=191624

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #7 from Kevin Fenzi  2010-06-20 21:50:33 EDT ---
cvs done.