[Bug 1379095] New: Review Request: python-entrypoints - Discover and load entry points from installed packages
https://bugzilla.redhat.com/show_bug.cgi?id=1379095
Bug ID: 1379095 Summary: Review Request: python-entrypoints - Discover and load entry points from installed packages Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: nonamedotc@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-entrypo... SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-entrypo...
Description: Entry points are a way for Python packages to advertise objects with some common interface. The most common examples are console_scripts entry points, which define shell commands by identifying a Python function to run.
The entrypoints module contains functions to find and load entry points.
Fedora Account System Username: nonamedotc
https://bugzilla.redhat.com/show_bug.cgi?id=1379095
Mukundan Ragavan nonamedotc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1379096
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1379096 [Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks
https://bugzilla.redhat.com/show_bug.cgi?id=1379095
Mukundan Ragavan nonamedotc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1379094
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1379094 [Bug 1379094] Review Request: python-flit - Simplified packaging of Python modules
https://bugzilla.redhat.com/show_bug.cgi?id=1379095
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |puntogil@libero.it Assignee|nobody@fedoraproject.org |puntogil@libero.it Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1379095
--- Comment #1 from gil cattaneo puntogil@libero.it --- Please, use:
Source0: https://github.com/takluyver/entrypoints/archive/0.2.2/%%7Bsrcname%7D-0.2.2....
https://bugzilla.redhat.com/show_bug.cgi?id=1379095
--- Comment #2 from gil cattaneo puntogil@libero.it --- Please, add -doc/s sub package
%files doc %doc doc/_build/html %license LICENSE
https://bugzilla.redhat.com/show_bug.cgi?id=1379095
--- Comment #3 from gil cattaneo puntogil@libero.it --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1167360 bytes in 62 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation - Binary eggs must be removed in %prep Note: Binary egg files not removed in %prep: ./tests/samples/packages1/baz-0.3.egg ./tests/samples/packages2/qux-0.4.egg See:
http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools... IGNORE. Test resources not packaged
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/gil/1379095 -python-entrypoints/licensecheck.txt
All source files are without license headers. Please, ask to upstream to confirm the licensing of code and/or content/s , and add license headers
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/Li...
[x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.5/site- packages/__pycache__(system-python-libs, python3-pyparsing) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel
===== SHOULD items =====
Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-entrypoints , python3-entrypoints [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python2-entrypoints-0.2.2-1.fc26.noarch.rpm python3-entrypoints-0.2.2-1.fc26.noarch.rpm python-entrypoints-0.2.2-1.fc26.src.rpm python-entrypoints.src:61: W: mixed-use-of-spaces-and-tabs (spaces: line 61, tab: line 4) 3 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages) ---------------------------- 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires -------- python3-entrypoints (rpmlib, GLIBC filtered): python(abi)
python2-entrypoints (rpmlib, GLIBC filtered): python(abi)
Provides -------- python3-entrypoints: python3-entrypoints
python2-entrypoints: python-entrypoints python2-entrypoints
Source checksums ---------------- https://github.com/takluyver/entrypoints/archive/0.2.2.tar.gz : CHECKSUM(SHA256) this package : e54b5df8bb971507278c65df96e6486cf4aea0cdac384d0102ea0339e0a4f82b CHECKSUM(SHA256) upstream package : e54b5df8bb971507278c65df96e6486cf4aea0cdac384d0102ea0339e0a4f82b
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1379095 --plugins Python -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1379095
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1379095
--- Comment #4 from gil cattaneo puntogil@libero.it --- Issues: - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1167360 bytes in 62 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
[!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/gil/1379095 -python-entrypoints/licensecheck.txt
All source files are without license headers. Please, ask to upstream to confirm the licensing of code and/or content/s , and add license headers
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/Li...
https://bugzilla.redhat.com/show_bug.cgi?id=1379095
--- Comment #5 from Mukundan Ragavan nonamedotc@gmail.com --- 1/ Source URL fixed.
2/ -doc subpackage added.
3/ license clarification issue opened upstream and link added to spec. https://github.com/takluyver/entrypoints/issues/10
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-entrypo... SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python-entrypo...
https://bugzilla.redhat.com/show_bug.cgi?id=1379095
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from gil cattaneo puntogil@libero.it --- is not enough add a single %files -n python-%{srcname}-doc package ?
https://bugzilla.redhat.com/show_bug.cgi?id=1379095
--- Comment #7 from Mukundan Ragavan nonamedotc@gmail.com --- (In reply to gil cattaneo from comment #6)
is not enough add a single %files -n python-%{srcname}-doc package ?
True! I will fix this before import.
Thanks for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1379095 Bug 1379095 depends on bug 1379094, which changed state.
Bug 1379094 Summary: Review Request: python-flit - Simplified packaging of Python modules https://bugzilla.redhat.com/show_bug.cgi?id=1379094
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1379095
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-entrypoints
https://bugzilla.redhat.com/show_bug.cgi?id=1379095
Mukundan Ragavan nonamedotc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-10-03 20:14:52
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla