[Bug 725168] New: Review Request: xspice - X and Spice server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: xspice - X and Spice server

https://bugzilla.redhat.com/show_bug.cgi?id=725168

Summary: Review Request: xspice - X and Spice server
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],
                    [e-mail]
    Classification: Fedora
      Story Points: ---
              Type: ---

Spec URL: http://people.freedesktop.org/~alon/xspice.spec
SRPM URL: http://people.freedesktop.org/~alon/xspice-0.0.16-1.fc15.src.rpm
Description: xspice is an X and Spice server. It uses the spice protocol to
transfer the screen, mouse and keyboard of the user to the X server. Spice
provides a more efficient protocol then pure X for networking, and allows
disconnects of the viewer application without affecting the X clients.

It is not a separate X server, but reuses the regular Xorg xserver. It is
comprised of:

* launcher script xspice, that execs Xorg after setting up environment
variables.
 * spiceqxl_drv.so - xorg module that includes the video, keyboard and mouse
drivers, and links with spice-server.
 * spiceqxl.xorg.conf - config file that xspice passes to Xorg via -config,
that references those three drivers.

[Bug 725168] Review Request: xspice - X and Spice server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=725168

Marc-Andre Lureau  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|                            |fedora-review?

[Bug 725168] Review Request: xspice - X and Spice server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=725168

Marc-Andre Lureau  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED

--- Comment #1 from Marc-Andre Lureau  2011-08-02 08:33:01 EDT ---
* Wrong depedency on spice-sever: replaced with spice-server-devel
*  rpmlint xspice-0.0.16-1.fc15.src.rpm 
  xspice.src: W: summary-not-capitalized C xspice, an X and spice server
  xspice.src: W: name-repeated-in-summary C xspice
- The name 'xspice' doesn't follow convention to prefix with xorg-x11-server-
X11 servers: xorg-x11-server-Xspice instead
- updated summary
* rpmlint xorg-x11-server-Xspice-0.0.16-1.fc15.x86_64.rpm
  xorg-x11-server-Xspice.x86_64: W: non-conffile-in-etc
/etc/X11/spiceqxl.xorg.conf
  xorg-x11-server-Xspice.x86_64: W: no-manual-page-for-binary xspice
- added %config

package name: modified
spec file name: modified
packaging guidelines: ok
license: ok
license field: ok
license file: ok
spec language: ok
spec readability: ok
upstream sources: ok
buildable: yes
excludearch: FIXME (MUST have a bug filed in bugzilla, describing the reason
that the package does not compile/build/work on that architecture. The bug
number MUST be placed in a comment, next to the corresponding ExcludeArch line.
[8])
buildrequires: modified
locale handling: ok
ldconfig: ok
system libs: ok
relocatable: ok
directory ownership: ok
duplicate files: ok
file permissions: ok
macro use: ok
permissible content: ok
large docs: ok
%doc content: ok
header files: ok
static libs: ok
shared libs: ok
devel deps: ok
libtool archives: ok
gui apps: ok
duplicate ownership: ok
utf8 filenames: ok

[Bug 725168] Review Request: xspice - X and Spice server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=725168

--- Comment #2 from Marc-Andre Lureau  2011-08-02 08:35:53 EDT ---
elmarco@makai:~$ xspice --port 5900 --disable-ticketing :1.0
missing ca-cert - ./ca-cert.pem does not exist

What am I supposed to do? Anything missing in the package to make it work by
default after installation?

[Bug 725168] Review Request: xspice - X and Spice server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=725168

--- Comment #3 from Marc-Andre Lureau  2011-08-02 08:36:24 EDT ---
Created attachment 516316
  --> https://bugzilla.redhat.com/attachment.cgi?id=516316
updated spec

[Bug 725168] Review Request: xspice - X and Spice server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=725168

--- Comment #4 from Marc-Andre Lureau  2011-08-02 08:39:31 EDT ---
Missing requires: python?

[Bug 725168] Review Request: xspice - X and Spice server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=725168

--- Comment #5 from Alon Levy  2011-08-02 17:04:24 EDT ---
Updated spec, update srpm: New urls (erased the old to avoid confusion):
http://annarchy.freedesktop.org/~alon/Xspice/xorg-x11-server-Xspice.spec
http://annarchy.freedesktop.org/~alon/Xspice/xorg-x11-server-Xspice-0.0.16-1...
(prebuilt binaries for x86_64 are also there)

1. added Require: python >= 2.6
2. added several patches that rename the executable to Xspice and fix the
ca-cert issue you noticed.
3. Updated spec to include comment on why it excludes the excluded arches, per
the guidelines in [8], since this is a new package the bugs are to be opened
only after it is approved. Here is the section from [8]:
Architecture Build Failures

If a Fedora package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch needs to have a bug filed
in bugzilla, describing the reason that the package does not compile/build/work
on that architecture. The bug number should then be placed in a comment, next
to the corresponding ExcludeArch line. New packages will not have bugzilla
entries during the review process, so they should put this description in the
comment until the package is approved, then file the bugzilla entry, and
replace the long explanation with the bug number. The bug should be marked as
blocking one (or more) of the following bugs to simplify tracking such issues:

FE-ExcludeArch-x86
    FE-ExcludeArch-x64
    FE-ExcludeArch-ppc
    FE-ExcludeArch-ppc64
    F-ExcludeArch-arm
    F-ExcludeArch-s390x
    F-ExcludeArch-sparc

[Bug 725168] Review Request: Xspice - X and Spice server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=725168

Alon Levy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: xspice - X  |Review Request: Xspice - X
                   |and Spice server            |and Spice server

[Bug 725168] Review Request: Xspice - X and Spice server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=725168

--- Comment #6 from Marc-Andre Lureau  2011-08-30 10:39:54 EDT ---
looks ok to me now, you should try to find an official packager now.

[Bug 725168] Review Request: Xspice - X and Spice server

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=725168

Hans de Goede  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
                 CC|                            |[e-mail],
                   |                            |[e-mail],
                   |                            |[e-mail],
                   |                            |[e-mail]
          Component|Package Review              |xorg-x11-drv-qxl
         Resolution|                            |RAWHIDE
         AssignedTo|[e-mail]    |[e-mail]
               Flag|fedora-review?              |
        Last Closed|                            |2011-09-13 08:16:05

--- Comment #7 from Hans de Goede  2011-09-13 08:16:05 EDT ---
As discussed on irc, since this is building from the same upstream tarbal as
xorg-x11-drv-qxl, it should just be a subpackage of that.

I've just completed a build of xorg-x11-drv-qxl with a xorg-x11-server-Xspice
subpackage (F-16 and F-15 to follow soon) -> closing this bug.