https://bugzilla.redhat.com/show_bug.cgi?id=1397784
Bug ID: 1397784 Summary: Review Request: qt5-qtwebview - Qt5 - WebView component Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: helio@kde.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://heliocastro.fedorapeople.org/qt5-qtwebview/qt5-qtwebview.spec SRPM URL: https://heliocastro.fedorapeople.org/qt5-qtwebview/qt5-qtwebview-5.7.1-1.fc2... Description: Qt WebView provides a way to display web content in a QML application without necessarily including a full web browser stack by using native APIs where it makes sense. Fedora Account System Username: heliocastro
https://bugzilla.redhat.com/show_bug.cgi?id=1397784
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |rdieter@math.unl.edu Assignee|nobody@fedoraproject.org |rdieter@math.unl.edu Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1397784
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Rex Dieter rdieter@math.unl.edu --- naming: ok
license: ok
sources: ok (for now, 5.7.1 tarballs not officially released yet)
macros: ok
scriptlets: ok
follows style/conventions of other qt5- packages
Same comments as some other qt5- related reviews,
1. MUST reivew (and remove if needed) hard qt5 versioned dep, %{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}}
2. SHOULD remove BuildRequires: cmake it's not needed anymore, the appropriate cmake is pulled in by qt5-rpm-macros
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=1397784
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |928937 (qt-reviews) Alias| |qt5-qtwebview
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1397784
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2017-01-24 11:25:41
--- Comment #2 from Rex Dieter rdieter@math.unl.edu --- confirmed imported
https://bugzilla.redhat.com/show_bug.cgi?id=1397784
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- qt5-qtwebview-5.7.1-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-cd03ec0aa9
https://bugzilla.redhat.com/show_bug.cgi?id=1397784
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords| |Reopened
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- qt5-qtwebview-5.7.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-cd03ec0aa9
https://bugzilla.redhat.com/show_bug.cgi?id=1397784
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2017-01-24 11:25:41 |2017-02-06 19:24:14
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- qt5-qtwebview-5.7.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org