[Bug 2161114] New: Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

Bug ID: 2161114
           Summary: Review Request: openshot - Create and edit videos and
                    movies
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://ngompa.fedorapeople.org/for-review/openshot.spec
SRPM URL:
https://ngompa.fedorapeople.org/for-review/openshot-3.0.0-2.fc37.src.rpm

Description:
OpenShot Video Editor is a free, open-source, non-linear video editor. It
can create and edit videos and movies using many popular video, audio,
image formats.  Create videos for YouTube, Flickr, Vimeo, Metacafe, iPod,
Xbox, and many more common formats!

Features include:
* Multiple tracks (layers)
* Compositing, image overlays, and watermarks
* Audio mixing and editing
* Support for image sequences (rotoscoping)
* Key-frame animation
* Video effects (chroma-key)
* Transitions (lumas and masks)
* Titles with integrated editor and templates
* 3D animation (titles and effects)

Fedora Account System Username: ngompa

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

Neal Gompa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
         Depends On|                            |2161113

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2161113
[Bug 2161113] Review Request: libopenshot - Library for creating and editing
videos

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

--- Comment #1 from Jakub Kadlčík  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5238031
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

Davide Cavalca  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Blocks|                            |2218117 (MultimediaSIG)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2218117
[Bug 2218117] Tracker for multimedia-sig

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

Dominik 'Rathann' Mierzejewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
           Assignee|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED

--- Comment #2 from Dominik 'Rathann' Mierzejewski  ---
Taking review.

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114
Bug 2161114 depends on bug 2161113, which changed state.

Bug 2161113 Summary: Review Request: libopenshot - Library for creating and editing videos
https://bugzilla.redhat.com/show_bug.cgi?id=2161113

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

--- Comment #3 from Dominik 'Rathann' Mierzejewski  ---
Scratch build in koji succeeded:
https://koji.fedoraproject.org/koji/taskinfo?taskID=104433221 .

License tag must be corrected:
License:        GPL-3.0-or-later

licensecheck finds the following additional licenses:
Apache-2.0:
src/timeline/media/css/bootstrap.min.css
GPL-2.0-or-later:
images/Humanity/*
MIT:
src/timeline/media/css/ui-darkness/jquery-ui.theme.css
src/timeline/media/js/angular-animate.min.js
src/timeline/media/js/angular.min.js
src/timeline/media/js/jquery.js
src/timeline/media/js/jquery-ui.js
CC-BY-SA-4.0:
src/emojis/*
public-domain:
doc/youtube_directive.py

However, the doc/youtube_directive.py file doesn't seem to be included in the
final package, so I think it can be skipped.

Please convert to using the pyproject_* macros if possible. %py3_build and
%py3_install are old-style.
This might let you drop some of the manual BuildRequires, too.

Please change -f to -v in the rm invocation below:
rm -f %{buildroot}%{_prefix}/lib/mime/packages/openshot-qt
It'll fail when it's no longer necessary and the maintainer will know they can
remove it.

Please open an upstream issue for non-x86 support.

The %files section should be more explicit, because the globs resolve to just
one file in most cases:

%{_bindir}/*
should be
%{_bindir}/openshot-qt

%{_datadir}/applications/*.desktop
should be
%{_datadir}/applications/org.openshot.OpenShot.desktop

%{_datadir}/icons/hicolor/*/*/*
should be
%{_datadir}/icons/hicolor/*/apps/openshot-qt.png
%{_datadir}/icons/hicolor/scalable/apps/openshot-qt.svg
%{_datadir}/icons/hicolor/scalable/mimetypes/openshot-qt-doc.svg

%{_datadir}/pixmaps/*
should be
%{_datadir}/pixmaps/openshot-qt.svg

%{_datadir}/mime/packages/*
should be
%{_datadir}/mime/packages/org.openshot.OpenShot.xml

%{_metainfodir}/*.appdata.xml
should be
%{_metainfodir}/org.openshot.OpenShot.appdata.xml

Using a macro for 'org.openshot.OpenShot' might be a good idea here.

%{python3_sitelib}/*egg-info
will not be required if you use %pyproject_* macros.

rpmlint finds some issues:
openshot.noarch: E: zero-length
/usr/lib/python3.12/site-packages/openshot_qt/windows/views/timeline_mixins.py
openshot.noarch: W: no-manual-page-for-binary openshot-qt
and some duplicate files:
openshot.noarch: E: files-duplicated-waste 1318606
openshot.noarch: W: files-duplicate
/usr/lib/python3.12/site-packages/openshot_qt/images/cache/2744.png
/usr/lib/python3.12/site-packages/openshot_qt/images/cache/1F300.png:/usr/lib/python3.12/site-packages/openshot_qt/images/cache/1F3BC.png:/usr/lib/python3.12/site-packages/openshot_qt/images/cache/1F4A4.png:/usr/lib/python3.12/site-packages/openshot_qt/images/cache/1F4CE.png:/usr/lib/python3.12/site-packages/openshot_qt/images/cache/1F587.png
...

Other than that, the spec file is legible.

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

--- Comment #4 from Neal Gompa  ---
Most of this is addressed now.

I've not elected to convert to pyproject since the setuptools is so barebones
that it provides no additional value since it has no Python dependencies
defined.

Spec URL: https://ngompa.fedorapeople.org/for-review/openshot.spec
SRPM URL:
https://ngompa.fedorapeople.org/for-review/openshot-3.1.1-4.fc38.src.rpm

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=105456413

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

Fedora Review Service  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.openshot.org

--- Comment #5 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6350295
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

Dominik 'Rathann' Mierzejewski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #6 from Dominik 'Rathann' Mierzejewski  ---
Package builds and works.

Justification for not using pyproject_* macros is acceptable.

APPROVED.

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

--- Comment #7 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/openshot

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

--- Comment #8 from Fedora Update System  ---
FEDORA-2023-36c355af48 has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-36c355af48

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

--- Comment #9 from Fedora Update System  ---
FEDORA-2023-88c55c2f58 has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-88c55c2f58

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

--- Comment #10 from Fedora Update System  ---
FEDORA-2023-a051e46f06 has been submitted as an update to Fedora 37.
https://bodhi.fedoraproject.org/updates/FEDORA-2023-a051e46f06

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #11 from Fedora Update System  ---
FEDORA-2023-88c55c2f58 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2023-88c55c2f58 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-88c55c2f58

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

--- Comment #12 from Fedora Update System  ---
FEDORA-2023-36c355af48 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2023-36c355af48 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-36c355af48

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

--- Comment #13 from Fedora Update System  ---
FEDORA-2023-a051e46f06 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2023-a051e46f06 *`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-a051e46f06

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |MODIFIED

--- Comment #14 from Fedora Update System  ---
FEDORA-EPEL-2023-9d811d76d4 has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-9d811d76d4

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #15 from Fedora Update System  ---
FEDORA-EPEL-2023-9d811d76d4 has been pushed to the Fedora EPEL 9 testing
repository.

You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-9d811d76d4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2023-09-07 01:28:55

--- Comment #16 from Fedora Update System  ---
FEDORA-2023-36c355af48 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

--- Comment #17 from Fedora Update System  ---
FEDORA-2023-a051e46f06 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

--- Comment #18 from Fedora Update System  ---
FEDORA-EPEL-2023-9d811d76d4 has been pushed to the Fedora EPEL 9 stable
repository.
If problem still persists, please make note of it in this bug report.

[Bug 2161114] Review Request: openshot - Create and edit videos and movies

https://bugzilla.redhat.com/show_bug.cgi?id=2161114

--- Comment #19 from Fedora Update System  ---
FEDORA-2023-88c55c2f58 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.