[Bug 1295667] New: Review Request: erlang-proper - A QuickCheck-inspired property-based testing tool for Erlang
https://bugzilla.redhat.com/show_bug.cgi?id=1295667
Bug ID: 1295667 Summary: Review Request: erlang-proper - A QuickCheck-inspired property-based testing tool for Erlang Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rbarlow@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://rbarlow.fedorapeople.org/erlang-proper.spec SRPM URL: https://rbarlow.fedorapeople.org/erlang-proper-1.1-1.fc24.src.rpm Description: PropEr (PROPerty-based testing tool for ERlang) is a QuickCheck-inspired open-source property-based testing tool for Erlang. Fedora Account System Username: rbarlow
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12415288
There is one error and one warning from rpmlint. They are both due to Erlang packages not being noarch, but being installed in %{_libdir} even when they do not have C extensions. I believe we can safely ignore them.
Checking: erlang-proper-1.1-1.fc24.x86_64.rpm erlang-proper-1.1-1.fc24.src.rpm erlang-proper.x86_64: E: no-binary erlang-proper.x86_64: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 1 errors, 1 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1295667
Randy Barlow rbarlow@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1294331
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1294331 [Bug 1294331] Review Request: erlang-oauth2 - An Oauth2 implementation for Erlang
https://bugzilla.redhat.com/show_bug.cgi?id=1295667
--- Comment #1 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- rbarlow's scratch build of erlang-proper-1.1-1.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12415288
https://bugzilla.redhat.com/show_bug.cgi?id=1295667
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lemenkov@gmail.com Assignee|nobody@fedoraproject.org |lemenkov@gmail.com Flags| |fedora-review?
--- Comment #2 from Peter Lemenkov lemenkov@gmail.com --- I'll review it.
https://bugzilla.redhat.com/show_bug.cgi?id=1295667
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Peter Lemenkov lemenkov@gmail.com --- [+] rpmlint is silent (or produces only messages which can be safely ignored):
lemenkov ~/Downloads: rpmlint erlang-proper-1.1-1.fc24.* erlang-proper.x86_64: E: no-binary erlang-proper.x86_64: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 1 errors, 1 warnings. lemenkov ~/Downloads:
[+] The package is named according to the Package Naming Guidelines. [+] The spec file name matches the base package %{name}, in the format %{name}.spec. [+] The package meets the Packaging Guidelines. [+] The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
[-] The License field in the package spec file is wrong. It must contain GPLv3+ since the package licensed under "GPLv3 or any later version" (see the sources).
[+] The file, containing the text of the license(s) for the package, is included in %doc. [+] The spec file is written in American English. [+] The spec file for the package is legible. [+] The sources used to build the package matches the upstream source, as provided in the spec URL.
lemenkov ~/Downloads: sha256sum v1.1.tar.gz* d5d5641366cba6ced3cde3b48af5fd732236f20fd8a8d77ea1bad25b5b89b20b v1.1.tar.gz d5d5641366cba6ced3cde3b48af5fd732236f20fd8a8d77ea1bad25b5b89b20b v1.1.tar.gz.1 lemenkov ~/Downloads:
[+] The package successfully compiles and builds into binary rpms. See koji links above. [+] All build dependencies are listed in BuildRequires. [0] No need to handle locales. [0] The package does not contain any shared library files. [+] Packages does not bundle copies of system libraries. [+] The package isn't designed to be relocatable. [+] The package owns all directories that it creates. [+] The package does not list a file more than once in the spec file's %files listings. [+] Permissions on files are set properly. [+] The package consistently uses macros. [+] The package contains code, or permissible content. [0] No large documentation files. [+] Anything, the package includes as %doc, does not affect the runtime of the application. [0] No static libraries. [0] No -devel sub-package. [+] The package does not contain any .la libtool archives. [0] Not a GUI application. [+] The package does not own files or directories already owned by other packages. [+] All filenames in rpm packages are valid UTF-8.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1295667
--- Comment #4 from Randy Barlow rbarlow@redhat.com --- Thank you kindly for the review Peter! Good catch on the license issue, I've made a -2 to fix that:
Spec URL: https://rbarlow.fedorapeople.org/erlang-proper.spec SRPM URL: https://rbarlow.fedorapeople.org/erlang-proper-1.1-2.fc24.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1295667
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/erlang-proper
https://bugzilla.redhat.com/show_bug.cgi?id=1295667
Randy Barlow rbarlow@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Assignee|lemenkov@gmail.com |rbarlow@redhat.com Last Closed| |2016-01-07 13:41:26
--- Comment #6 from Randy Barlow rbarlow@redhat.com --- This is now in Rawhide!
http://koji.fedoraproject.org/koji/taskinfo?taskID=12451261
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla