[Bug 206395] New: Review Request: picocom - Minimal serial communications program

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206395

Summary: Review Request: picocom - Minimal serial communications
                    program
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/picocom.spec
SRPM URL: ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/picocom-1.4-1.src.rpm
Description: 
As its name suggests, [picocom] is a minimal dumb-terminal emulation
program. It is, in principle, very much like minicom, only it's "pico"
instead of "mini"! It was designed to serve as a simple, manual, modem
configuration, testing, and debugging tool. It has also served (quite
well) as a low-tech "terminal-window" to allow operator intervention
in PPP connection scripts (something like the ms-windows "open
terminal window before / after dialing" feature).  It could also prove
useful in many other similar tasks. It is ideal for embedded systems
since its memory footprint is minimal (less than 20K, when
stripped).

[Bug 206395] Review Request: picocom - Minimal serial communications program

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: picocom - Minimal serial communications program

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206395

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2006-09-14 06:43 EST -------
{Not Official Reviewer}
packaging looks ok.
+ Mockbuild is successfull for i386 FC6 
+ rpmlint on binary rpm is silent
- dist tag is NOT present
+ Buildroot is correct
+ source URL is correct
+ License used is GPL
+ License file LICENSE.txt is included
+ MD5 sum on tarball is matching upstream tarball
08fcc5f6bb9e7676a2569386d5ea9f70  picocom-1.4.tar.gz
+ No duplicate files

Not tested package.

You need to use macros change 
/usr/bin/picocom
to
%{_bindir}/picocom

[Bug 206395] Review Request: picocom - Minimal serial communications program

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: picocom - Minimal serial communications program

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206395

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

[Bug 206395] Review Request: picocom - Minimal serial communications program

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: picocom - Minimal serial communications program

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206395

------- Additional Comments From [e-mail]  2006-09-14 07:25 EST -------
Looks good!

Must fix:

- debug package is broken. Just remove the strip command from the spec and let
RPM handle it automatically.

- RPM_OPT_FLAGS and compiler string are not honored. For example, just add
'CC=%{__cc} CFLAGS="$RPM_OPT_FLAGS" to the make command. Also add 
'%{_smp_mflags}' to make line.

- in %files section, use %{_bindir} instead of /usr/bin/

- don't include empty TODO file.

Nice to have:

- use install instead of cp, to make sure files get correct permissions

[Bug 206395] Review Request: picocom - Minimal serial communications program

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: picocom - Minimal serial communications program

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206395

------- Additional Comments From [e-mail]  2006-09-14 12:35 EST -------
Thanks for the review.  I put the strip in there because rpmlint was winging
about the binary not being stripped.  I've removed it and made all other changes.

ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/picocom.spec
ftp://ftp.tummy.com/pub/tummy/RPMS/SRPMS/picocom-1.4-2.src.rpm

[Bug 206395] Review Request: picocom - Minimal serial communications program

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: picocom - Minimal serial communications program

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206395

------- Additional Comments From [e-mail]  2006-09-14 12:52 EST -------
> I put the strip in there because rpmlint was winging
> about the binary not being stripped

This usually means you're missing an RPM development package. rpmdevtools,
rpmlint or rpm-libs, i forget which one.

[Bug 206395] Review Request: picocom - Minimal serial communications program

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: picocom - Minimal serial communications program

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206395

------- Additional Comments From [e-mail]  2006-09-14 15:32 EST -------
Obviously I ha rpmlint :-).  I already had rpm-libs, so it must have been
rpmdevtools.  I've got it installed now, thanks.

Sean

[Bug 206395] Review Request: picocom - Minimal serial communications program

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: picocom - Minimal serial communications program

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206395

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-09-14 15:44 EST -------
MUST items:

- rpmlint clean
- package names ok
- spec follows guidelines
- GPL license verified and included
- tarball md5sum verified
- clean mock build
- own its directories
- permissions good
- no %files duplicates
- standard Group:
- executable is working
- good %clean section

I hereby solemny declare this package APPROVED!

[Bug 206395] Review Request: picocom - Minimal serial communications program

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: picocom - Minimal serial communications program

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206395

------- Additional Comments From [e-mail]  2006-09-19 05:50 EST -------
(don't forget to build your package and close this bug. thx)

[Bug 206395] Review Request: picocom - Minimal serial communications program

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: picocom - Minimal serial communications program

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206395

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 206395] Review Request: picocom - Minimal serial communications program

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: picocom - Minimal serial communications program

https://bugzilla.redhat.com/show_bug.cgi?id=206395

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide