[Bug 1274512] New: Review Request: nodejs-string-prototype-trim - ES5 spec-compliant shim for String.prototype.trim
https://bugzilla.redhat.com/show_bug.cgi?id=1274512
Bug ID: 1274512 Summary: Review Request: nodejs-string-prototype-trim - ES5 spec-compliant shim for String.prototype.trim Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: tom@compton.nu QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://tomh.fedorapeople.org//nodejs-string-prototype-trim.spec SRPM URL: http://tomh.fedorapeople.org//nodejs-string-prototype-trim-1.1.1-1.fc23.src....
Description: An ES5 spec-compliant String.prototype.trim shim. Invoke its "shim" method to shim String.prototype.trim if it is unavailable.
https://bugzilla.redhat.com/show_bug.cgi?id=1274512
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews), | |1268280 Depends On| |1274507, 1274511
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1268280 [Bug 1268280] nodejs-tape-4.2.2 is available https://bugzilla.redhat.com/show_bug.cgi?id=1274507 [Bug 1274507] Review Request: nodejs-es-abstract - ECMAScript spec abstract operations https://bugzilla.redhat.com/show_bug.cgi?id=1274511 [Bug 1274511] Review Request: nodejs-define-properties - Define multiple non-enumerable properties at once
https://bugzilla.redhat.com/show_bug.cgi?id=1274512 Bug 1274512 depends on bug 1274511, which changed state.
Bug 1274511 Summary: Review Request: nodejs-define-properties - Define multiple non-enumerable properties at once https://bugzilla.redhat.com/show_bug.cgi?id=1274511
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1274512
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |nodejs-string-prototype-tri |nodejs-string-dot-prototype |m - ES5 spec-compliant shim |-dot-trim - ES5 |for String.prototype.trim |spec-compliant shim for | |String.prototype.trim
--- Comment #1 from Tom Hughes tom@compton.nu --- Renamed to better match other String.prototype.xxx node modules:
Spec URL: https://tomh.fedorapeople.org/nodejs-string-dot-prototype-dot-trim.spec SRPM URL: https://tomh.fedorapeople.org/nodejs-string-dot-prototype-dot-trim-1.1.1-1.f...
https://bugzilla.redhat.com/show_bug.cgi?id=1274512 Bug 1274512 depends on bug 1274507, which changed state.
Bug 1274507 Summary: Review Request: nodejs-es-abstract - ECMAScript spec abstract operations https://bugzilla.redhat.com/show_bug.cgi?id=1274507
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1274512
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com Assignee|nobody@fedoraproject.org |panemade@gmail.com Flags| |fedora-review+
--- Comment #2 from Parag AN(पराग) panemade@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 15 files have unknown license. Detailed output of licensecheck in /home/parag/1274512-nodejs-string-dot-prototype-dot- trim/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: nodejs-string-dot-prototype-dot-trim-1.1.1-1.fc24.noarch.rpm nodejs-string-dot-prototype-dot-trim-1.1.1-1.fc24.src.rpm nodejs-string-dot-prototype-dot-trim.noarch: W: only-non-binary-in-usr-lib nodejs-string-dot-prototype-dot-trim.noarch: W: dangling-symlink /usr/lib/node_modules/string.prototype.trim/node_modules/define-properties /usr/lib/node_modules/define-properties nodejs-string-dot-prototype-dot-trim.noarch: W: dangling-symlink /usr/lib/node_modules/string.prototype.trim/node_modules/es-abstract /usr/lib/node_modules/es-abstract nodejs-string-dot-prototype-dot-trim.noarch: W: dangling-symlink /usr/lib/node_modules/string.prototype.trim/node_modules/function-bind /usr/lib/node_modules/function-bind 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory nodejs-string-dot-prototype-dot-trim.noarch: W: only-non-binary-in-usr-lib nodejs-string-dot-prototype-dot-trim.noarch: W: dangling-symlink /usr/lib/node_modules/string.prototype.trim/node_modules/define-properties /usr/lib/node_modules/define-properties nodejs-string-dot-prototype-dot-trim.noarch: W: dangling-symlink /usr/lib/node_modules/string.prototype.trim/node_modules/function-bind /usr/lib/node_modules/function-bind nodejs-string-dot-prototype-dot-trim.noarch: W: dangling-symlink /usr/lib/node_modules/string.prototype.trim/node_modules/es-abstract /usr/lib/node_modules/es-abstract 1 packages and 0 specfiles checked; 0 errors, 4 warnings.
Requires -------- nodejs-string-dot-prototype-dot-trim (rpmlib, GLIBC filtered): nodejs(engine) npm(define-properties) npm(es-abstract) npm(function-bind)
Provides -------- nodejs-string-dot-prototype-dot-trim: nodejs-string-dot-prototype-dot-trim npm(string.prototype.trim)
Source checksums ---------------- https://registry.npmjs.org/string.prototype.trim/-/string.prototype.trim-1.1... : CHECKSUM(SHA256) this package : 85ca5407485a912b87ad43aabc27d19686b71871f2322ed4e8a66c2ca4e503b5 CHECKSUM(SHA256) upstream package : 85ca5407485a912b87ad43aabc27d19686b71871f2322ed4e8a66c2ca4e503b5
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1274512
--- Comment #3 from Tom Hughes tom@compton.nu --- Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=1274512
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/nodejs-string-dot-prototype-do...
https://bugzilla.redhat.com/show_bug.cgi?id=1274512
Tom Hughes tom@compton.nu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-01-01 11:22:08
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla