[Bug 214091] New: Review Request: beneath-a-steel-sky-cd - Beneath a Steel Sky - Adventure Game - CD version
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214091
Summary: Review Request: beneath-a-steel-sky-cd - Beneath a Steel Sky - Adventure Game - CD version Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: j.w.r.degoede@hhs.nl QAContact: fedora-package-review@redhat.com
Spec URL: http://people.atrpms.net/~hdegoede/beneath-a-steel-sky-cd.spec SRPM URL: http://people.atrpms.net/~hdegoede/beneath-a-steel-sky-cd-0.0372-1.src.rpm Description: After the Dungeons and Dragons fantasy setting of Revolution's first game, Lure of the Temptress, Revolution decided to go down a completely different avenue with its second adventure game, Beneath a Steel Sky, that of Science Fiction. A bleak vision of the future was imagined, where mind control and medical science combined forces to repress the populace. Leading comic artist, Dave Gibbons, joined the design team to visualise this desperate landscape. The result is the cult classic Beneath a Steel Sky.
This package contains the CD version, which contains additional / longer cutscenes and voice acting, but also is much larger: 70 MB where as the also available floppy version (package name beneath-a-steel-sky) is only 8 MB.
---
Note that this package requires scummvm, whose review request is here: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
I'll also submitted the floppy version for review as bug 214057
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: beneath-a-steel-sky-cd - Beneath a Steel Sky - Adventure Game - CD version
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214091
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |214055
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: beneath-a-steel-sky-cd - Beneath a Steel Sky - Adventure Game - CD version Alias: scummvm-bass-CD
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214091
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |chris.stone@gmail.com OtherBugsDependingO|163776 |163778 nThis| | Alias| |scummvm-bass-CD
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: beneath-a-steel-sky-cd - Beneath a Steel Sky - Adventure Game - CD version Alias: scummvm-bass-CD
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214091
Bug 214091 depends on bug 214055, which changed state.
Bug 214055 Summary: Review Request: scummvm - Interpreter for several adventure games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214055
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: beneath-a-steel-sky-cd - Beneath a Steel Sky - Adventure Game - CD version Alias: scummvm-bass-CD
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214091
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From chris.stone@gmail.com 2006-11-09 17:58 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output W: beneath-a-steel-sky-cd no-%build-section
okay, but no harm in enabling %build either - spec file named according to package naming guidelines (but a provides bass-cd would make it easier to install) - spec filename matches %{name} - package meets packaging guidelines - licensed as distributable, see https://www.redhat.com/archives/fedora-extras-list/2006-November/msg00030.ht... - License file included in %doc - spec written in American english - spec file is legible - sources match upstream 1d4401cd663715332abe8bb5431e356d bass-cd-1.2.zip - package successfully compiles and builds on FC5 X86_64 - all dependencies listed in BR - no locales - no shared libraries - package is not relocatable - package owns all directories it creates - no duplicates in %files - file permissions set properly - package has proper %clean section - macro usage is consistent - package contains permissible content - no large documentation - no header files or static libraries - no pkgconfig files - no devel subpackage required - no .la files - package contains proper .desktop file - package does not own files or directories owned by other packages
APPROVED
==== SHOULD ==== - uncomment %build to make rpmlint happy - add Provides: bass-cd for easier commandline installs - add comment above license pointing to distribution discussions on f-e-l
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: beneath-a-steel-sky-cd - Beneath a Steel Sky - Adventure Game - CD version Alias: scummvm-bass-CD
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214091
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-11-10 03:47 EST ------- (In reply to comment #1)
==== SHOULD ====
- uncomment %build to make rpmlint happy
Done
- add Provides: bass-cd for easier commandline installs
Not done, I deliberately choose the long name as bass is a much to generic name, giving no information about the package contents and leading to potential namespace conflicts.
- add comment above license pointing to distribution discussions on f-e-l
Done.
Imported and build. Thanks for the review!
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla