[Bug 2228228] New: Review Request: rust-gix-glob - Glob pattern matching implementation for gix
https://bugzilla.redhat.com/show_bug.cgi?id=2228228
Bug ID: 2228228 Summary: Review Request: rust-gix-glob - Glob pattern matching implementation for gix Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/rust-gix-glob.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-gix-glob-0.10.1-1.fc38.src.rpm
Description: Glob pattern matching implementation for gix.
Fedora Account System Username: decathorpe
https://bugzilla.redhat.com/show_bug.cgi?id=2228228
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=104234164
https://bugzilla.redhat.com/show_bug.cgi?id=2228228
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/gi | |x-glob
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6230412 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2228228
blinxen h-k-81@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@fedoraproject.org |h-k-81@hotmail.com Doc Type|--- |If docs needed, set a value CC| |h-k-81@hotmail.com Status|NEW |ASSIGNED
--- Comment #3 from blinxen h-k-81@hotmail.com --- Taking this review
General comments:
- Package was generated with rust2rpm and minor changes were made - Summary and description were updated --> should be OK - A documentation feature was dropped because it is not relevant to fedora --> should be OK - Upstream released a new version of this crate --> Please update to the latest version
Problems:
- rpmlint reports the following: "E: non-executable-script /usr/share/cargo/registry/gix-glob-0.10.1/tests/fixtures/make_baseline.sh 644 /bin/bash" --> I think exluding this files should be OK
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- gix-glob-devel , rust-gix-glob+default-devel , rust-gix-glob+serde- devel [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
Rpmlint ------- Checking: rust-gix-glob-devel-0.10.1-1.fc40.noarch.rpm rust-gix-glob+default-devel-0.10.1-1.fc40.noarch.rpm rust-gix-glob+serde-devel-0.10.1-1.fc40.noarch.rpm rust-gix-glob-0.10.1-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp1n186brd')] checks: 31, packages: 4
rust-gix-glob-devel.noarch: E: non-executable-script /usr/share/cargo/registry/gix-glob-0.10.1/tests/fixtures/make_baseline.sh 644 /bin/bash rust-gix-glob+default-devel.noarch: W: no-documentation rust-gix-glob+serde-devel.noarch: W: no-documentation 4 packages and 0 specfiles checked; 1 errors, 2 warnings, 1 badness; has taken 0.2 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3
rust-gix-glob-devel.noarch: E: non-executable-script /usr/share/cargo/registry/gix-glob-0.10.1/tests/fixtures/make_baseline.sh 644 /bin/bash rust-gix-glob+default-devel.noarch: W: no-documentation rust-gix-glob+serde-devel.noarch: W: no-documentation 3 packages and 0 specfiles checked; 1 errors, 2 warnings, 1 badness; has taken 0.0 s
Source checksums ---------------- https://crates.io/api/v1/crates/gix-glob/0.10.1/download#/gix-glob-0.10.1.cr... : CHECKSUM(SHA256) this package : d7c79b881a18d89a75876ba277476d5a2bad5b19f03759c7a07e0808dfe08212 CHECKSUM(SHA256) upstream package : d7c79b881a18d89a75876ba277476d5a2bad5b19f03759c7a07e0808dfe08212
Requires -------- rust-gix-glob-devel (rpmlib, GLIBC filtered): (crate(bitflags/default) >= 2.0.0 with crate(bitflags/default) < 3.0.0~) (crate(bstr) >= 1.3.0 with crate(bstr) < 2.0.0~) (crate(bstr/std) >= 1.3.0 with crate(bstr/std) < 2.0.0~) (crate(gix-features/default) >= 0.32.1 with crate(gix-features/default) < 0.33.0~) (crate(gix-path/default) >= 0.8.4 with crate(gix-path/default) < 0.9.0~) cargo
rust-gix-glob+default-devel (rpmlib, GLIBC filtered): cargo crate(gix-glob)
rust-gix-glob+serde-devel (rpmlib, GLIBC filtered): (crate(bitflags/serde) >= 2.0.0 with crate(bitflags/serde) < 3.0.0~) (crate(bstr/serde) >= 1.3.0 with crate(bstr/serde) < 2.0.0~) (crate(serde) >= 1.0.114 with crate(serde) < 2.0.0~) (crate(serde/derive) >= 1.0.114 with crate(serde/derive) < 2.0.0~) cargo crate(gix-glob)
Provides -------- rust-gix-glob-devel: crate(gix-glob) rust-gix-glob-devel
rust-gix-glob+default-devel: crate(gix-glob/default) rust-gix-glob+default-devel
rust-gix-glob+serde-devel: crate(gix-glob/serde) rust-gix-glob+serde-devel
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-gix-glob --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: fonts, PHP, Perl, C/C++, Ocaml, Haskell, Java, R, Python, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2228228
--- Comment #4 from Fabio Valentini decathorpe@gmail.com ---
- rpmlint reports the following: "E: non-executable-script /usr/share/cargo/registry/gix-glob-0.10.1/tests/fixtures/make_baseline.sh 644 /bin/bash" --> I think exluding this files should be OK
I think this is harmless. It's not supposed to be executed when running tests, and it doesn't result in an unwanted dependency on /usr/bin/bash. If you want, I can exclude the file, but it will not change the package in any meaningful way.
https://bugzilla.redhat.com/show_bug.cgi?id=2228228
blinxen h-k-81@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #5 from blinxen h-k-81@hotmail.com ---
If you want, I can exclude the file, but it will not change the package in any meaningful way.
If it is not used during tests, then excluding it wouldn't harm :D. This would fix the rpmlint error. But I don't think this blocks the package from being approved.
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=2228228
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Thanks! I'll figure out how to do this in a way that doesn't require us from maintaining a downstream patch. Maybe upstream it as an "exclude =[]" setting for Cargo.toml.
https://bugzilla.redhat.com/show_bug.cgi?id=2228228
--- Comment #7 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-glob
https://bugzilla.redhat.com/show_bug.cgi?id=2228228
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Fixed In Version| |rust-gix-glob-0.10.1-1.fc40 Status|POST |CLOSED Last Closed| |2023-08-31 15:19:10
--- Comment #8 from Fabio Valentini decathorpe@gmail.com --- Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-7285513879
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com