https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Bug ID: 2218338 Summary: Review Request: skribilo - A free document production tool Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: benson_muite@emailplus.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
spec: https://download.copr.fedorainfracloud.org/results/fed500/guile-reader/fedor... srpm: https://download.copr.fedorainfracloud.org/results/fed500/guile-reader/fedor...
Description: Skribilo is a free document production tool that takes a structured document representation as its input and renders that document in a variety of output formats: HTML and Info for on-line browsing, and Lout and LaTeX for high-quality hard copies.
fas: fed500
Comments: a) Waiting for update of signing key to package the latest version. b) Need to package Junction fonts c) Depends on guile-reader https://bugzilla.redhat.com/show_bug.cgi?id=2218044
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Depends On| |2218044
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2218044 [Bug 2218044] Review Request: guile-reader - A simple framework for building readers for GNU Guile
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://www.nongnu.org/%%7Bna | |me}
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6123559 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2218461
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2218461 [Bug 2218461] Review Request: lomt-junction-fonts - A humanist sans-serif typeface
https://bugzilla.redhat.com/show_bug.cgi?id=2218338 Bug 2218338 depends on bug 2218461, which changed state.
Bug 2218461 Summary: Review Request: lomt-junction-fonts - A humanist sans-serif typeface https://bugzilla.redhat.com/show_bug.cgi?id=2218461
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
--- Comment #2 from Benson Muite benson_muite@emailplus.org --- Updated. spec: https://download.copr.fedorainfracloud.org/results/fed500/guile-reader/fedor... srpm: https://download.copr.fedorainfracloud.org/results/fed500/guile-reader/fedor...
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6377538 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
--- Comment #4 from Benson Muite benson_muite@emailplus.org --- Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=106029174
https://bugzilla.redhat.com/show_bug.cgi?id=2218338 Bug 2218338 depends on bug 2218044, which changed state.
Bug 2218044 Summary: Review Request: guile-reader - A simple framework for building readers for GNU Guile https://bugzilla.redhat.com/show_bug.cgi?id=2218044
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
--- Comment #5 from Benson Muite benson_muite@emailplus.org --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Andrew Bauer zonexpertconsulting@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? CC| |zonexpertconsulting@outlook | |.com
--- Comment #6 from Andrew Bauer zonexpertconsulting@outlook.com --- Wow, you've been waiting awhile for this one. There are elements of this specfile I am not familiar with (i.e. lang files), but I'll get up to speed as we progress.
I haven't run fedora-review yet. For starters let's discuss rpmlint, since it was rather noisy:
$ rpmlint *.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2
skribilo.noarch: E: zero-length /usr/share/doc/skribilo/ChangeLog skribilo.noarch: W: only-non-binary-in-usr-lib skribilo.noarch: E: noarch-with-lib64 skribilo.noarch: W: no-manual-page-for-binary skribilo-config skribilo.spec:9: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 9) skribilo.spec:147: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/diff.go skribilo.spec:148: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}.go skribilo.spec:149: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name} skribilo.spec:150: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/*.go skribilo.spec:151: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/biblio skribilo.spec:152: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/biblio/*.go skribilo.spec:153: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/documentation skribilo.spec:154: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/documentation/*.go skribilo.spec:155: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/engine skribilo.spec:156: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/engine/*.go skribilo.spec:157: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/package skribilo.spec:158: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/package/*.go skribilo.spec:159: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/package/eq skribilo.spec:160: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/package/eq/*.go skribilo.spec:161: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/package/pie skribilo.spec:162: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/package/pie/*.go skribilo.spec:163: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/package/slide skribilo.spec:164: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/package/slide/*.go skribilo.spec:165: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/reader skribilo.spec:166: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/reader/*.go skribilo.spec:167: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/source skribilo.spec:168: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/source/*.go skribilo.spec:169: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/guile/%{mver}/site-ccache/%{name}/utils skribilo.spec:170: W: libdir-macro-in-noarch-package (main package) %{_libdir}/guile/%{mver}/site-ccache/%{name}/utils/*.go skribilo.noarch: W: file-not-utf8 /usr/share/doc/skribilo/ChangeLog.Skribe skribilo.noarch: W: file-not-utf8 /usr/share/man/man1/skribilo.1.gz skribilo.noarch: W: file-not-in-%lang /usr/share/locale/da/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/fur/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/hu/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/pt_BR/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/sr/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/sv/LC_MESSAGES/skribilo.mo skribilo.noarch: W: file-not-in-%lang /usr/share/locale/uk/LC_MESSAGES/skribilo.mo skribilo.noarch: W: devel-file-in-non-devel-package /usr/bin/skribilo-config skribilo.noarch: E: description-line-too-long Last but not least, Skribilo can be thought of as a complete document programming skribilo.noarch: E: description-line-too-long framework for the Scheme programming language that may be used to automate a variety skribilo.noarch: E: description-line-too-long of document generation tasks. Technically, the Skribilo language/API is an embedded skribilo.noarch: E: description-line-too-long domain-specific language (EDSL), implemented via so-called “deep embedding”. Skribilo skribilo.src: E: description-line-too-long Last but not least, Skribilo can be thought of as a complete document programming skribilo.src: E: description-line-too-long framework for the Scheme programming language that may be used to automate a variety skribilo.src: E: description-line-too-long of document generation tasks. Technically, the Skribilo language/API is an embedded skribilo.src: E: description-line-too-long domain-specific language (EDSL), implemented via so-called “deep embedding”. Skribilo skribilo.noarch: W: dangling-relative-symlink /usr/share/info/bsd.png.gz ../doc/skribilo/bsd.png.gz skribilo.noarch: W: dangling-relative-symlink /usr/share/info/document-toolchain.png.gz ../doc/skribilo/document-toolchain.png.gz skribilo.noarch: W: dangling-relative-symlink /usr/share/info/eq-disponibilite.png.gz ../doc/skribilo/eq-disponibilite.png.gz skribilo.noarch: W: dangling-relative-symlink /usr/share/info/eq-limit-b-over-l-simplified.png.gz ../doc/skribilo/eq-limit-b-over-l-simplified.png.gz skribilo.noarch: W: dangling-relative-symlink /usr/share/info/eq-limit-b-over-l.png.gz ../doc/skribilo/eq-limit-b-over-l.png.gz skribilo.noarch: W: dangling-relative-symlink /usr/share/info/linux.png.gz ../doc/skribilo/linux.png.gz 2 packages and 0 specfiles checked; 10 errors, 45 warnings, 10 badness; has taken 0.4 s
============================ rpmlint session ends ============================
TO-DO: - please remove the zerolength ChangeLog or consider symlinking it with ChangeLog.Skribe - I know rpmlint is nitpicking, but please use either spaces or tabs in the specfile, not both - please shorten the length of each line in the description such that each is less than 80 characters
- While skribilo itself is just a shell script and hence, not arch dependent, the .go files generated by guile are architecture dependent. We need to do something about this. Perhaps the simplest thing to do would be to remove the noarch flag in the specfile.
- Rpmlint is complaining about the lang files placed under /usr/share/locale. This implies we should be doing something more than just placing files there. I'm not sure yet what the answer is to this, but I did find mention of this %find_lang macro: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_why_do_we_need_t...
Comments: I haven't yet verified the relative symlinks rpmlint is complaining about, but I suspect they are correct. The rest of the warnings can be ignored.
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
--- Comment #7 from Benson Muite benson_muite@emailplus.org --- Thanks. - removed tabs - ensured all description lines are less than 80 characters - removed no-arch flag and added macro to indicate no debuginfo - used %find_lang macro
Still need to check symlink warnings.
spec: https://download.copr.fedorainfracloud.org/results/fed500/guile-reader/fedor... srpm: https://download.copr.fedorainfracloud.org/results/fed500/guile-reader/fedor...
koji build: skribilo-0.9.5-1.fc40.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
--- Comment #9 from Andrew Bauer zonexpertconsulting@outlook.com --- Ah, that's much cleaner.
Please remove the following from %files. These folders should be owned by the guile package: %dir %{_datadir}/guile %dir %{_datadir}/guile/site %dir %{_datadir}/guile/site/%{mver}
Rather than %exclude fonts under %files, please delete them instead in %install and then place a symlink in their place, similar to what I am doing here: https://src.fedoraproject.org/rpms/python-ouimeaux/blob/rawhide/f/python-oui...
What are the .pdf files that are being %excluded? Those should be deleted as well in %install if they are not being used.
If you are looking for something quick, you could do this one-liner: find %{buildroot} ( -name .pdf -or- -name .ttf -or -name .otf ) -type f -delete > /dev/null 2>&1 || :
Don't forget to buildrequire find if you go this route.
There are some unusual package requires:
$ rpm -qp --requires /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm ImageMagick-devel emacs gettext-devel glibc-common glibc-devel gnupg2 guile-devel guile-reader-devel lout make rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 texlive texlive-collection-context /usr/bin/sh linux-libertine-biolinum-fonts linux-libertine-fonts lomt-junction-fonts rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 source-foundry-hack-fonts texlive-lobster2
Unless skribilo is building something each time it is run, it should not be pulling in make and -devel packages. I'm still looking into how these dependencies snuck in. Let me know if you have any insight on this.
We are getting there.
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
--- Comment #10 from Andrew Bauer zonexpertconsulting@outlook.com --- Disregard the last comment about the unusual runtime requirements. That was user error. I was checking the src.rpm rather than the rpm, doh!
This looks much better.... $ rpm -qp --requires skribilo-0.9.5-1.fc38.x86_64.rpm /usr/bin/sh linux-libertine-biolinum-fonts linux-libertine-fonts lomt-junction-fonts rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 source-foundry-hack-fonts texlive-lobster2
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
--- Comment #11 from Benson Muite benson_muite@emailplus.org --- Thanks. Updated.
spec: https://download.copr.fedorainfracloud.org/results/fed500/guile-reader/fedor... srpm: https://download.copr.fedorainfracloud.org/results/fed500/guile-reader/fedor...
Pull request for directory ownership by guile: https://src.fedoraproject.org/rpms/guile/pull-request/4
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
--- Comment #12 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6490015 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
--- Comment #13 from Andrew Bauer zonexpertconsulting@outlook.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "FSF All Permissive License", "FSF Unlimited License (with License Retention) [generated file]", "FSF Unlimited License [generated file]", "GNU General Public License v3.0 or later", "GNU General Public License v2.0 or later [generated file]", "FSF Unlimited License (with License Retention)", "X11 License [generated file]", "FSF Unlimited License (with License Retention) GNU Lesser General Public License GNU General Public License", "GNU Lesser General Public License v2.1 or later", "GNU General Public License", "GNU Lesser General Public License v3.0 or later", "*No copyright* SIL Open Font License", "SIL Open Font License 1.1", "GNU Lesser General Public License v3.0 or later [generated file]", "GNU General Public License v2.0 or later", "*No copyright* GNU General Public License". 125 files have unknown license. Detailed output of licensecheck in /home/abauer/2218338-skribilo/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/guile/2.0/site-ccache [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/guile/2.0/site- ccache [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 856651 bytes in 59 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [ ]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in skribilo-emacs [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2304000 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: skribilo-0.9.5-1.fc40.x86_64.rpm skribilo-emacs-0.9.5-1.fc40.noarch.rpm skribilo-0.9.5-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqyi4gbng')] checks: 31, packages: 3
skribilo.x86_64: W: only-non-binary-in-usr-lib skribilo.x86_64: W: no-manual-page-for-binary skribilo-config skribilo-emacs.noarch: W: no-documentation skribilo.x86_64: W: devel-file-in-non-devel-package /usr/bin/skribilo-config skribilo.x86_64: W: dangling-symlink /usr/share/doc/skribilo/Junction-regular.otf /usr/share/fonts/Junction-regular.otf skribilo.x86_64: W: dangling-symlink /usr/share/doc/skribilo/LobsterTwo-Regular.otf /usr/share/fonts/lobster2/LobsterTwo-Regular.otf skribilo.x86_64: W: dangling-symlink /usr/share/doc/skribilo/static/Hack-Regular.ttf /usr/share/fonts/source-foundry-hack-fonts/Hack-Regular.ttf skribilo.x86_64: W: dangling-symlink /usr/share/doc/skribilo/static/LinBiolinum_R.otf /usr/share/fonts/linux-libertine/LinBiolinum_R.otf skribilo.x86_64: W: dangling-symlink /usr/share/doc/skribilo/static/LinLibertine_R.otf /usr/share/fonts/linux-libertine/LinLibertine_R.otf skribilo.x86_64: W: dangling-relative-symlink /usr/share/info/bsd.png.gz ../doc/skribilo/bsd.png.gz skribilo.x86_64: W: dangling-relative-symlink /usr/share/info/document-toolchain.png.gz ../doc/skribilo/document-toolchain.png.gz skribilo.x86_64: W: dangling-relative-symlink /usr/share/info/eq-disponibilite.png.gz ../doc/skribilo/eq-disponibilite.png.gz skribilo.x86_64: W: dangling-relative-symlink /usr/share/info/eq-limit-b-over-l-simplified.png.gz ../doc/skribilo/eq-limit-b-over-l-simplified.png.gz skribilo.x86_64: W: dangling-relative-symlink /usr/share/info/eq-limit-b-over-l.png.gz ../doc/skribilo/eq-limit-b-over-l.png.gz skribilo.x86_64: W: dangling-relative-symlink /usr/share/info/linux.png.gz ../doc/skribilo/linux.png.gz 3 packages and 0 specfiles checked; 0 errors, 15 warnings, 0 badness; has taken 0.4 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 2
skribilo.x86_64: W: only-non-binary-in-usr-lib skribilo.x86_64: W: no-manual-page-for-binary skribilo-config skribilo-emacs.noarch: W: no-documentation skribilo.x86_64: W: devel-file-in-non-devel-package /usr/bin/skribilo-config skribilo.x86_64: W: dangling-symlink /usr/share/doc/skribilo/Junction-regular.otf /usr/share/fonts/Junction-regular.otf skribilo.x86_64: W: dangling-symlink /usr/share/doc/skribilo/LobsterTwo-Regular.otf /usr/share/fonts/lobster2/LobsterTwo-Regular.otf skribilo.x86_64: W: dangling-symlink /usr/share/doc/skribilo/static/Hack-Regular.ttf /usr/share/fonts/source-foundry-hack-fonts/Hack-Regular.ttf skribilo.x86_64: W: dangling-symlink /usr/share/doc/skribilo/static/LinBiolinum_R.otf /usr/share/fonts/linux-libertine/LinBiolinum_R.otf skribilo.x86_64: W: dangling-symlink /usr/share/doc/skribilo/static/LinLibertine_R.otf /usr/share/fonts/linux-libertine/LinLibertine_R.otf skribilo.x86_64: W: dangling-relative-symlink /usr/share/info/bsd.png.gz ../doc/skribilo/bsd.png.gz skribilo.x86_64: W: dangling-relative-symlink /usr/share/info/document-toolchain.png.gz ../doc/skribilo/document-toolchain.png.gz skribilo.x86_64: W: dangling-relative-symlink /usr/share/info/eq-disponibilite.png.gz ../doc/skribilo/eq-disponibilite.png.gz skribilo.x86_64: W: dangling-relative-symlink /usr/share/info/eq-limit-b-over-l-simplified.png.gz ../doc/skribilo/eq-limit-b-over-l-simplified.png.gz skribilo.x86_64: W: dangling-relative-symlink /usr/share/info/eq-limit-b-over-l.png.gz ../doc/skribilo/eq-limit-b-over-l.png.gz skribilo.x86_64: W: dangling-relative-symlink /usr/share/info/linux.png.gz ../doc/skribilo/linux.png.gz 2 packages and 0 specfiles checked; 0 errors, 15 warnings, 0 badness; has taken 0.1 s
Source checksums ---------------- https://download.savannah.nongnu.org/releases/skribilo/skribilo-0.9.5.tar.gz... : CHECKSUM(SHA256) this package : e5ded90be7d06a7239e662c3d42588cde973b7e8bfb8c8c65d5a2e1566c608f6 CHECKSUM(SHA256) upstream package : e5ded90be7d06a7239e662c3d42588cde973b7e8bfb8c8c65d5a2e1566c608f6 https://download.savannah.nongnu.org/releases/skribilo/skribilo-0.9.5.tar.gz : CHECKSUM(SHA256) this package : 00826a21c4634fb0b410ee89eb48068c445d800825874654e3d53d5ca3f0bf09 CHECKSUM(SHA256) upstream package : 00826a21c4634fb0b410ee89eb48068c445d800825874654e3d53d5ca3f0bf09
Requires -------- skribilo (rpmlib, GLIBC filtered): /usr/bin/sh guile linux-libertine-biolinum-fonts linux-libertine-fonts lomt-junction-fonts source-foundry-hack-fonts texlive-lobster2
skribilo-emacs (rpmlib, GLIBC filtered): emacs skribilo
Provides -------- skribilo: skribilo skribilo(x86-64)
skribilo-emacs: skribilo-emacs
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2218338 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, C/C++, SugarActivity, Ocaml, R, Python, Java, Haskell, fonts, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Andrew Bauer zonexpertconsulting@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #14 from Andrew Bauer zonexpertconsulting@outlook.com --- New dangling symlink warnings from rpmlint are expected.
Package ACCEPTED
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Xavier Bachelot xavier@bachelot.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zonexpertconsulti | |ng@outlook.com)
--- Comment #15 from Xavier Bachelot xavier@bachelot.org --- Andrew, you need to set the fedora-review flag to + in order to mark your acceptance of the package. Setting needinfo.
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Andrew Bauer zonexpertconsulting@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zonexpertconsulti |needinfo+ |ng@outlook.com) |
--- Comment #16 from Andrew Bauer zonexpertconsulting@outlook.com --- Wow, this one was from back in October 2023. That was a simple mistake. Setting + now.
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
--- Comment #17 from Benson Muite benson_muite@emailplus.org --- Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo+ |needinfo?(zonexpertconsulti | |ng@outlook.com)
--- Comment #18 from Benson Muite benson_muite@emailplus.org --- Can you unset the fedora-review + sign and set it again? Am not able to request a repository, get the following:
$ fedpkg request-repo skribilo 2218338 Could not execute request_repo: The Bugzilla bug's review was approved over 60 days ago
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Andrew Bauer zonexpertconsulting@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review? |needinfo?(zonexpertconsulti | |ng@outlook.com) |
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Andrew Bauer zonexpertconsulting@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #19 from Andrew Bauer zonexpertconsulting@outlook.com --- re-APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #20 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/skribilo
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-082d52a8da (skribilo-0.10.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-082d52a8da
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-658c4c904a (skribilo-0.10.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-658c4c904a
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-082d52a8da has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-082d52a8da *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-082d52a8da
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-658c4c904a has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-658c4c904a *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-658c4c904a
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2024-11-14 01:16:29
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-082d52a8da (skribilo-0.10.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2218338
--- Comment #26 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-658c4c904a (skribilo-0.10.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com