[Bug 901454] New: Review Request: nodejs-source-map - Generates and consumes source maps
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
Bug ID: 901454 Summary: Review Request: nodejs-source-map - Generates and consumes source maps Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: tchollingsworth@gmail.com
Spec: http://patches.fedorapeople.org/npm/nodejs-source-map.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-source-map-0.1.8-1.fc17.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4880063 FAS username: patches
Generates and consumes source maps
This package is part of the tap stack used to test many Node.js modules.
Please use nodejs-0.6.5-9 or later when building or using this package.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |901452, 901451
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|901452 |
--- Comment #1 from T.C. Hollingsworth tchollingsworth@gmail.com --- This package would BuildRequire npm(dryice) to build the browser, but that requires npm(uglify-js), which would create a dependency loop in Bugzilla. It doesn't like that.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |894725
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jamielinux@fedoraproject.or | |g
--- Comment #2 from Jamie Nguyen jamielinux@fedoraproject.org --- "License: FIXME" should be changed to BSD. "URL: FIXME.now" should be changed to the proper URL.
LICENSE and README.md shouldn't be on line 26 but instead included in %doc.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
--- Comment #3 from Jamie Nguyen jamielinux@fedoraproject.org --- Oh false alarm... looks like you already did that but you only updated the SPEC not the SRPM.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
--- Comment #4 from T.C. Hollingsworth tchollingsworth@gmail.com --- Sorry about that. I've synced the two and fixed a minor bug in the original spec file.
Spec: http://patches.fedorapeople.org/npm/nodejs-source-map.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-source-map-0.1.8-2.fc18.src.rpm
No scratch build because the BuildRequires aren't in Fedora yet.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
--- Comment #5 from Jamie Nguyen jamielinux@fedoraproject.org --- I think the Name tag be nodejs-source-map not source-map?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
--- Comment #6 from Jamie Nguyen jamielinux@fedoraproject.org --- Damn it false alarm again, browser cache had the old version!
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |jamielinux@fedoraproject.or | |g Flags| |fedora-review?
--- Comment #7 from Jamie Nguyen jamielinux@fedoraproject.org --- This line:
BuildRequires: nodejs(amdefine)
Needs to be changed to:
BuildRequires: npm(amdefine)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
--- Comment #8 from Jamie Nguyen jamielinux@fedoraproject.org --- I created an SRPM with the fixed BuildRequires as mentioned in comment #7, but building gives this error:
DEBUG: Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.1EwO53 DEBUG: + umask 022 DEBUG: + cd /builddir/build/BUILD DEBUG: + cd package DEBUG: + /usr/bin/node test/run-tests.js DEBUG: module.js:340 DEBUG: throw err; DEBUG: ^ DEBUG: Error: Cannot find module 'amdefine' DEBUG: at Function.Module._resolveFilename (module.js:338:15) DEBUG: at Function.Module._load (module.js:280:25) DEBUG: at Module.require (module.js:362:17) DEBUG: at require (module.js:378:17) DEBUG: at Object.<anonymous> (/builddir/build/BUILD/package/test/source-map/util.js:8:18) DEBUG: at Module._compile (module.js:454:26) DEBUG: at Object.Module._extensions..js (module.js:472:10) DEBUG: at Module.load (module.js:356:32) DEBUG: at Function.Module._load (module.js:312:12) DEBUG: at Module.require (module.js:362:17) DEBUG: error: Bad exit status from /var/tmp/rpm-tmp.1EwO53 (%check) DEBUG: Bad exit status from /var/tmp/rpm-tmp.1EwO53 (%check)
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #9 from T.C. Hollingsworth tchollingsworth@gmail.com --- Fixed, tests pass now.
Spec: http://patches.fedorapeople.org/npm/nodejs-source-map.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-source-map-0.1.8-3.fc18.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4947247
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
--- Comment #10 from Jamie Nguyen jamielinux@fedoraproject.org --- Package Review ==============
Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed
Issues: ======= [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShor...
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [-]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package -n source-map [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (source-map-0.1.8.tgz) [x]: SourceX is a working URL. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Rpmlint ------- Checking: nodejs-source-map-0.1.8-3.fc18.noarch.rpm nodejs-source-map-0.1.8-3.fc18.src.rpm nodejs-source-map.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-source-map.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-source-map.noarch: W: only-non-binary-in-usr-lib nodejs-source-map.noarch: W: dangling-symlink /usr/lib/node_modules/source-map/node_modules/amdefine /usr/lib/node_modules/amdefine nodejs-source-map.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-source-map.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 6 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-source-map nodejs-source-map.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-source-map.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-source-map.noarch: W: only-non-binary-in-usr-lib nodejs-source-map.noarch: W: dangling-symlink /usr/lib/node_modules/source-map/node_modules/amdefine /usr/lib/node_modules/amdefine 1 packages and 0 specfiles checked; 0 errors, 4 warnings. # echo 'rpmlint-done:'
Requires -------- nodejs-source-map-0.1.8-3.fc18.noarch.rpm (rpmlib, GLIBC filtered):
nodejs(engine) >= 0.8.0 npm(amdefine) >= 0.0.4
Provides -------- nodejs-source-map-0.1.8-3.fc18.noarch.rpm:
nodejs-source-map = 0.1.8-3.fc18 npm(source-map) = 0.1.8
MD5-sum check ------------- http://registry.npmjs.org/source-map/-/source-map-0.1.8.tgz : CHECKSUM(SHA256) this package : 1745dd3ca3ec0cabc847f6c211215700b2eaa1e32df45018fcb9bdf6d4ce5916 CHECKSUM(SHA256) upstream package : 1745dd3ca3ec0cabc847f6c211215700b2eaa1e32df45018fcb9bdf6d4ce5916
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-18-x86_64 Command line :/bin/fedora-review --rpm-spec -n nodejs-source-map-0.1.8-3.fc18.src.rpm
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #11 from Jamie Nguyen jamielinux@fedoraproject.org --- Review approved!
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
--- Comment #12 from T.C. Hollingsworth tchollingsworth@gmail.com --- New Package SCM Request ======================= Package Name: nodejs-source-map Short Description: Generates and consumes source maps Owners: patches Branches: f18 el6 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
--- Comment #13 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- nodejs-amdefine-0.0.4-1.fc18,nodejs-buffer-equal-0.0.0-1.fc18,nodejs-charm-0.1.0-1.fc18,nodejs-deep-equal-0.0.0-2.fc18,nodejs-optimist-0.3.5-1.fc18,nodejs-source-map-0.1.8-3.fc18,nodejs-traverse-0.6.3-2.fc18,nodejs-wordwrap-0.0.2-2.fc18,nodejs-yamlish-0.0.5-1.fc18,uglify-js-2.2.4-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-amdefine-0.0.4-1.fc18,nodejs-...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- nodejs-amdefine-0.0.4-1.fc18, nodejs-buffer-equal-0.0.0-1.fc18, nodejs-charm-0.1.0-1.fc18, nodejs-deep-equal-0.0.0-2.fc18, nodejs-optimist-0.3.5-1.fc18, nodejs-source-map-0.1.8-3.fc18, nodejs-traverse-0.6.3-2.fc18, nodejs-wordwrap-0.0.2-2.fc18, nodejs-yamlish-0.0.5-1.fc18, nodejs-difflet-0.2.3-2.fc18, uglify-js1-1.3.4-1.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
Bug 901454 depends on bug 901451, which changed state.
Bug 901451 Summary: Review Request: nodejs-amdefine - Provide AMD's define() API for declaring modules in the AMD format https://bugzilla.redhat.com/show_bug.cgi?id=901451
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |RAWHIDE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed| |2013-02-15 21:39:50
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=901454
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- nodejs-amdefine-0.0.4-1.fc18, nodejs-buffer-equal-0.0.0-1.fc18, nodejs-charm-0.1.0-1.fc18, nodejs-deep-equal-0.0.0-2.fc18, nodejs-optimist-0.3.5-1.fc18, nodejs-source-map-0.1.8-3.fc18, nodejs-traverse-0.6.3-2.fc18, nodejs-wordwrap-0.0.2-2.fc18, nodejs-yamlish-0.0.5-1.fc18, nodejs-difflet-0.2.3-2.fc18, uglify-js1-1.3.4-1.fc18 has been pushed to the Fedora 18 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla