Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: iscan-firmware - Firmware for Epson flatbed scanners
https://bugzilla.redhat.com/show_bug.cgi?id=483868
Summary: Review Request: iscan-firmware - Firmware for Epson flatbed scanners Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rpm@greysector.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://rathann.fedorapeople.org/review/iscan-firmware.spec SRPM URL: http://rathann.fedorapeople.org/review/iscan-firmware-2.16.0-1.fc9.src.rpm Description: Firmware for the following Epson flatbed scanners:
* GT-1500 / GT-D1000 * Perfection 2480/2580 PHOTO / GT-F500 * Perfection 3170 PHOTO / GT-9400 * Perfection 3490 PHOTO / GT-F520 * Perfection 4180 PHOTO / GT-F600 * Perfection 4490 PHOTO / GT-X750 * Perfection V10/V100 PHOTO / GT-S600 * Perfection V200 PHOTO / GT-F670 * Perfection V30/V300 / GT-F720 / GT-S620 * Perfection V350 PHOTO / GT-F700 * Perfection V500 PHOTO / GT-X770
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483868
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lemenkov@gmail.com AssignedTo|nobody@fedoraproject.org |lemenkov@gmail.com Flag| |fedora-review?
--- Comment #1 from Peter Lemenkov lemenkov@gmail.com 2009-02-04 03:57:35 EDT --- I'll review it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483868
--- Comment #2 from Peter Lemenkov lemenkov@gmail.com 2009-02-04 04:12:08 EDT --- Remarks:
* No idea what is AVASYS Public License (rpmlint also shouts that it doesn't know what is it), however it looks like "Distributable, No Modifications Permitted".
* I found that there are different versions of AVASYS Public License - dated as 2008-04-01 and as 2005-04.01.
* There is also another one license, named LICENSE.EPSON.{en,ja}.txt.
* Missing BR: udev ( rpm -qf /lib/firmware )
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483868
--- Comment #3 from Peter Lemenkov lemenkov@gmail.com 2009-03-01 03:52:35 EDT --- Ping, Dominik.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483868
--- Comment #4 from Dominik 'Rathann' Mierzejewski rpm@greysector.net 2009-03-01 06:02:37 EDT --- (In reply to comment #2)
Remarks:
- No idea what is AVASYS Public License (rpmlint also shouts that it doesn't
know what is it), however it looks like "Distributable, No Modifications Permitted".
Fixed.
- I found that there are different versions of AVASYS Public License - dated as
2008-04-01 and as 2005-04.01.
They're almost identical. The only change is s/EPSON AVASYS/AVASYS/g. Still, included.
- There is also another one license, named LICENSE.EPSON.{en,ja}.txt.
Included.
- Missing BR: udev ( rpm -qf /lib/firmware )
It's not necessary for building, but indeed it should be required for installation to ensure that /lib/firmware is present before installation.
http://rathann.fedorapeople.org/review/iscan-firmware.spec http://rathann.fedorapeople.org/review/iscan-firmware-2.16.0-2.fc9.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483868
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #5 from Peter Lemenkov lemenkov@gmail.com 2009-03-01 09:49:55 EDT --- REVIEW:
+ rpmlint is silent + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines . + The package is licensed with a Fedora approved license and meets the Licensing Guidelines . + The License field in the package spec file matches the actual license. + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package must match the upstream source, as provided in the spec URL.
[petro@Sulaco SOURCES]$ md5sum `ls iscan-plugin-gt-*|sort` ed12335648c893eda194afee38e51351 iscan-plugin-gt-1500-2.1.0-2.c2.i386.rpm ed12335648c893eda194afee38e51351 iscan-plugin-gt-1500-2.1.0-2.c2.i386.rpm.from_srpm f76725766f44debe3f3fec06d0e2023b iscan-plugin-gt-9400-1.0.0-1.c2.i386.rpm f76725766f44debe3f3fec06d0e2023b iscan-plugin-gt-9400-1.0.0-1.c2.i386.rpm.from_srpm 8b1c398ef58769d9ceb77ad771515de3 iscan-plugin-gt-f500-1.0.0-1.c2.i386.rpm 8b1c398ef58769d9ceb77ad771515de3 iscan-plugin-gt-f500-1.0.0-1.c2.i386.rpm.from_srpm b72a512a927b9f2020af817c5a541ae8 iscan-plugin-gt-f520-1.0.0-1.c2.i386.rpm b72a512a927b9f2020af817c5a541ae8 iscan-plugin-gt-f520-1.0.0-1.c2.i386.rpm.from_srpm 5f4137fd69198617b95bd59261affd75 iscan-plugin-gt-f600-1.0.0-1.c2.i386.rpm 5f4137fd69198617b95bd59261affd75 iscan-plugin-gt-f600-1.0.0-1.c2.i386.rpm.from_srpm bb623b47fd457e94f8d6b878b5d9ad99 iscan-plugin-gt-f670-2.0.0-1.c2.i386.rpm bb623b47fd457e94f8d6b878b5d9ad99 iscan-plugin-gt-f670-2.0.0-1.c2.i386.rpm.from_srpm cf191e84b03b28a8b0f629d60ba0b36e iscan-plugin-gt-f700-2.0.0-0.c2.i386.rpm cf191e84b03b28a8b0f629d60ba0b36e iscan-plugin-gt-f700-2.0.0-0.c2.i386.rpm.from_srpm bda9d1dfe5c9524084b01e46a7a9f5e3 iscan-plugin-gt-s600-2.0.0-1.c2.i386.rpm bda9d1dfe5c9524084b01e46a7a9f5e3 iscan-plugin-gt-s600-2.0.0-1.c2.i386.rpm.from_srpm 02c151a49608ae911b1e200672ed236f iscan-plugin-gt-x750-1.0.0-1.c2.i386.rpm 02c151a49608ae911b1e200672ed236f iscan-plugin-gt-x750-1.0.0-1.c2.i386.rpm.from_srpm c33515ec3e57eed680cd599452141d45 iscan-plugin-gt-x770-2.1.0-1.c2.i386.rpm c33515ec3e57eed680cd599452141d45 iscan-plugin-gt-x770-2.1.0-1.c2.i386.rpm.from_srpm [petro@Sulaco SOURCES]$
+ The package successfully compiles and builds into binary rpms on at least one primary architecture:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1210911
+ No additional build dependencies. + The package owns all directories that it creates. + The package does not contain any duplicate files. + Permissions on files are set properly. + Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. + No large documentation files. + Everything, the package includes as %doc, does not affect the runtime of the application. + No header files. + No static libraries. + No pkgconfig(.pc) files. + No libraries files with a suffix. + No .la libtool archives. + Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [25] + All filenames in the package are valid UTF-8.
This package is
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483868
Dominik 'Rathann' Mierzejewski rpm@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from Dominik 'Rathann' Mierzejewski rpm@greysector.net 2009-03-02 12:27:41 EDT --- New Package CVS Request ======================= Package Name: iscan-firmware Short Description: Firmware for Epson flatbed scanners Owners: rathann Branches: F-9 F-10 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483868
Dominik 'Rathann' Mierzejewski rpm@greysector.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483868
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #7 from Kevin Fenzi kevin@tummy.com 2009-03-02 19:22:47 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483868
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2009-03-03 12:15:50 EDT --- iscan-firmware-2.1.0-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/iscan-firmware-2.1.0-3.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483868
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-03-03 12:16:31 EDT --- iscan-firmware-2.1.0-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/iscan-firmware-2.1.0-3.fc9
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483868
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-03-04 11:24:03 EDT --- iscan-firmware-2.1.0-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483868
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |2.1.0-3.fc9 Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483868
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2009-03-04 11:29:10 EDT --- iscan-firmware-2.1.0-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla