Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
Bug ID: 912132 Summary: Review Request: perl-Package-Variant - Parameterizable packages Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: iarnell@gmail.com
Spec URL: http://iarnell.fedorapeople.org/review/perl-Package-Variant.spec SRPM URL: http://iarnell.fedorapeople.org/review/perl-Package-Variant-1.001002-1.fc17.... Description: http://iarnell.fedorapeople.org/review/perl-Package-Variant-1.001002-1.fc17....
Fedora Account System Username: iarnell
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |912066 Depends On| |911911
--- Comment #1 from Iain Arnell iarnell@gmail.com --- Oops. Description: This module allows you to build packages that return different variations depending on what parameters are given.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
--- Comment #2 from Iain Arnell iarnell@gmail.com --- Now that perl-Import-Into is available, there's a scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=5027195
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |psabata@redhat.com Assignee|nobody@fedoraproject.org |psabata@redhat.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
--- Comment #3 from Petr Šabata psabata@redhat.com --- You're missing a build-time dependency, perl(Sub::Name). Required at lib/Package/Variant.pm:53. This gets called in t/11dynamic-build.t
It also isn't detected by rpmbuild while the package users will most likely want it.
The rest of the package looks good.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
--- Comment #4 from Iain Arnell iarnell@gmail.com --- Thanks, Petr. I've added R/BR for perl(Sub::Name).
Spec URL: http://iarnell.fedorapeople.org/review/perl-Package-Variant.spec SRPM URL: http://iarnell.fedorapeople.org/review/perl-Package-Variant-1.001002-2.fc19.... New scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=5036574
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #5 from Petr Šabata psabata@redhat.com --- Splendid. Approving.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #6 from Iain Arnell iarnell@gmail.com --- New Package SCM Request ======================= Package Name: perl-Package-Variant Short Description: Parameterizable packages Owners: iarnell Branches: F17 F18 InitialCC: perl-sig
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- perl-Package-Variant-1.001002-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Package-Variant-1.001002-2.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-Package-Variant-1.001002-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Package-Variant-1.001002-2.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- perl-Package-Variant-1.001002-2.fc17 has been pushed to the Fedora 17 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
Bug 912132 depends on bug 911911, which changed state.
Bug 911911 Summary: Review Request: perl-Import-Into - Import packages into other packages https://bugzilla.redhat.com/show_bug.cgi?id=911911
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2013-03-03 17:25:08
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- perl-Package-Variant-1.001002-2.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=912132
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- perl-Package-Variant-1.001002-2.fc18 has been pushed to the Fedora 18 stable repository.
package-review@lists.fedoraproject.org