Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: nordugrid-arc-doc - Advanced Resource Connector Documentation
https://bugzilla.redhat.com/show_bug.cgi?id=704835
Summary: Review Request: nordugrid-arc-doc - Advanced Resource Connector Documentation Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mattias.ellert@fysast.uu.se QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://www.grid.tsl.uu.se/review/nordugrid-arc-doc.spec SRPM URL: http://www.grid.tsl.uu.se/review/nordugrid-arc-doc-1.0.1-1.fc14.src.rpm Description: This package contains the documentation for the nordugrid-arc package
See package review in Bug #530684.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
Jon Ciesla limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |limb@jcomserv.net AssignedTo|nobody@fedoraproject.org |limb@jcomserv.net Flag| |fedora-review?
--- Comment #1 from Jon Ciesla limb@jcomserv.net 2011-07-16 20:31:17 EDT --- Good:
- rpmlint checks return:
Insignificant spelling errors.
- package meets naming guidelines - package meets packaging guidelines - license (ASL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file
So, nothing. Except, since there are no nordugrid RPMs in Fedora, I see no need for the Provides/Obsoletes you have there. Best to remove them to avoid bloating the yum metadata. Otherwise, it's good.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
--- Comment #2 from Jon Ciesla limb@jcomserv.net 2011-07-16 20:32:15 EDT --- Honestly, the same goes for the main nordugrid-arc spec.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
--- Comment #3 from Mattias Ellert mattias.ellert@fysast.uu.se 2011-07-18 04:27:28 EDT --- Pre-Fedora Provides/Obsoletes removed:
http://www.grid.tsl.uu.se/review/nordugrid-arc-doc.spec http://www.grid.tsl.uu.se/review/nordugrid-arc-doc-1.0.1-1.fc14.src.rpm
(I will do the same for the nordugrid-arc package before importing it in git.)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
Jon Ciesla limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Jon Ciesla limb@jcomserv.net 2011-07-18 06:07:24 EDT --- Excellent, thanks!
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
Mattias Ellert mattias.ellert@fysast.uu.se changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Mattias Ellert mattias.ellert@fysast.uu.se 2011-07-18 07:46:26 EDT --- Many thanks for the review!
Mattias
New Package SCM Request ======================= Package Name: nordugrid-arc-doc Short Description: Advanced Resource Connector Documentation Owners: ellert Branches: f14 f15 el5 el6 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
--- Comment #6 from Jon Ciesla limb@jcomserv.net 2011-07-18 07:55:48 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2011-07-24 10:15:01 EDT --- nordugrid-arc-doc-1.0.2-1.fc14,nordugrid-arc-1.0.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/nordugrid-arc-doc-1.0.2-1.fc14,nordu...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-07-24 10:15:15 EDT --- nordugrid-arc-doc-1.0.2-1.el5,nordugrid-arc-1.0.1-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/nordugrid-arc-doc-1.0.2-1.el5,nordug...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-07-24 10:15:30 EDT --- nordugrid-arc-doc-1.0.2-1.fc15,nordugrid-arc-1.0.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/nordugrid-arc-doc-1.0.2-1.fc15,nordu...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-07-24 10:15:44 EDT --- nordugrid-arc-doc-1.0.2-1.el6,nordugrid-arc-1.0.1-1.el6.1 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nordugrid-arc-doc-1.0.2-1.el6,nordug...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-07-25 23:32:29 EDT --- nordugrid-arc-doc-1.0.2-1.fc14, nordugrid-arc-1.0.1-1.fc14 has been pushed to the Fedora 14 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-08-05 19:57:58 EDT --- nordugrid-arc-doc-1.0.2-1.fc15, nordugrid-arc-1.0.1-1.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |nordugrid-arc-doc-1.0.2-1.f | |c15 Resolution| |ERRATA Last Closed| |2011-08-05 19:58:07
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-08-05 19:58:30 EDT --- nordugrid-arc-doc-1.0.2-1.fc14, nordugrid-arc-1.0.1-1.fc14 has been pushed to the Fedora 14 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nordugrid-arc-doc-1.0.2-1.f |nordugrid-arc-doc-1.0.2-1.f |c15 |c14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-08-10 16:59:29 EDT --- nordugrid-arc-doc-1.0.2-1.el5, nordugrid-arc-1.0.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nordugrid-arc-doc-1.0.2-1.f |nordugrid-arc-doc-1.0.2-1.e |c14 |l5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2011-08-10 17:00:41 EDT --- nordugrid-arc-doc-1.0.2-1.el6, nordugrid-arc-1.0.1-1.el6.1 has been pushed to the Fedora EPEL 6 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=704835
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nordugrid-arc-doc-1.0.2-1.e |nordugrid-arc-doc-1.0.2-1.e |l5 |l6
package-review@lists.fedoraproject.org