[Bug 468155] New: Review Request: robodoc - Extract documentation from source code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: robodoc - Extract documentation from source code

https://bugzilla.redhat.com/show_bug.cgi?id=468155

Summary: Review Request: robodoc - Extract documentation from
                    source code
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://monnerat.fedorapeople.org/robodoc.spec
SRPM URL: http://monnerat.fedorapeople.org/robodoc-4.99.36-1.fc8.src.rpm
Description:
  ROBODoc is a documentation tool (based on the AutoDocs program written
a long time ago by Commodore). It extracts specially formated comment
headers from the source file and puts them in a separate file. ROBODoc
thus allows you to include the program documentation in the source
code and avoid having to maintain two separate documents.
  ROBODoc can format the documentation in HTML, ASCII, AmigaGuide,
LaTeX, or RTF format. It is even possible to include parts of the
source code with function names that point their the documentation. It
also can create index tables for all your variables, classes,
functions, etc.
  The best feature of ROBODoc is that it works with many languages:
Assembler, C, Perl, LISP, Occam, Tcl/Tk, Pascal, Fortran, shell
scripts, and COBOL, basically any language that supports
comments/remarks.

rpmlint is silent.
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=897383

[Bug 468155] Review Request: robodoc - Extract documentation from source code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468155

Lucian Langa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 468155] Review Request: robodoc - Extract documentation from source code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468155

Lucian Langa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Lucian Langa   2008-12-02 01:36:02 EDT ---
Review:

OK  source files match upstream:
        b1a0e0dda99bb26623682e62f0e59051  robodoc-4.99.36.tar.bz2
OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros
consistently.
OK  summary is OK.
OK  description is OK.
OK  dist tag is present.
OK  build root is OK.
OK  license field matches the actual license.
OK  license is open source-compatible.
OK  license text included in package.
OK  BuildRequires are proper.
OK  compiler flags are appropriate.
OK  %clean is present.
OK  package builds in mock (rawhide, x86_64).
OK  package installs properly.
OK  debuginfo package looks complete.
OK  rpmlint is silent.
OK  final provides and requires are sane:
        robodoc = 4.99.36-1.fc10
        robodoc(x86-64) = 4.99.36-1.fc10
  =
        libc.so.6()(64bit)
OK  %check is not present; no test suite upstream. I was able to run program
from the command line and generate a doc file.  
OK  no shared libraries are added to the regular linker search paths.
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  code, not content.
OK  documentation is small, so no -doc subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.
OK  no pkgconfig files.
OK  no static libraries.
OK  no libtool .la files.

Suggestion:
Please consider preserving the timestamp of the modified file (ChangeLog).
A simple call to 'touch -r' will do.

APPROVED.

[Bug 468155] Review Request: robodoc - Extract documentation from source code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468155

--- Comment #2 from Patrick Monnerat   2008-12-02 11:02:25 EDT ---
Many thanks for the review, Lucian. Will apply your suggestion.

[Bug 468155] Review Request: robodoc - Extract documentation from source code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468155

Patrick Monnerat  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #3 from Patrick Monnerat   2008-12-02 11:06:24 EDT ---
New Package CVS Request
=======================
Package Name: robodoc
Short Description: Extract documentation from source code
Owners: monnerat
Branches: F-9 F-10
InitialCC:

[Bug 468155] Review Request: robodoc - Extract documentation from source code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468155

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #4 from Kevin Fenzi   2008-12-03 19:43:29 EDT ---
Consider also using the standard sourceforge url in Source:
http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

cvs done.

[Bug 468155] Review Request: robodoc - Extract documentation from source code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468155

--- Comment #5 from Fedora Update System   2008-12-04 06:06:31 EDT ---
robodoc-4.99.36-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/robodoc-4.99.36-2.fc10

[Bug 468155] Review Request: robodoc - Extract documentation from source code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468155

--- Comment #6 from Fedora Update System   2008-12-04 06:07:58 EDT ---
robodoc-4.99.36-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/robodoc-4.99.36-2.fc9

[Bug 468155] Review Request: robodoc - Extract documentation from source code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468155

--- Comment #7 from Patrick Monnerat   2008-12-04 06:18:05 EDT ---
Thanks for CVS Kevin.
Source URL was a typo :-( Applied your suggestion. Thanks.

[Bug 468155] Review Request: robodoc - Extract documentation from source code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468155

--- Comment #8 from Fedora Update System   2008-12-06 23:24:03 EDT ---
robodoc-4.99.36-2.fc9 has been pushed to the Fedora 9 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 468155] Review Request: robodoc - Extract documentation from source code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468155

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 468155] Review Request: robodoc - Extract documentation from source code

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=468155

--- Comment #9 from Fedora Update System   2008-12-06 23:28:30 EDT ---
robodoc-4.99.36-2.fc10 has been pushed to the Fedora 10 stable repository.  If
problems still persist, please make note of it in this bug report.