[Bug 224254] New: Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

Summary: Review Request: bos - Real-time strategy game using the
                    Stratagus game engine
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://lemenkov.googlepages.com/bos.spec

Description: Invasion - Battle of Survival is a real-time strategy game using the 
Stratagus game engine

Unfortunately I haven't enough space to host whole SRPM, so I give only direct links to the spec-file, shell script for starting game and path to the main source archive:

http://lemenkov.googlepages.com/bos.spec
http://lemenkov.googlepages.com/bos.sh
http://bos.seul.org/files/bos_2_0_1.tar.gz

The main doubt for me is the name of package. Should it be bos or battle-of-survival or stratagus-bos?

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-01-24 16:25 EST -------
Oops!
Accidentally forotten patch:

http://lemenkov.googlepages.com/bos-2.0.1-fixes.patch

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-01-24 22:12 EST -------
> Unfortunately I haven't enough space to host whole SRPM, so I give only direct
> links to the spec-file, shell script for starting game and path to the main
> source archive:

I don't really know if it's approved on bugzilla...

However,
> The main doubt for me is the name of package. Should it be bos or
> battle-of-survival or stratagus-bos?

Your package must have the same name than your tarball name as well as your spec
file.

A lot of thing must be fix in your spec file.
I'll make a full review of your package within a few days.

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-01-26 15:57 EST -------
Ver. 2.0.1-2

- fixed some rpmlint errors and warnings
- added %doc section

http://lemenkov.googlepages.com/bos.spec
http://lemenkov.googlepages.com/bos.sh
http://lemenkov.googlepages.com/bos-2.0.1-fixes.patch

http://bos.seul.org/files/bos_2_0_1.tar.gz

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-01-30 17:15 EST -------
I would suggest using battle-of-survival.  bos is too generic.  See for example,
the flight-of-the-amazon-queen and beneath-a-steel-sky review requests for
naming guidelines.  These packages use the long names instead of the shortened
fotaq/bass names.

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2007-02-05 04:33 EST -------
I have updated the spec file according to the comments, and added a desktop
file. An icon is still missing though...

The package build with mock, and rpmlint reports no errors or warning.s

Eveything can be found here: ftp://open-gnss.org/pub/fedora/battle-of-survival/

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-02-09 04:12 EST -------
during building i got:
+ desktop-file-install --vendor=fedora
--dir=/var/tmp/battle-of-survival-2.0.1-3-root-tjikkun/usr/share/applications
/home/tjikkun/rpmbuild/SOURCES/battle-of-survival.desktop
/home/tjikkun/rpmbuild/SOURCES/battle-of-survival.desktop: key "Categories"
string list not semicolon-terminated, fixing
/var/tmp/battle-of-survival-2.0.1-3-root-tjikkun/usr/share/applications/fedora-battle-of-survival.desktop:
warning: The 'Application' category is not defined by the desktop entry
specification.  Please use one of "AudioVideo", "Audio", "Video", "Development",
"Education", "Game", "Graphics", "Network", "Office", "Settings", "System",
"Utility" instead

It did build ok. Trying to run however failed on my x86_64:
$ battle-of-survival 
Maybe you need to specify another gamepath with '-d /path/to/datadir'?
This is because /usr/bin/battle-of-survival still has stratagus -d /usr/share/bos

Sander

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-03-05 16:21 EST -------
FYI Battle of Survival renamed to Bos Wars.

New site containing new version 2.3 can be found here:

http://www.boswars.org/index.shtml

I uploaded new stull (w/o main source tarball) here:

http://lemenkov.newmail.ru/other/boswars/

Right now it can't be started with new version (2.2.3) of stratagus.

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-03-05 16:23 EST -------
s/stull/stuff/g

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2007-03-07 04:08 EST -------
Peter,

I just read that BOS has been renamed to "Bos Wars" and no include its own
(modfied, sigh) fork of stratagus.

The good news is that they (the BOS team) are no supporting lua5.1 with this
fork out of the box.

So I guess its time todo a new version and review that, maybe even in a new
review request, but I'll leave that up to you.

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium

------- Additional Comments From [e-mail]  2007-04-02 14:04 EST -------
Peter, are you still interested in this? IOW ping?

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-04-02 14:06 EST -------
Forget my last 2 comments please, I just saw in comment 7 that you already
packaged 2.3, duh!

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-04-02 16:27 EST -------
(In reply to comment #11)
> Forget my last 2 comments please, I just saw in comment 7 that you already
> packaged 2.3, duh!

Actually I still can't make it work with default stratagus. Things looks like we
should focus on packaging previous release first instead of making patch-fest
with unclear results with the latest one.

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-04-02 16:33 EST -------
Why don't you just use the included stratagus? They forked stratagus as they
wanted to make some changes there, so the new boswars is not designed to work
with the plain stratagus. I think its necessary (and OK) to also package the
included stratagus version together with the data. Much like tremulous which is
a modified quake engine comes with its own copy, which also is packaged as par
of the tremulous package, even though the code is 95-99% quake.

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-04-17 14:07 EST -------
Peter, are you still interested in this? Maybe we can exchange reviews? I myself
also have several game packages awaiting review:

* asc-music - Background music for the game asc -
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233256 - requires asc
* vegastrike - 3D OpenGL spaceflight simulator -
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233782
* vegastrike-data - Data files for Vega Strike -
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233783
* ballz - Platform game with some puzzle elements -
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236798

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|normal                      |medium

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

------- Additional Comments From [e-mail]  2007-04-22 18:33 EST -------
It builds but does not run:

Loading AI: passive.lua
src/ai/script_ai.cpp:345: incorrect argument
incorrect argument
stack traceback:
        [C]: in function 'DefineAi'
        [string "/usr/share/boswars/scripts/ai.lua"]:43: in function 'RegisterAi'
        [string "/usr/share/boswars/scripts/ais/passive.lua"]:34: in main chunk
        [C]: in function 'Load'
        [string "/usr/share/boswars/scripts/ai.lua"]:101: in main chunk
        [C]: in function 'Load'
        [string "/usr/share/boswars/scripts/stratagus.lua"]:220: in main chunk

I traced this down to stratagus vs. bundled boswars stratagus fork. In
ai/script_ai.cpp, CclDefineAi function, stratagus from Fedora srpm checks for 4
arguments, the bundled boswars engine 3. Unless you want to patch the scripts
and whatever else boswars does differently to match stratagus, this seems
another vote for using included stratagus.

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-05-03 14:09 EST -------
Peter, ping?

I'm willing to review this for you, but first please provide a new srpm based on
the latest upstream release, using the included stratagus fork. Since this is
clearly different (and becoming more different every release) from the
stand-alone stratagus project, it is ok to include the private fork. Just like
is done with many games which come with modded quake engines.

[Bug 224254] Review Request: bos - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bos - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-05-04 00:18 EST -------
(In reply to comment #16)
> Peter, ping?

Still here!
> I'm willing to review this for you, but first please provide a new srpm based on
> the latest upstream release, using the included stratagus fork. Since this is
> clearly different (and becoming more different every release) from the
> stand-alone stratagus project, it is ok to include the private fork. Just like
> is done with many games which come with modded quake engines.

OK.
I'll do it in a couple of days.

[Bug 224254] Review Request: boswars - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boswars - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: bos - Real- |Review Request: boswars -
                   |time strategy game using the|Real-time strategy game
                   |Stratagus game engine       |using the Stratagus game
                   |                            |engine

[Bug 224254] Review Request: boswars - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boswars - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-05-06 01:55 EST -------
http://lemenkov.googlepages.com/boswars.spec
http://lemenkov.googlepages.com/boswars.sh
http://lemenkov.googlepages.com/boswars.desktop
http://lemenkov.googlepages.com/boswars--SConstruct.diff

http://www.boswars.org/releases/boswars-2.3-src.tar.gz

Still using internal version of guichan and tolua instead of system ones.

[Bug 224254] Review Request: boswars - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boswars - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

------- Additional Comments From [e-mail]  2007-05-06 03:11 EST -------
(In reply to comment #18)
> Still using internal version of guichan and tolua instead of system ones.

Didn't we fix that already for the stand-alone stratagus, couldn't those patches
be easily ported over? I think this is a blocker, so I would like to have this
sorted out before doing a full review.

[Bug 224254] Review Request: boswars - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boswars - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |
              nThis|                            |

------- Additional Comments From [e-mail]  2007-07-04 11:40 EST -------
Has there been any progress here?

[Bug 224254] Review Request: boswars - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boswars - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
               Flag|                            |needinfo?([e-mail]
                   |                            |)

------- Additional Comments From [e-mail]  2007-07-27 19:21 EST -------
It's been 2.5 months since the last response from the submitter; setting
NEEDINFO.  I'll close this ticket soon if there's no response.

[Bug 224254] Review Request: boswars - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boswars - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |CLOSED
         Resolution|                            |NOTABUG
               Flag|needinfo?([e-mail]|
                   |)                           |

------- Additional Comments From [e-mail]  2007-08-03 18:18 EST -------
And still no response; closing.

[Bug 224254] Review Request: boswars - Real-time strategy game using the Stratagus game engine

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: boswars - Real-time strategy game using the Stratagus game engine

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224254

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |201449
              nThis|                            |